Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruamel.yaml broken on Python 3.4 and 3.8-dev #274

Closed
jayvdb opened this issue Jul 8, 2019 · 3 comments · Fixed by #285
Closed

ruamel.yaml broken on Python 3.4 and 3.8-dev #274

jayvdb opened this issue Jul 8, 2019 · 3 comments · Fixed by #285
Assignees
@jayvdb

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 8, 2019

https://github.com/moremoban/moban/blob/dev/requirements.txt lists ruamel.yaml>=0.15.5

Python 3.4 test coverage was removed from moban in
bb8c747#diff-354f30a63fb0907d4ad57269548329e3 (without a note in the changelog)

coala still needs it until we do one more release.

When that dep is fixed, another also breaks:

Downloading https://files.pythonhosted.org/packages/a2/6a/a3d20e80ee4fee7c55c022fb28d52239bd01171edd3c137dd1e2ef8b2a20/arrow-0.14.2-py2.py3-none-any.whl
arrow requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*' but the running Python is 3.4.8
The command "pip install -r tests/requirements.txt" failed and exited with 1 during .

The log https://travis-ci.org/jayvdb/moban/jobs/555568289 doesnt show which test requirement is dependent on arrow.

Potentially, if needed to speed up the builds, put lower support jobs in the matrix to only run on master builds, so that newcomers dont need to worry about them, and decisions can be made to drop them when fixing them is too difficult.

See coala-bears .travis.yml for examples of running job only on master
@jayvdb
Copy link
Member Author

jayvdb commented Jul 8, 2019

jinja2-time depends on arrow since its inception.
arrow dropped py34 support in 0.14.0 https://github.com/crsmithdev/arrow/blob/master/HISTORY.md

@jayvdb
Copy link
Member Author

jayvdb commented Jul 8, 2019 •
edited
Loading

Also ruamel.yaml==0.15.5 is broken on Python 3.7, detected by using MINREQ=1.
https://travis-ci.org/jayvdb/moban/jobs/555574463

@jayvdb jayvdb self-assigned this Jul 8, 2019
jayvdb added a commit to jayvdb/moban that referenced this issue Jul 8, 2019
@jayvdb
🔥 add ruamel-yaml pins to aid installation
a8ff734 
Re-adds Python 3.4 support, broken by ruamel-yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8-dev.
And avoids newer arrow desupported on Python 3.4.

Closes moremoban#274
This was referenced Jul 8, 2019
Closed
Closed
jayvdb added a commit to jayvdb/moban that referenced this issue Jul 8, 2019
@jayvdb
🔥 add ruamel-yaml pins to aid installation
1041efb 
Re-adds Python 3.4 support, broken by ruamel-yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8-dev.
And avoids newer arrow desupported on Python 3.4.

Fixes moremoban#274
jayvdb added a commit to jayvdb/moban that referenced this issue Jul 8, 2019
@jayvdb
🔥 add ruamel-yaml pins to aid installation
62c314f 
Re-adds Python 3.4 support, broken by ruamel-yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8-dev.
And avoids newer arrow desupported on Python 3.4.

Fixes moremoban#274
@jayvdb jayvdb mentioned this issue Jul 8, 2019
Merged
jayvdb added a commit to jayvdb/moban that referenced this issue Jul 8, 2019
@jayvdb
🔥 add ruamel-yaml pins to aid installation
574084c 
Re-adds Python 3.4 support, broken by ruamel-yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8-dev.
And avoids newer arrow desupported on Python 3.4.

Fixes moremoban#274
jayvdb added a commit to jayvdb/moban that referenced this issue Jul 8, 2019
@jayvdb
🚑 choose version of ruamel.yaml
b2a11b2 
Re-adds Python 3.4 support, broken by ruamel.yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8-dev.
And avoids newer arrow desupported on Python 3.4.

Fixes moremoban#274
jayvdb added a commit to jayvdb/moban that referenced this issue Jul 9, 2019
@jayvdb
🚑 choose version of ruamel.yaml
4f598a9 
Re-adds Python 3.4 support, broken by ruamel.yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8-dev.
And avoids newer arrow desupported on Python 3.4.

Fixes moremoban#274
jayvdb added a commit to jayvdb/moban that referenced this issue Jul 9, 2019
@jayvdb
🚑 choose version of ruamel.yaml
7f09acd 
Re-adds Python 3.4 support, broken by ruamel.yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8-dev.
And avoids newer arrow desupported on Python 3.4.

Fixes moremoban#274
@jayvdb jayvdb changed the title ruamel.yaml broken on Python 3.4 ruamel.yaml broken on Python 3.4 and 3.8-dev Jul 9, 2019
@jayvdb
Copy link
Member Author

jayvdb commented Jul 9, 2019 •
edited
Loading

master and dev branches also broken by 3.8-dev , even with the latest version.
https://travis-ci.org/moremoban/moban/builds/556102404

raised upstream https://bitbucket.org/ruamel/yaml/issues/296/another-python-38-dev-compilation-breakage

jayvdb added a commit to jayvdb/moban that referenced this issue Jul 9, 2019
@jayvdb
🚑 choose version of ruamel.yaml
43d7f8a 
Re-adds Python 3.4 support, broken by ruamel.yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7.
And avoids newer arrow desupported on Python 3.4.

Fixes moremoban#274
@jayvdb jayvdb mentioned this issue Jul 12, 2019
Closed
jayvdb added a commit to jayvdb/moban that referenced this issue Jul 12, 2019
@jayvdb
🚑 choose version of ruamel.yaml
2887892 
Re-adds Python 3.4 support, broken by ruamel.yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8,
and re-adds Python 3.8-dev to the Travis matrix recently removed
in ec48af4 due to temporary build failures.

And avoids newer arrow desupported on Python 3.4.

Fixes moremoban#274
jayvdb added a commit to jayvdb/moban that referenced this issue Jul 13, 2019
@jayvdb
🚑 choose version of ruamel.yaml
5e895b6 
Re-adds Python 3.4 support, broken by ruamel.yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8,
and re-adds Python 3.8-dev to the Travis matrix recently removed
in ec48af4 due to temporary build failures.

And avoids newer arrow desupported on Python 3.4.

Fixes moremoban#274
@chfw chfw closed this as completed in #285 Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayvdb jayvdb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ruamel-yaml pins to aid installation jayvdb/moban
1 participant
@jayvdb