Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds mongodbatlas_stream_privatelink_endpoint resource and data sources #2924

Merged
merged 16 commits into from
Jan 22, 2025

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Dec 23, 2024

Description

Adds mongodbatlas_stream_privatelink_endpoint resource and data sources

Link to any related issue(s): CLOUDP-291804

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

oarbusi and others added 8 commits December 12, 2024 10:04
…ture and resource schema (#2878)

* initial scaffolding and generation of schema

* schema adjustments

* temporary nolint:gocritic for commented out code

* comment out test
…es schema (#2884)

* data source schema

* comment out implementation
…2890)

* initial implementation of resource

* implement resource & model conversion necessary for resource

* handle nil/empty dnssubdomain

* refresh function for the deletion of the resource

* empty list for dnsSubDomain attribute

* retry strategy for creation

* changelog

* adjust latest SDK

* fix unit test after dnssubdomain fix

* fix generate docs all check
…ces (#2897)

* singular data source

* plural data source

* changelog

* example check fix

* pr

* use correct states for creation
…ce and data source (#2910)

* wip: tests

* set up confluent provider in tests

* test fixes

* run tests in CI

* adjust migration test to use confluent external provider

* change detection

* depends on

* specific project for tests

* failedonupdate fix

* test improvement

* changes to tests

* remove config in import step

* externalprovider for failed update test case

* error on update
…l to easily support future vendors (#2921)

* change required and validate in model conversion

* test required
…oint` resource and data sources (#2923)

* examples

* generate docs

* fix example

* pr docs copy

* versions

* format

* fix

* pr comments

* docs update for example update

* docs generation

* Update examples/mongodbatlas_stream_privatelink_endpoint/confluent_dedicated_cluster/README.md

Co-authored-by: maastha <122359335+maastha@users.noreply.github.com>

* Update examples/mongodbatlas_stream_privatelink_endpoint/confluent_dedicated_cluster/README.md

Co-authored-by: maastha <122359335+maastha@users.noreply.github.com>

* Update examples/mongodbatlas_stream_privatelink_endpoint/confluent_serverless/README.md

Co-authored-by: maastha <122359335+maastha@users.noreply.github.com>

* Update examples/mongodbatlas_stream_privatelink_endpoint/confluent_serverless/README.md

Co-authored-by: maastha <122359335+maastha@users.noreply.github.com>

* version constraint

---------

Co-authored-by: maastha <122359335+maastha@users.noreply.github.com>
@oarbusi
Copy link
Collaborator Author

oarbusi commented Dec 23, 2024

DO NOT MERGE YET

Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Dec 30, 2024
@github-actions github-actions bot closed this Jan 1, 2025
@oarbusi oarbusi reopened this Jan 7, 2025
@oarbusi oarbusi added not_stale Not stale issue or PR and removed stale labels Jan 7, 2025
…_connection` resource and data sources (#2940)

* wip: networking attributes for private link connection

* changelog

* changelog fix

* final adjustments

* ajustments

* final adjustment

* fix conversion

* test privatelink in stream connection

* skip test

* skip mig test

* add reason on skipped mig test

* clean up leftover from wrong api
@oarbusi oarbusi marked this pull request as ready for review January 20, 2025 10:17
@oarbusi oarbusi requested review from a team as code owners January 20, 2025 10:17
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

@oarbusi oarbusi merged commit 9e74b84 into master Jan 22, 2025
40 checks passed
@oarbusi oarbusi deleted the CLOUDP-288973-stream-privatelink branch January 22, 2025 08:53
svc-apix-Bot added a commit that referenced this pull request Jan 22, 2025
lantoli added a commit that referenced this pull request Jan 22, 2025
* master:
  test: Increase create timeout to reduce test flakyness (#2991)
  chore: Bump golangci/golangci-lint-action from 6.1.1 to 6.2.0 (#2987)
  chore: Bump tj-actions/verify-changed-files (#2986)
  chore: Bump marocchino/sticky-pull-request-comment from 2.9.0 to 2.9.1 (#2988)
  chore: Bump actions/setup-go from 5.2.0 to 5.3.0 (#2989)
  chore: Bump actions/stale from 9.0.0 to 9.1.0 (#2990)
  chore: Updates CHANGELOG.md for #2924
  feat: Adds `mongodbatlas_stream_privatelink_endpoint` resource and data sources (#2924)
  chore: Increase timeout of `mongodbatlas_stream_connection` deletion and add network peering for VPC test (#2976)

# Conflicts:
#	internal/common/retrystrategy/retry_state.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants