Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct dnsSubDomain value sent in the API request when empty in the configuration #2925

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Dec 23, 2024

Description

Correct dnsSubDomain value sent in the API request when empty in the configuration

Link to any related issue(s): CLOUDP-290328

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Dec 29, 2024
@github-actions github-actions bot closed this Jan 1, 2025
@oarbusi oarbusi added not_stale Not stale issue or PR and removed stale labels Jan 7, 2025
@oarbusi oarbusi reopened this Jan 7, 2025
@oarbusi oarbusi marked this pull request as ready for review January 7, 2025 14:02
@oarbusi oarbusi requested a review from a team as a code owner January 7, 2025 14:02
@oarbusi oarbusi merged commit 4e15928 into CLOUDP-288973-stream-privatelink Jan 7, 2025
86 of 88 checks passed
@oarbusi oarbusi deleted the CLOUDP-290328 branch January 7, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not_stale Not stale issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant