Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove!: Removes items_per_page and page_num from data_source_privatelink_endpoints_service_serverless #2336

Merged
merged 7 commits into from
Jun 10, 2024
Merged

remove!: Removes items_per_page and page_num from data_source_privatelink_endpoints_service_serverless #2336

merged 7 commits into from
Jun 10, 2024

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Jun 10, 2024

Description

Removes items_per_page and page_num from data_source_privatelink_endpoints_service_serverless
Link to any related issue(s): CLOUDP-253079

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi marked this pull request as ready for review June 10, 2024 07:39
@oarbusi oarbusi requested review from a team as code owners June 10, 2024 07:39
@github-actions GitHub Actions
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

andreaangiolillo
andreaangiolillo approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...privatelinkendpointserviceserverless/data_source_privatelink_endpoints_service_serverless.go
@@ -25,16 +23,6 @@ func PluralDataSource() *schema.Resource {
Required: true,
ForceNew: true,
},
"page_num": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the related datasource documentation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not in the documentation

AgustinBettati
AgustinBettati approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.changelog/2336.txt Outdated Show resolved Hide resolved
@oarbusi @AgustinBettati
Update .changelog/2336.txt
1d431ef 
Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com>
EspenAlbert
EspenAlbert approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jwilliams-mongo
jwilliams-mongo approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@jwilliams-mongo jwilliams-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oarbusi LGTM % one minor adjustment

website/docs/guides/1.17.0-upgrade-guide.html.markdown Outdated Show resolved Hide resolved
@oarbusi @jwilliams-mongo
Update website/docs/guides/1.17.0-upgrade-guide.html.markdown
a7aedd1 
Co-authored-by: John Williams <55147273+jwilliams-mongo@users.noreply.github.com>
@oarbusi oarbusi merged commit 5b80c57 into master Jun 10, 2024
35 checks passed
@oarbusi oarbusi deleted the CLOUDP-253079 branch June 10, 2024 14:20
svc-apix-Bot added a commit that referenced this pull request Jun 10, 2024
@svc-apix-Bot
chore: Updates CHANGELOG.md for #2336
cbe5bd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maastha maastha maastha approved these changes

@jwilliams-mongo jwilliams-mongo jwilliams-mongo approved these changes

@AgustinBettati AgustinBettati AgustinBettati approved these changes

@EspenAlbert EspenAlbert EspenAlbert approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oarbusi @andreaangiolillo @EspenAlbert @AgustinBettati @jwilliams-mongo @maastha