Skip to content

Commit

Permalink
remove!: Removes items_per_page and page_num from `data_source_pr…
Browse files Browse the repository at this point in the history
…ivatelink_endpoints_service_serverless` (#2336)

* remove items_per_page and page_num

* update upgrade guide

* fix changelog entry

* Update .changelog/2336.txt

Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com>

* correct datasource name

* fix

* Update website/docs/guides/1.17.0-upgrade-guide.html.markdown

Co-authored-by: John Williams <55147273+jwilliams-mongo@users.noreply.github.com>

---------

Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com>
Co-authored-by: John Williams <55147273+jwilliams-mongo@users.noreply.github.com>
  • Loading branch information
3 people authored Jun 10, 2024
1 parent 484544d commit 5b80c57
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 12 deletions.
3 changes: 3 additions & 0 deletions .changelog/2336.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:breaking-change
data-source/mongodbatlas_privatelink_endpoints_service_serverless: Removes `page_num` and `items_per_page` arguments
```
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@ package privatelinkendpointserviceserverless

import (
"context"
"fmt"

"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/id"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/constant"
"github.com/mongodb/terraform-provider-mongodbatlas/internal/config"
"go.mongodb.org/atlas-sdk/v20231115014/admin"
)
Expand All @@ -25,16 +23,6 @@ func PluralDataSource() *schema.Resource {
Required: true,
ForceNew: true,
},
"page_num": {
Deprecated: fmt.Sprintf(constant.DeprecationParamByVersion, "1.17.0"),
Type: schema.TypeInt,
Optional: true,
},
"items_per_page": {
Deprecated: fmt.Sprintf(constant.DeprecationParamByVersion, "1.17.0"),
Type: schema.TypeInt,
Optional: true,
},
"results": {
Type: schema.TypeList,
Computed: true,
Expand Down
1 change: 1 addition & 0 deletions website/docs/guides/1.17.0-upgrade-guide.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ The Terraform MongoDB Atlas Provider version 1.17.0 has a number of new and exci
`terraform import mongodbatlas_federated_settings_identity_provider.identity_provider <federation_settings_id>-<idp_id>`
3. Run `terraform plan`.
4. Run `terraform apply`.
- Attributes `page_num` and `items_per_page` removed from [`mongodbatlas_privatelink_endpoints_service_serverless`](https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/data-sources/privatelink_endpoints_service_serverless) data source.

### Helpful Links

Expand Down

0 comments on commit 5b80c57

Please sign in to comment.