Return proper value instead of _id on QueryBuilder #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenssegers
approved these changes
Aug 1, 2019
Flambe
pushed a commit
to intergral/laravel-mongodb
that referenced
this pull request
Oct 11, 2019
* 👷 Travis * Add arg PHP-VERSION in Dockerfile * Delete empty row * Add build arg in docker-compose.yml * Add changes to Dcokerfile * Separate installing vendors by composer use official image of composer * Delete use composer image * Add default value PHP_VERSION * 🐳 Provide default docker arg * Fix issue using query builder first method * EmbedsMany respect primaryKey on association * fix typos * laravel/lumen 5.7.14 compatibility Updated model to be compatible with laravel/lumen 5.7.14 * Overrided whereIn method retrieval for relations, to force use standart whereIn nor whereInRawInteger * fix bug The main solution is to solve the bugs encountered in using database alone * reassigned getDatabaseName method * Remove dead code * Update Model.php * Update supported versions * Require Laravel 5.8 * Fix tests (mongodb#1724) * Update Dockerfile, add for methods setUp and tearDown return type hint in all tests, replace fire on dispatch * Resolve error test with touch * Use COMPOSER_VERSION in Dockerfile * Add alias for composer * Change parent method's names Broken commit in laravel: laravel/framework@2ee1892 * Remove changes in .travis.yml * Remove changes from Dockerfile * Revert changes in docker-compose.yml * Update image with mysql * 🐳 New travis docker setup * Update phpunit.xml (mongodb#1733) * Add arg options for creating collections with options (mongodb#1734) * fix chunkById for types other than ObjectId and laravel >= 5.6.25 (mongodb#1543) * Adds support for _id of binary type (mongodb#1611) * Create FUNDING.yml * Update FUNDING.yml * Update FUNDING.yml * Add hasIndex and dropIndexIfExists methods * Revert changes in Builder and Model for id keys, fix test for Queue (mongodb#1795) * Revert changes in Builder and Model for id keys, fix test for Queue * Fix format in Model * Get base query before update so that scopes are applied (mongodb#1799) Fixes mongodb#1798 * Return proper value instead of _id on QueryBuilder (mongodb#1747) Fixes mongodb#1741 * fix for non string id * use env values from phpunit.xml, update database.php and queue.php (mongodb#1738) * use env values from phpunit.xml, update database.php and queue.php * Add .editorconfig * Update QueueTest.php * Update phpunit.xml.dist * Use in casting instead intval * Change operator (-> to ::) * Code cleanup * Add hasIndex and dropIndexIfExists methods * ⬆️ Support for laravel 6 * ♻️ Make tests compatible with latest phpunit version * 🚨 Linting * ✅ Replace str_random usage * Update src/Jenssegers/Mongodb/Relations/EmbedsMany.php Co-Authored-By: Jens Segers <segers.jens@gmail.com> * fix filtering with operator not like issue * replcae string operation with exact match of (not like) * add test to not like oepration fix * fix regex demo code
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation for
QueryBuilder::valuedoesn't work with mongo, due to the fact that when using a projection, mongo always returns the_id.This change accommodates for that, and also allows using dot notation to get a nested value.
Fixes #1741