Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #1724

Merged
merged 9 commits into from
Mar 12, 2019
Merged

Fix tests #1724

merged 9 commits into from
Mar 12, 2019

Conversation

Smolevich
Copy link
Contributor

@Smolevich Smolevich commented Mar 5, 2019 •
edited
Loading

  • Update travis ci matrix(add PHP 7.3) (removed from this PR, will be moved in another PR)
  • Update Dockerfile, use alpine image instead debian image (removed from this PR, will be moved in another PR)
  • Fix tests
  • Update composer.json

Stanislav Shupilkin added 2 commits March 5, 2019 18:11
@Smolevich
Copy link
Contributor Author

Smolevich commented Mar 5, 2019 •
edited
Loading

@jenssegers , can you review please? It important for using library

jenssegers
jenssegers reviewed Mar 6, 2019
View reviewed changes
Dockerfile Outdated
gcc \
openssl-dev \
libzip-dev; \
pecl install mongodb-1.5.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this fixed version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can't we still use the docker-php-ext-install?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mongodb-1.5.3 latest stable version in https://pecl.php.net/package/mongodb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In original Dockerfile used https://github.com/jenssegers/laravel-mongodb/blob/master/Dockerfile#L10
pecl install mongodb && docker-php-ext-enable mongodb

jenssegers
jenssegers reviewed Mar 6, 2019
View reviewed changes
Copy link
Contributor

@jenssegers jenssegers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can separate the Travis changes and the fixes? Or are the Travis changed required?

@Smolevich
Copy link
Contributor Author

Smolevich commented Mar 6, 2019 •
edited
Loading

Any chance we can separate the Travis changes and the fixes? Or are the Travis changed required?

It is possible, but better change all in this PR

@Smolevich
Copy link
Contributor Author

@jenssegers, i can remove fix tests from this PR and move in another PR for understanding. Can you review this changes tomorrow?

This was referenced Mar 10, 2019
Closed
Closed
@jenssegers
Copy link
Contributor

Yes, would rather have these 2 things as separate PR's if possible 👌

@Smolevich
Copy link
Contributor Author

@jenssegers, for this PR i delete changes for travis ci and docker-compose and move in another PR. Please see both PR tomorrow

@Smolevich Smolevich changed the title Update travis ci, fix tests Fix tests Mar 11, 2019
jenssegers
jenssegers reviewed Mar 11, 2019
View reviewed changes
docker-compose.yml Outdated
@@ -9,7 +9,7 @@ services:
volumes:
- .:/code
working_dir: /code
command: bash -c "composer install --prefer-source --no-interaction && php ./vendor/bin/phpunit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also revert these changes please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenssegers, I reverted this changes

@jenssegers jenssegers merged commit bdb15c9 into mongodb:master Mar 12, 2019
@Smolevich Smolevich mentioned this pull request Mar 12, 2019
Closed
Flambe pushed a commit to intergral/laravel-mongodb that referenced this pull request Oct 11, 2019
@ScottSpittle @Flambe
Merge latest (#4)
2e5d6b9 
* 👷 Travis

* Add arg PHP-VERSION in Dockerfile

* Delete empty row

* Add build arg in docker-compose.yml

* Add changes to Dcokerfile

* Separate installing vendors by composer use official image of composer

* Delete use composer image

* Add default value PHP_VERSION

* 🐳 Provide default docker arg

* Fix issue using query builder first method

* EmbedsMany respect primaryKey on association

*  fix typos

* laravel/lumen 5.7.14 compatibility

Updated model to be compatible with laravel/lumen 5.7.14

* Overrided whereIn method retrieval for relations, to force use standart whereIn nor whereInRawInteger

* fix bug

The main solution is to solve the bugs encountered in using database alone

* reassigned getDatabaseName method

* Remove dead code

* Update Model.php

* Update supported versions

* Require Laravel 5.8

* Fix tests (mongodb#1724)

*   Update Dockerfile, add for methods setUp and tearDown return type hint in all tests, replace fire on dispatch

* Resolve error test with touch

* Use COMPOSER_VERSION in Dockerfile

* Add alias for composer

* Change parent method's names
Broken commit in laravel: laravel/framework@2ee1892

* Remove changes in .travis.yml

* Remove changes from Dockerfile

* Revert changes in docker-compose.yml

* Update image with mysql

* 🐳 New travis docker setup

* Update phpunit.xml (mongodb#1733)

* Add arg options for creating collections with options (mongodb#1734)

* fix chunkById for types other than ObjectId and laravel >= 5.6.25 (mongodb#1543)

* Adds support for _id of binary type (mongodb#1611)

* Create FUNDING.yml

* Update FUNDING.yml

* Update FUNDING.yml

* Add hasIndex and dropIndexIfExists methods

* Revert changes in Builder and Model for id keys, fix test for Queue (mongodb#1795)

* Revert changes in Builder and Model for id keys, fix test for Queue

* Fix format in Model

* Get base query before update so that scopes are applied (mongodb#1799)

Fixes mongodb#1798

* Return proper value instead of _id on QueryBuilder (mongodb#1747)

Fixes mongodb#1741

* fix for non string id

* use env values from phpunit.xml, update database.php and queue.php (mongodb#1738)

* use env values from phpunit.xml, update database.php and queue.php

* Add .editorconfig

* Update QueueTest.php

* Update phpunit.xml.dist

* Use in casting instead intval

* Change operator (-> to ::)

* Code cleanup

* Add hasIndex and dropIndexIfExists methods

* ⬆️ Support for laravel 6

* ♻️ Make tests compatible with latest phpunit version

* 🚨 Linting

* ✅ Replace str_random usage

* Update src/Jenssegers/Mongodb/Relations/EmbedsMany.php

Co-Authored-By: Jens Segers <segers.jens@gmail.com>

* fix filtering with operator not like issue

* replcae string operation with exact match of (not like)

* add test to not like oepration fix

* fix regex demo code
@divine divine mentioned this pull request Jan 19, 2020
Closed
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
@mnphpexpert
Fix tests (mongodb#1724)
17da25e 
*   Update Dockerfile, add for methods setUp and tearDown return type hint in all tests, replace fire on dispatch

* Resolve error test with touch

* Use COMPOSER_VERSION in Dockerfile

* Add alias for composer

* Change parent method's names
Broken commit in laravel: laravel/framework@2ee1892

* Remove changes in .travis.yml

* Remove changes from Dockerfile

* Revert changes in docker-compose.yml

* Update image with mysql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenssegers jenssegers jenssegers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smolevich @jenssegers