Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-5324): update to typescript 5 #579

Merged
merged 2 commits into from
Jun 1, 2023
Merged

chore(NODE-5324): update to typescript 5 #579

merged 2 commits into from
Jun 1, 2023

Conversation

durran
Copy link
Member

@durran durran commented May 31, 2023 •
edited
Loading

Description

Updates the driver to use Typescript 5.

What is changing?

  • Updates typescript to ^5.0.4
  • Updates api-extractor to ^7.35.1 (to use typescript 5)
  • All other typescript dependencies were already further along than the minimum.
  • Removes the importsNotUsedAsValues config and replaces with eslint rule.
  • Updates all the files to adhere to new eslint rule.
  • Fixes the number comparison between number and Int32.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5324

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken self-requested a review May 31, 2023 20:39
@nbbeeken nbbeeken self-assigned this May 31, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 31, 2023
nbbeeken
nbbeeken reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, question about valueOf

src/timestamp.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken mentioned this pull request May 31, 2023
Merged
5 tasks
@durran durran requested a review from nbbeeken June 1, 2023 18:31
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 1, 2023
@nbbeeken nbbeeken merged commit 81227bf into main Jun 1, 2023
@nbbeeken nbbeeken deleted the NODE-5324 branch June 1, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durran @nbbeeken