chore(NODE-5323): update to typescript 5 #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
commented
May 31, 2023
| @@ -17,7 +17,6 @@ | |||
| // Never emit error filled code | |||
| "noEmitOnError": true, | |||
| "outDir": "lib", | |||
| "importsNotUsedAsValues": "error", | |||
There was a problem hiding this comment.
This is deprecated, now using eslint rule.
durran
commented
May 31, 2023
| @@ -88,6 +88,14 @@ | |||
| ], | |||
| "@typescript-eslint/no-explicit-any": "off", | |||
| "@typescript-eslint/require-await": "off", | |||
| "@typescript-eslint/consistent-type-imports": [ | |||
There was a problem hiding this comment.
This is the new rule replacing the deprecated importsNotUsedAsValues typescript config.
durran
commented
May 31, 2023
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Jun 1, 2023
nbbeeken
requested changes
Jun 2, 2023
src/cmap/connect.ts
Outdated
| hello && | ||
| typeof hello.maxWireVersion?.valueOf() === 'number' && | ||
| hello.maxWireVersion >= MIN_SUPPORTED_WIRE_VERSION; | ||
| hello && !Number.isNaN(maxWireVersion) && hello.maxWireVersion >= MIN_SUPPORTED_WIRE_VERSION; |
There was a problem hiding this comment.
Suggested change
| hello && !Number.isNaN(maxWireVersion) && hello.maxWireVersion >= MIN_SUPPORTED_WIRE_VERSION; | |
| !Number.isNaN(maxWireVersion) && hello.maxWireVersion >= MIN_SUPPORTED_WIRE_VERSION; |
If hello is nullish which I don't think it can be then the lines 82/83 will throw, so we can remove this check
nbbeeken
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the driver to use Typescript 5.
What is changing?
importsNotUsedAsValuesconfig and replaces with eslint rule.numberandInt32.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5323
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript