Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import-terms-for-logical-axioms.md #8723

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nicolevasilevsky
Copy link
Member

No description provided.

2. Add the term ID in Column A for the term you want to add a subclass axiom to
3. In the subclassOf Axiom column (column L on this spreadsheet), add the IRI for the term you want to add, for example: http://identifiers.org/hgnc/23017. Note, this will add a new sublcassOf axiom:
4. Run the ROBOT merge command
5. You will see the new subclassOf axiom with the gene ID. Before the release, Mondoc curators will refresh the imports and this will bring in the label.
Copy link
Collaborator

@twhetzel twhetzel Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Typo Mondo**c** curators --> Mondo curators assuming it's a curator who will now run the refresh imports if the process is staying as-is for now, then it's someone on the Tech team that runs the refresh imports
  • Was there a decision to not just add a new class for the entity to import at the root and then reference that entity in the subclassOf axiom and then let the "refresh imports" process update this so the label is displayed?
  • I think the imported terms still need to be listed in this gSheet since there is a step in the "refresh imports" process that uses that file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twhetzel

Typo Mondoc curators --> Mondo curators assuming it's a curator who will now run the refresh imports if the process is staying as-is for now, then it's someone on the Tech team that runs the refresh imports

You are correct, it will be a tech team member who will run the refresh import (or it will be done automatically).

Was there a decision to not just add a new class for the entity to import at the root and then reference that entity in the subclassOf axiom and then let the "refresh imports" process update this so the label is displayed?

There wasn't any documentation for this workflow, and none of us was 100% sure how to proceed. But yes, it is an option.
@twhetzel could you please update this PR with this workflow (as another way to add a new class)? Thank you.

I think the imported terms still need to be listed in this gSheet since there is a step in the "refresh imports" process that uses that file

Should it? I thought we established it didn't have to. We can check this during the next refresh import and update this doc as needed

@sabrinatoro sabrinatoro assigned twhetzel and unassigned sabrinatoro Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants