HGNC ROBOT template - build #564
Conversation
joeflack4
added
build
joeflack4
force-pushed
the
hgnc-template-build
branch
from
a7daae4
to
6085fe4
Compare
There was a problem hiding this comment.
Build done
I don't know if there's much if anything to review there, because I've committed the outputs in external/ in this #559 already. Just face check nothing broke I guess.
There was a problem hiding this comment.
Nico:
I am assuming the run did correctly generate
src/ontology/external/mondo_genes.robot.owlwhich just does not show up because the branch is on top of the feature branch!
Yep. If it didn't generate it, there'd be a diff showing that the file was lost.
Trish:
Curious though, why do the "mondo-genes..." files not show up here? nvm
I looked at all the files in this branch and see them now and I think I understand Nico's comment that they don't show up here since they didn't change between feature branch and feature branch build.
Yeah, sorry, sometimes we don't commit outputs. But in this case, since they were new outputs, it seemed like I should commit them with that PR. For that reason, along w/ the fact that this comes at the end of the build and nothing is dependent on this new code for the most part, IDK if it made sense to run this build, but I did so just in case.
There was a problem hiding this comment.
Trish:
But how did other files change?
@twhetzel I'm pretty sure this is because the inputs to this pipeline are many (our sources, and the mondo repo itself), and change often. In the event that even 1 of these change, it can result in many files changing. In this case, only 54 files changed, which is sorta in line with my expectations; since we just ran a build very recently, I wouldn't expect that many files to change, and 54 is a relatively low diff.
Trish:
I'm curious how the build is being run and branching strategy.
I've been doing it the same way every time, pretty much:
- Feature branch PRs: I branch them off of
develop - Build PRs for feature branches: I branch them off of the feature branch
Also:
- When
maingets updated: I merge it intodevelop- Then I rebase all of my active feature branches from
develop: I wasn't doing this all of the time before, but now I'm trying to remember to always do that too.
- Then I rebase all of my active feature branches from
|
If the result files are in ##559 then overall I think this Build is ok, but I do have questions on the ROBOT file created in that PR #559 (comment). Those questions do not effect this feature branch Build review PR though. Curious though, why do the "mondo-genes..." files not show up here? nvm I looked at all the files in this branch and see them now and I think I understand Nico's comment that they don't show up here since they didn't change between feature branch and feature branch build. But how did other files change? I'm curious how the build is being run and branching strategy. |
|
Closing this PR, as it has built successfully and been approved. It does say that Trish requested changes, but that is pertaining to:
I looked into that, and it looks like the questions were all addressed, so I'm closing this now. |
QC / build PR for: