-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate lbann moses #63
Open
wderekjones
wants to merge
23
commits into
molecularsets:master
Choose a base branch
from
samadejacobs:integrate_lbann_moses
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Integrate lbann moses #63
wderekjones
wants to merge
23
commits into
molecularsets:master
from
samadejacobs:integrate_lbann_moses
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the latent space
…for the latent space
…es minor changes to run.py and sample.py that allow for the specification of arbitrary datasets and vocabs, also minor changes to allow for code to be TF 2.0 compatible.
…ng script (scripts/extract_enamine_vocab.sl), evalutation script (scripts/run.py), vocab extraction (scripts/char_vocab_utils.py and scripts/compute_charrnn_vocab.py being renamed to scripts/compute_vocab_main.py)
Integrate lbann moses
…ss arguments to worry about
…rmatting was done, some functions such as the moses/char_rnn/model.py were tweaked to allow for more general functionality
… the moses sample.py script that was due to simple formatting difference
…merging back into my fork then submitting PR to master on sams fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code to be compatible with TF 2.0, provides some utilities to process and featurize new datasets/vocabularies.