Integrate lbann moses #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es minor changes to run.py and sample.py that allow for the specification of arbitrary datasets and vocabs, also minor changes to allow for code to be TF 2.0 compatible.
samadejacobs
requested changes
Mar 24, 2020
|
|
||
| source activate lbann | ||
| cd /g/g13/jones289/workspace/lbann/applications/ATOM/moses/scripts | ||
|
|
There was a problem hiding this comment.
Hardcoded to your home directory, please fix
scripts/extract_enamine_vocab.sl
Outdated
| source activate lbann | ||
| cd /g/g13/jones289/workspace/lbann/applications/ATOM/moses/scripts | ||
|
|
||
| python compute_charrnn_vocab.py --smiles-path ~/data/enamine/2018q1-2_Enamine_REAL_680M_SMILES_part${SLURM_ARRAY_TASK_ID}.smiles --smiles-col smiles --smiles-sep='\t' --n-jobs 72 --output-dir /g/g13/jones289/workspace/lbann/applications/ATOM/data/enamine/part${SLURM_ARRAY_TASK_ID} |
There was a problem hiding this comment.
Is this script suppose to be in LBANN directory, or with moses? Also, data paths are hardcoded to your home directory
|
|
||
| source activate lbann | ||
| cd /g/g13/jones289/workspace/lbann/applications/ATOM/moses/scripts | ||
|
|
…ng script (scripts/extract_enamine_vocab.sl), evalutation script (scripts/run.py), vocab extraction (scripts/char_vocab_utils.py and scripts/compute_charrnn_vocab.py being renamed to scripts/compute_vocab_main.py)
samadejacobs
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code to be compatible with TF 2.0, provides some utilities to process and featurize new datasets/vocabularies.