Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add accounts endpoints #43

Merged
merged 6 commits into from
Mar 3, 2021
Merged

feat: Add accounts endpoints #43

merged 6 commits into from
Mar 3, 2021

Conversation

sridharvoruganti
Copy link
Contributor

Related to #1999

  • implement GET /accounts/{id}
  • implement PUT /accounts/{id}
  • implement PUT /accounts/{id}/error endpoints

@sridharvoruganti sridharvoruganti marked this pull request as ready for review March 2, 2021 13:59
package.json Outdated Show resolved Hide resolved
src/domain/accounts.ts Outdated Show resolved Hide resolved
kleyow
kleyow previously approved these changes Mar 2, 2021
Copy link
Collaborator

@kleyow kleyow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm...lgtm

headers: HapiUtil.Dictionary<string>,
userId: string,
error: APIErrorObject,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of any use unknown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change span type to unknown, lint complains at span?.getChild, then also need to typecast it to any

src/domain/accounts.ts Outdated Show resolved Hide resolved
@sridharvoruganti sridharvoruganti merged commit b3343ef into mojaloop:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants