Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linking] Display Account Not Found error to user #1999

Closed
35 tasks done
lewisdaly opened this issue Jan 28, 2021 · 0 comments
Closed
35 tasks done

[linking] Display Account Not Found error to user #1999

lewisdaly opened this issue Jan 28, 2021 · 0 comments
Assignees
Labels
oss-pisp OSS PISP team's items - stories, bugs, epics story
Milestone

Comments

@lewisdaly
Copy link
Contributor

lewisdaly commented Jan 28, 2021

Goal:

As a PISP App's User

I want to see an error message when I enter in a username that the DFSP doesn't know about

so that I can try to find my account again with another username.

Acceptance Criteria:

  • updated sequence diagram for account discovery failure scenario
  • updated error codes document with necessary error code for this scenario
  • end to end test: PISP receives a PUT /accounts/{id}/error callback from the DFSP

Complexity: High - lots of moving pieces here

Uncertainty: Medium

https://github.com/mojaloop/pisp/blob/master/docs/linking/README.md#12-discovery


Tasks:

  • thirdparty-api-adapter
    • implement the GET /accounts/{ID} handler
    • implement the PUT /accounts/{ID} handler
    • implement the PUT /accounts/{ID}/error handler
  • thirdparty-scheme-adapter
    • inbound
      • implement the GET /accounts/{ID} handler
      • implement the PUT /accounts/{ID} handler
      • implement the PUT /accounts/{ID}/error handler
    • outbound
      • implement the GET /accounts/{fspId}/{userId} handler
      • implement the accounts model and state-machine
  • mojaloop-simulator : implement GET /accounts/{ID} handler and configure rules
  • TTK : define and configure accounts endpoints to support integration tests
  • mojalooop/pisp:
    • add new sequence diagram for when a DFSP fails to find a user's information for the user's identifier
    • implement an end to end tests in docker-local that demonstrates this functionality

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oss-pisp OSS PISP team's items - stories, bugs, epics story
Projects
None yet
Development

No branches or pull requests

2 participants