Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALS subid error callback endpoint not implemented (PUT /parties/{TYPE}/{ID}/{SubId}/error) #2505

Closed
11 tasks done
elnyry-sam-k opened this issue Sep 21, 2021 · 3 comments
Closed
11 tasks done

ALS subid error callback endpoint not implemented (PUT /parties/{TYPE}/{ID}/{SubId}/error) #2505

elnyry-sam-k opened this issue Sep 21, 2021 · 3 comments
Assignees
@mdebarros
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Milestone
Sprint 15.5

Comments

@elnyry-sam-k
Copy link
Member

elnyry-sam-k commented Sep 21, 2021 •
edited
Loading

Goal:

As a scheme using sub identifiers as part of lookup (Account lookup service (ALS) )

I want to support error callbacks on subid endpoints

so that support ALS for subids (and error callbacks on those)

Acceptance Criteria:

  • ALS supports SubId error callbacks for PUT parties/{Type}/{ID}/{SubId}/error

Complexity: Low

Uncertainty: Low

Tasks:

  • Implementation to support errors on SubId endpoints in ALS
  • TTK GP tests updated

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC

Notes:
Review: https://github.com/mojaloop/account-lookup-service/blob/master/src/handlers/parties/%7BType%7D/%7BID%7D/%7BSubId%7D/error.js
@elnyry-sam-k elnyry-sam-k added oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it bug Something isn't working or it has wrong behavior on a Mojaloop Core service labels Sep 21, 2021
@elnyry-sam-k elnyry-sam-k changed the title subid error callback endpoint not implemented on ALS for /parties ALS subid error callback endpoint not implemented (PUT /parties/{TYPE}/{ID}/{SubId}/error Sep 21, 2021
@elnyry-sam-k elnyry-sam-k changed the title ALS subid error callback endpoint not implemented (PUT /parties/{TYPE}/{ID}/{SubId}/error ALS subid error callback endpoint not implemented (PUT /parties/{TYPE}/{ID}/{SubId}/error) Sep 21, 2021
@elnyry-sam-k elnyry-sam-k added story and removed bug Something isn't working or it has wrong behavior on a Mojaloop Core service labels Sep 21, 2021
@elnyry-sam-k elnyry-sam-k added this to the Sprint 15.5 milestone Sep 27, 2021
@mdebarros mdebarros self-assigned this Sep 28, 2021
mdebarros added a commit to mdebarros/account-lookup-service that referenced this issue Sep 28, 2021
@mdebarros
feat(mojaloop/#2505): als-subid-error-callback-endpoint-not-implemented
66ed3b0 
- linked PartiesSubIdErrorByTypeAndID to domain handler - mojaloop/project#2505
- this also fixes the `Error: Cannot wrap an error` that was observed when calling the PartiesSubIdErrorByTypeAndID API Handler
- fixed unit tests, and added one to test the PartiesSubIdErrorByTypeAndID API Handler
- updated dependencies
- fixed audit-resolve issues

```
--------------------------------------------------
 yargs-parser needs your attention.

[ low ] Prototype Pollution
 vulnerable versions <13.1.2 || >=14.0.0 <15.0.1 || >=16.0.0 <18.1.2 found in:
 - dependencies: @mojaloop/central-services-shared>widdershins>yargs>yargs-parser
 ```
> Outcome: Ignored for 1 week
> Impact: Minimal as the dependencies are used for the Developer Documentation end-point

```
--------------------------------------------------
 sanitize-html needs your attention.

[ moderate ] Improper Input Validation
 vulnerable versions <2.3.1 found in:
 - dependencies: @mojaloop/central-services-shared>shins>sanitize-html
[ moderate ] Improper Input Validation
 vulnerable versions <2.3.2 found in:
 - dependencies: @mojaloop/central-services-shared>shins>sanitize-html
```
> Outcome: Ignored for 1 week
> Impact: Minimal as the dependencies are used for the Developer Documentation end-point
mdebarros added a commit to mdebarros/testing-toolkit-test-cases that referenced this issue Sep 28, 2021
@mdebarros
feat(mojaloop/#2505): als-subid-error-callback-endpoint-not-implemented
d74feb7 
- added test case for "p2p_money_transfer - p2p_unhappy_path with invalid subID at PayeeFSP" for mojaloop/project#2505
This was referenced Sep 28, 2021
Merged
Merged
mdebarros added a commit to mojaloop/account-lookup-service that referenced this issue Sep 28, 2021
@mdebarros
feat(mojaloop/#2505): als-subid-error-callback-endpoint-not-implement…
6051259 
…ed (#429)

:feat(mojaloop/#2505): als-subid-error-callback-endpoint-not-implemented
- linked PartiesSubIdErrorByTypeAndID to domain handler - mojaloop/project#2505
- this also fixes the `Error: Cannot wrap an error` that was observed when calling the PartiesSubIdErrorByTypeAndID API Handler
- fixed unit tests, and added one to test the PartiesSubIdErrorByTypeAndID API Handler
- updated dependencies
- fixed audit-resolve issues

```
--------------------------------------------------
 yargs-parser needs your attention.

[ low ] Prototype Pollution
 vulnerable versions <13.1.2 || >=14.0.0 <15.0.1 || >=16.0.0 <18.1.2 found in:
 - dependencies: @mojaloop/central-services-shared>widdershins>yargs>yargs-parser
 ```
> Outcome: Ignored for 1 week
> Impact: Minimal as the dependencies are used for the Developer Documentation end-point

```
--------------------------------------------------
 sanitize-html needs your attention.

[ moderate ] Improper Input Validation
 vulnerable versions <2.3.1 found in:
 - dependencies: @mojaloop/central-services-shared>shins>sanitize-html
[ moderate ] Improper Input Validation
 vulnerable versions <2.3.2 found in:
 - dependencies: @mojaloop/central-services-shared>shins>sanitize-html
```
> Outcome: Ignored for 1 week
> Impact: Minimal as the dependencies are used for the Developer Documentation end-point
mdebarros added a commit to mojaloop/testing-toolkit-test-cases that referenced this issue Sep 28, 2021
@mdebarros
feat(mojaloop/#2505): als-subid-error-callback-endpoint-not-implement…
fda587e 
…ed (#52)

feat(mojaloop/#2505): als-subid-error-callback-endpoint-not-implemented
- added test case for "p2p_money_transfer - p2p_unhappy_path with invalid subID at PayeeFSP" for mojaloop/project#2505
@mdebarros
Copy link
Member

mdebarros commented Sep 28, 2021 •
edited
Loading

Full GP test report: TTK-Assertion-Report-multi-2021-09-28T15_16_57.947Z.html.zip

Total GP results for PR merged in master: mojaloop/testing-toolkit-test-cases#52

Screenshot 2021-09-28 at 17 29 43

New test-case results added from the above PR: p2p_money_transfer - p2p_unhappy_path with invalid subID at PayeeFSP
Screenshot 2021-09-28 at 17 29 32

@mdebarros
Copy link
Member

@elnyry-sam-k I think we can close this issues, see previous post.

@elnyry-sam-k
Copy link
Member Author

Great, thanks Miguel @mdebarros

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Projects
None yet
Milestone
Sprint 15.5
Development

No branches or pull requests
2 participants
@elnyry-sam-k @mdebarros