feat(mojaloop/#2505): als-subid-error-callback-endpoint-not-implemented #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- linked PartiesSubIdErrorByTypeAndID to domain handler - mojaloop/project#2505 - this also fixes the `Error: Cannot wrap an error` that was observed when calling the PartiesSubIdErrorByTypeAndID API Handler - fixed unit tests, and added one to test the PartiesSubIdErrorByTypeAndID API Handler - updated dependencies - fixed audit-resolve issues ``` -------------------------------------------------- yargs-parser needs your attention. [ low ] Prototype Pollution vulnerable versions <13.1.2 || >=14.0.0 <15.0.1 || >=16.0.0 <18.1.2 found in: - dependencies: @mojaloop/central-services-shared>widdershins>yargs>yargs-parser ``` > Outcome: Ignored for 1 week > Impact: Minimal as the dependencies are used for the Developer Documentation end-point ``` -------------------------------------------------- sanitize-html needs your attention. [ moderate ] Improper Input Validation vulnerable versions <2.3.1 found in: - dependencies: @mojaloop/central-services-shared>shins>sanitize-html [ moderate ] Improper Input Validation vulnerable versions <2.3.2 found in: - dependencies: @mojaloop/central-services-shared>shins>sanitize-html ``` > Outcome: Ignored for 1 week > Impact: Minimal as the dependencies are used for the Developer Documentation end-point
mdebarros
requested review from
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165 and
vgenev
as code owners
11 tasks
elnyry-sam-k
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: Cannot wrap an errorthat was observed when calling the PartiesSubIdErrorByTypeAndID API Handler