ExtensionList missing when unsupported version requested for services

[amarmodus]

Summary:

When wrong content header is supplied in the request header, following error information is sent and extension list is missing.

{
    "errorInformation": {
        "errorCode": "3001",
        "errorDescription": "Unacceptable version requested - Client supplied a protocol version which is not supported by the server"
    }
}

Tasks:

• Implement code changes in central-services-shared project, and increment version
• Create release for central-services-shared
• Update dependencies for central-event-processor, and create release (needs python fixes for CircleCi)
• Update dependencies for account-lookup-service, and create release
• Update dependencies for central-ledger, and create release
• Update dependencies for ml-api-adapter, and create release
• Update dependencies for quoting-service, and create release
• Update dependencies for simulator, and create release
• Update dependencies for transaction-requests-service, and create release (done already by Rajiv)
• Update dependencies for central-settlement, and create release (needs python fixes for CircleCi)
• Update dependencies for bulk-api-adapter, and create release (needs python fixes for CircleCi)

PRs:

• central-services-shared changes: Changes for bug https://github.com/mojaloop/project/issues/1378 central-services-shared#231
• central-event-processor changes: Updates for issue: https://github.com/mojaloop/project/issues/1378 central-event-processor#204
• central-event-processor (CircleCi/Python changes): Fixed CircleCI/Python central-event-processor#205
• account-lookup-service changes: Updated dependencies for issue: https://github.com/mojaloop/project/issues/1378 account-lookup-service#359
• central-ledger changes: Updated dependencies and product version for issue: https://github.com/mojaloop/project/issues/1378 central-ledger#747
• ml-api-adapter changes: Changes for issue: https://github.com/mojaloop/project/issues/1378 ml-api-adapter#443
• quoting-service changes: Updated dependencies and version for issue: https://github.com/mojaloop/project/issues/1378 quoting-service#223
• simulator changes: Updated dependencies for issue: https://github.com/mojaloop/project/issues/1378 simulator#196
• transaction-requests-service changes: NOT NEEDED
• central-settlement changes: Updated dependencies for issue: https://github.com/mojaloop/project/issues/1378 central-settlement#308
• central-settlement (CircleCi/Python changes): Fix CircleCi/Python central-settlement#309
• bulk-api-adapter changes: Updated dependencies for issue: https://github.com/mojaloop/project/issues/1378 bulk-api-adapter#30
• bulk-api-adapter (CircleCi/Python changes): Changes to CircleCi/Python bulk-api-adapter#31

Severity:
Medium

Priority:
Low

Expected Behavior

{ 
     "errorInformation": { 
               "errorCode": "3001", 
                "errorDescription": "The Client requested an unsupported version, see extension list for supported version(s).", 
                  "extensionList": [ 
                           { "key": "1", "value": "0" }, 
                           { "key": "2", "value": "1" }, 
                           { "key": "4", "value": "2" } 
                    ]
         } 
} 

Steps to Reproduce

curl --location --request GET 'http://dev2-transaction-requests-service.mojaloop.live/authorizations/43638814-1a02-44eb-9e93-b6dd295799d7?authenticationType=OTP&retriesLeft=2&amount=102&currency=USD' \
--header 'Accept: application/vnd.interoperability.authorizations+json;version=1' \
--header 'Content-Type: application/vnd.interoperability.authorizations+json;version=4.0' \
--header 'Date: Mon, 18 May 2020 15:01:49 GMT' \
--header 'fspiop-source: payerfsp' \
--header 'fspiop-destination: payeefsp' \
--header 'fspiop-signature: {"signature":"iU4GBXSfY8twZMj1zXX1CTe3LDO8Zvgui53icrriBxCUF_wltQmnjgWLWI4ZUEueVeOeTbDPBZazpBWYvBYpl5WJSUoXi14nVlangcsmu2vYkQUPmHtjOW-yb2ng6_aPfwd7oHLWrWzcsjTF-S4dW7GZRPHEbY_qCOhEwmmMOnE1FWF1OLvP0dM0r4y7FlnrZNhmuVIFhk_pMbEC44rtQmMFv4pm4EVGqmIm3eyXz0GkX8q_O1kGBoyIeV_P6RRcZ0nL6YUVMhPFSLJo6CIhL2zPm54Qdl2nVzDFWn_shVyV0Cl5vpcMJxJ--O_Zcbmpv6lxqDdygTC782Ob3CNMvg\",\"protectedHeader\":\"eyJhbGciOiJSUzI1NiIsIkZTUElPUC1VUkkiOiIvdHJhbnNmZXJzIiwiRlNQSU9QLUhUVFAtTWV0aG9kIjoiUE9TVCIsIkZTUElPUC1Tb3VyY2UiOiJPTUwiLCJGU1BJT1AtRGVzdGluYXRpb24iOiJNVE5Nb2JpbGVNb25leSIsIkRhdGUiOiIifQ"}' \
--header 'fspiop-uri: /transactionRequests' \
--header 'fspiop-http-method: GET'

Specifications

• Component (if known): Error framework
• Version:v10.1.0
• Platform:
• Subsystem:
• Type of testing: Manual postman test
• Bug found/raised by: @amarmodus

Notes:

• Severity when opened:
• Priority when opened:

[aenns]

@amarmodus @elnyry-sam-k
Where do the values for the extension list come from?

[elnyry-sam-k]

@aenns - these have to set in a central place somewhere, sort of like sdk-standard-components. The valid values right now are "1.0" (key-1, value-0) and "1.1"(key-1, value-1); These represent the versions of the FSPIOP Spec that are supported by an implementation.. (Currently we have v1.1 and v1.0 supported, though v1.1 is still in progress, one issue is left)

[aenns]

@elnyry-sam-k
I am able to replicate the error. This is the code that throws the exception:

if (!supportedProtocolVersions.includes(contentType.version)) {
throw createFSPIOPError(
Enums.FSPIOPErrorCodes.UNACCEPTABLE_VERSION,
errorMessages.SUPPLIED_VERSION_NOT_SUPPORTED
)
}

The supported versions are hard-coded in a variable (in the central-services-shared project) and currently only support "1" and "1.0". So, if we tried a request with a different version (such as "1.1"), it will throw this error (unless I'm looking in the wrong place, but I tested this as well with "1.1" and it caused the error to occur). My question here is whether I add "1.1" to the supported versions, or I leave it as is, and DO NOT include "1.1" in the extension list?

[elnyry-sam-k]

@aenns - since we're now making changes for v1.1 I think we can go ahead and make that change.. With our next helm release we'll have the changes for v1.1; Also are you seeing the error message something like this, right now?

{ 
     "errorInformation": { 
               "errorCode": "3001", 
                "errorDescription": "The Client requested an unsupported version, see extension list for supported version(s).", 
                  "extensionList": [ 
                           { "key": "1", "value": "0" }
                    ]
         } 
}