ExtensionList missing when unsupported accept version requested for services

[amarmodus]

Summary:

When wrong accept header is supplied in the request header, following error information is sent and extension list is missing.

{
    "errorInformation": {
        "errorCode": "3001",
        "errorDescription": "Unacceptable version requested - Client requested to use a protocol version which is not supported by the server"
    }
}

Expected Behavior

{ 
     "errorInformation": { 
               "errorCode": "3001", 
                "errorDescription": "The Client requested an unsupported version, see extension list for supported version(s).", 
                  "extensionList": [ 
                           { "key": "1", "value": "0" }, 
                           { "key": "2", "value": "1" }, 
                           { "key": "4", "value": "2" } 
                    ]
         } 
} 

Steps to Reproduce

curl --location --request POST 'http://dev2-quoting-service.mojaloop.live/quotes' \
--header 'Accept: application/vnd.interoperability.quotes+json;version=3' \
--header 'Content-Type: application/vnd.interoperability.quotes+json;version=1.0' \
--header 'Date: Mon, 29 Jun 2020 10:32:27 GMT' \
--header 'FSPIOP-Source: payerfsp' \
--header 'FSPIOP-Destination: payeefsp' \
--header 'FSPIOP-Signature: {"signature":"iU4GBXSfY8twZMj1zXX1CTe3LDO8Zvgui53icrriBxCUF_wltQmnjgWLWI4ZUEueVeOeTbDPBZazpBWYvBYpl5WJSUoXi14nVlangcsmu2vYkQUPmHtjOW-yb2ng6_aPfwd7oHLWrWzcsjTF-S4dW7GZRPHEbY_qCOhEwmmMOnE1FWF1OLvP0dM0r4y7FlnrZNhmuVIFhk_pMbEC44rtQmMFv4pm4EVGqmIm3eyXz0GkX8q_O1kGBoyIeV_P6RRcZ0nL6YUVMhPFSLJo6CIhL2zPm54Qdl2nVzDFWn_shVyV0Cl5vpcMJxJ--O_Zcbmpv6lxqDdygTC782Ob3CNMvg\",\"protectedHeader\":\"eyJhbGciOiJSUzI1NiIsIkZTUElPUC1VUkkiOiIvdHJhbnNmZXJzIiwiRlNQSU9QLUhUVFAtTWV0aG9kIjoiUE9TVCIsIkZTUElPUC1Tb3VyY2UiOiJPTUwiLCJGU1BJT1AtRGVzdGluYXRpb24iOiJNVE5Nb2JpbGVNb25leSIsIkRhdGUiOiIifQ"}' \
--header 'Authorization: Bearer {{TESTFSP1_BEARER_TOKEN}}' \
--data-raw '{
"quoteId": "b5031edb-eca0-4120-989b-606a174b0ab5",
"transactionId": "845b458f-0c6d-4244-8d91-07327b232389",
"payer": {
  "partyIdInfo": {
    "partyIdType": "MSISDN",
    "partyIdentifier": "{{payerMSISDN}}",
    "fspId": "payerfsp"
  },
  "personalInfo": {
    "complexName": {
      "firstName": "Mats",
      "lastName": "Hagman"
    },
    "dateOfBirth": "1983-10-25"
  }
},
"payee": {
  "partyIdInfo": {
    "partyIdType": "MSISDN",
    "partyIdentifier": "22556999125",
    "fspId": "payeefsp"
  }
},
"amountType": "SEND",
"amount": {
  "amount": "60.11",
  "currency": "USD"
},
"transactionType": {
  "scenario": "TRANSFER",
  "initiator": "PAYER",
  "initiatorType": "CONSUMER"
},
"note": "hej"
}'

Severity:
Medium

Priority:
Low

Specifications

• Component (if known): Error framework
• Version:v10.1.0
• Platform:
• Subsystem:
• Type of testing: Manual postman test
• Bug found/raised by: @amarmodus

Notes:

• Severity when opened:
• Priority when opened:

#1378 - this is opened for similar issue but for content header version.

Tasks:

• Fix bug in Central Services Shared library
• Update CS-Shared in ML-API Adapter
• Update CS-Shared in Central Settlement
• Update CS-Shared in Central Ledger
• Update CS-Shared in Central Event Processor
• Update CS-Shared in ALS
• Update CS-Shared in Simulator
• Update CS-Shared in Bulk API Adapter
• Update CS-Shared in Quoting Services
• E2E validation across all services updated

PRs:

• #1456: Added extensions list object for unsupported version error central-services-shared#235
• Upgraded central-services-shared library to 10.5.3, bump version ml-api-adapter#447
• Upgraded central-services-shared library to 10.5.3, bump version central-settlement#313
• Upgraded central-services-shared library to 10.5.3, bump version central-ledger#752 [Superseded by subsequent PRs]
• #1456 - Upgraded central-services-shared library to 10.5.3, bump version central-event-processor#206 [Superseded by subsequent PRs]
• Upgraded central-services-shared library to 10.5.3, bump version simulator#201 [Superseded by subsequent PRs]
• #1456 - Upgraded central-services-shared library to 10.5.3, bump version bulk-api-adapter#35 [Superseded by subsequent PRs]
• #1456 - Upgraded central-services-shared library to 10.5.3, bump version account-lookup-service#360 [Superseded by subsequent PRs]
• Upgraded central-services-shared library to 10.5.3, bump version quoting-service#229 [Closed to be completed in 2.4.01.01 Design Fulfill [5] #247]
• #1456: Feature/docker config fixes quoting-service#247

[claudio-viola]

central-services-share: mojaloop/central-services-shared#235
central-event-processor: https://github.com/mojaloop/central-event-processor/pull/206/files
account-lookup-service: mojaloop/account-lookup-service#360
central-ledger: mojaloop/central-ledger#752
ml-api-adapter: mojaloop/ml-api-adapter#447
quoting-service: mojaloop/quoting-service#229
simulator: mojaloop/simulator#201
central-settlement: mojaloop/central-settlement#313
bulk-api-adapter: mojaloop/bulk-api-adapter#35

[elnyry-sam-k]

@claudio-viola - are you done with this? Thanks for the effort..

[oderayi]

Closing to continue implementation and validation of FSPIOP headers in some of the services that could not be validated in this story. #1854