Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync to ab96ea19ca0ea6fc158acdf16a694f6eef181cf7 #802

Merged
merged 55 commits into from
Dec 22, 2020

Conversation

kleyow
Copy link
Contributor

@kleyow kleyow commented Dec 20, 2020

No description provided.

shashi165 and others added 30 commits June 5, 2020 11:59
Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>
* Added ENABLE_ON_US_TRANSFERS

* Bumped up the version
…p#735)

* OTC-525 Implement GET transaction Object by transferId
Changes:

Updated swagger def to include new endpoints for:
- Get transaction by transfer id
- Post ledger entry

Added new method for:
- Get transaction by transfer id

Added unit tests for Get transaction by transfer id

* OTC-525 Implement GET transaction Object by transferId
Bumput up versions

* OTC-525 Implement GET transaction Object by transferId
Resolved dependency updates

* OTC-525 Implement GET transaction Object by transferId

* OTC-525 Implement GET transaction Object by transferId

Changes:

Updated swagger def to include new endpoints for:
- Get transaction by transfer id

Added new method for:
- Get transaction by transfer id

Added unit tests for Get transaction by transfer id
* Fix the image scan step in circle CI

* Resolved audit checks
* added error log if action REJECT comes into fulfil handler

Co-authored-by: Valentin <valentin.genev@modusbox.com>
* added unique index on participantLimit and logging

* added unique index on participantLimit and logging

* resolve audit issues

* fixed coverage tests

Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>
* Update error message when Payer FSP and Payee FSP are the same and on-us is not enabled.. (Added text "FSP" to specify)

* Updated unit test
* Updates for bulk error processing

* Bump version

* Updates for bulk transfer error processing

* Updates for bulk transfer error processing

* More updates for bulk error processing

* changes to cater for bulk_abort

* updated central-services-shared

* Updates for bulk error processing

* Add unit test for BULK_ABORT branch in transfer fulfil handler

* Add unit test for BULK_ABORT branch in transfer facade

* Small fix for position handler test for BULK_ABORT branch

Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>
* added handling of request for notification by payee functionality
* improved coverage and added missing action letter

Co-authored-by: Valentin <valentin.genev@modusbox.com>
* version change

* Added  FSPIOP_CALLBACK_URL_BULK_QUOTES endpoint to seeds and updated population scripts and created one for local legacy simulator
updated dependencies

* updated dependencies to resolve audit issues
* Add bulk get topic and handler

* Implement GET bulk transfer logic

* Restore default config

* Add unit tests

* Bump version

* More bug fixes

* Fix unit test

* ensure error code is returned as string and not number for bulk get
…allback (mojaloop#770)

* Ignore RESERVE transferState from v1.0 clients on fulfil callback

* Update package.json

Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>

Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
…ype (mojaloop#773)

* Update dependencies

* Bump version

* Fix integration tests
* updated shared lib version to support configurable api resource versions and updated timeout handler to use same resource versions

* updated dependencies

Co-authored-by: Valentin <valentin.genev@modusbox.com>
oderayi and others added 2 commits December 11, 2020 14:45
* Update new API documentation endpoints

* Resolve audit

* Resolve license audit issues

* Update plugins test

* Add tests for Config

* Force update event-stream to 4.0.1 to fix license audit

* Refactor API_DOCUMENTATION_ENDPOINTS TO API_DOC_ENDPOINTS_ENABLED
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. **This update includes a security fix.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Dec 20, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
9 out of 13 committers have signed the CLA.

✅ vgenev
✅ vijayg10
✅ oderayi
✅ shashi165
✅ mdebarros
✅ elnyry-sam-k
✅ eoln
✅ kleyow
✅ lewisdaly
❌ lazolalucas
❌ abehnamfard
❌ rmothilal
❌ aenns
You have signed the CLA already but the status is still pending? Let us recheck it.

@kleyow kleyow force-pushed the chore/sync-latest-11.3.3 branch from e24f49c to 29149c4 Compare December 21, 2020 01:35
kleyow and others added 14 commits December 20, 2020 20:40
* Edited CI to build PISP docker image.

* Addressed comments.
* Add new endpoint: `THIRDPARTY_CALLBACK_URL_TRX_REQ_POST`

* cleanup

* skip devDependencies in audit:check
* fix for python error in CI (mojaloop#733)

Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>

* Ensure 'timeout-reserved' notification action passes through and not converted to 'abort' action (mojaloop#736)

* Update CS shared (mojaloop#737)

* Feature/1332 enable on-us transfers (mojaloop#738)

* Added ENABLE_ON_US_TRANSFERS

* Bumped up the version

* Feature/otc 525 implement get transaction object by transfer (mojaloop#735)

* OTC-525 Implement GET transaction Object by transferId
Changes:

Updated swagger def to include new endpoints for:
- Get transaction by transfer id
- Post ledger entry

Added new method for:
- Get transaction by transfer id

Added unit tests for Get transaction by transfer id

* OTC-525 Implement GET transaction Object by transferId
Bumput up versions

* OTC-525 Implement GET transaction Object by transferId
Resolved dependency updates

* OTC-525 Implement GET transaction Object by transferId

* OTC-525 Implement GET transaction Object by transferId

Changes:

Updated swagger def to include new endpoints for:
- Get transaction by transfer id

Added new method for:
- Get transaction by transfer id

Added unit tests for Get transaction by transfer id

* changed docker dependency in circle CI image scan from python-dev to python3-dev (mojaloop#741)

* Updated python in some other places in circle CI (mojaloop#742)

* Fix the image scan step in circle CI

* Resolved audit checks

* Feature/#1335 aborted on put (mojaloop#740)

* added error log if action REJECT comes into fulfil handler

Co-authored-by: Valentin <valentin.genev@modusbox.com>

* Bugfix/deadlock on adjust limits (mojaloop#745)

* added unique index on participantLimit and logging

* added unique index on participantLimit and logging

* resolve audit issues

* fixed coverage tests

Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>

* Updated dependencies and product version for issue: mojaloop/project#1378 (mojaloop#747)

* Update error message  (mojaloop#749)

* Update error message when Payer FSP and Payee FSP are the same and on-us is not enabled.. (Added text "FSP" to specify)

* Updated unit test

* #1423: Bulk transfers error processing in Central Ledger (mojaloop#743)

* Updates for bulk error processing

* Bump version

* Updates for bulk transfer error processing

* Updates for bulk transfer error processing

* More updates for bulk error processing

* changes to cater for bulk_abort

* updated central-services-shared

* Updates for bulk error processing

* Add unit test for BULK_ABORT branch in transfer fulfil handler

* Add unit test for BULK_ABORT branch in transfer facade

* Small fix for position handler test for BULK_ABORT branch

Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>

* Bump version for release (mojaloop#750)

* Feature/#1334 patch request notif (mojaloop#751)

* added handling of request for notification by payee functionality
* improved coverage and added missing action letter

Co-authored-by: Valentin <valentin.genev@modusbox.com>

* chore(package): update contributors list & deps

* chore: audit & deps update

Co-authored-by: shashi165 <33355509+shashi165@users.noreply.github.com>
Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>
Co-authored-by: Steven Oderayi <oderayi@gmail.com>
Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com>
Co-authored-by: lazolalucas <lazolalucas@users.noreply.github.com>
Co-authored-by: Valentin Genev <vgenev@gmail.com>
Co-authored-by: Valentin <valentin.genev@modusbox.com>
Co-authored-by: Adrian Enns <ennsak@gmail.com>
Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>
* chore: add thirdparty endpoints to database seeds

* chore: update dependencies for vulnerabilities

* refactor: change name length to accomodate new endpoints

* chore: sync package-lock

* chore: remove migrations and shorten endpoint names

* chore: fix find and replace error

* chore: fix spelling
* chore: add generate challenge endpoints

* chore: fix description
* Add new endpoint: `THIRDPARTY_CALLBACK_URL_TRX_REQ_POST`

* cleanup

* skip devDependencies in audit:check
* fix for python error in CI (mojaloop#733)

Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>

* Ensure 'timeout-reserved' notification action passes through and not converted to 'abort' action (mojaloop#736)

* Update CS shared (mojaloop#737)

* Feature/1332 enable on-us transfers (mojaloop#738)

* Added ENABLE_ON_US_TRANSFERS

* Bumped up the version

* Feature/otc 525 implement get transaction object by transfer (mojaloop#735)

* OTC-525 Implement GET transaction Object by transferId
Changes:

Updated swagger def to include new endpoints for:
- Get transaction by transfer id
- Post ledger entry

Added new method for:
- Get transaction by transfer id

Added unit tests for Get transaction by transfer id

* OTC-525 Implement GET transaction Object by transferId
Bumput up versions

* OTC-525 Implement GET transaction Object by transferId
Resolved dependency updates

* OTC-525 Implement GET transaction Object by transferId

* OTC-525 Implement GET transaction Object by transferId

Changes:

Updated swagger def to include new endpoints for:
- Get transaction by transfer id

Added new method for:
- Get transaction by transfer id

Added unit tests for Get transaction by transfer id

* changed docker dependency in circle CI image scan from python-dev to python3-dev (mojaloop#741)

* Updated python in some other places in circle CI (mojaloop#742)

* Fix the image scan step in circle CI

* Resolved audit checks

* Feature/#1335 aborted on put (mojaloop#740)

* added error log if action REJECT comes into fulfil handler

Co-authored-by: Valentin <valentin.genev@modusbox.com>

* Bugfix/deadlock on adjust limits (mojaloop#745)

* added unique index on participantLimit and logging

* added unique index on participantLimit and logging

* resolve audit issues

* fixed coverage tests

Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>

* Updated dependencies and product version for issue: mojaloop/project#1378 (mojaloop#747)

* Update error message  (mojaloop#749)

* Update error message when Payer FSP and Payee FSP are the same and on-us is not enabled.. (Added text "FSP" to specify)

* Updated unit test

* #1423: Bulk transfers error processing in Central Ledger (mojaloop#743)

* Updates for bulk error processing

* Bump version

* Updates for bulk transfer error processing

* Updates for bulk transfer error processing

* More updates for bulk error processing

* changes to cater for bulk_abort

* updated central-services-shared

* Updates for bulk error processing

* Add unit test for BULK_ABORT branch in transfer fulfil handler

* Add unit test for BULK_ABORT branch in transfer facade

* Small fix for position handler test for BULK_ABORT branch

Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>

* Bump version for release (mojaloop#750)

* Feature/#1334 patch request notif (mojaloop#751)

* added handling of request for notification by payee functionality
* improved coverage and added missing action letter

Co-authored-by: Valentin <valentin.genev@modusbox.com>

* chore(package): update contributors list & deps

* chore: audit & deps update

Co-authored-by: shashi165 <33355509+shashi165@users.noreply.github.com>
Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>
Co-authored-by: Steven Oderayi <oderayi@gmail.com>
Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com>
Co-authored-by: lazolalucas <lazolalucas@users.noreply.github.com>
Co-authored-by: Valentin Genev <vgenev@gmail.com>
Co-authored-by: Valentin <valentin.genev@modusbox.com>
Co-authored-by: Adrian Enns <ennsak@gmail.com>
Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>
* fix for python error in CI (mojaloop#733)

Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>

* Ensure 'timeout-reserved' notification action passes through and not converted to 'abort' action (mojaloop#736)

* Update CS shared (mojaloop#737)

* Feature/1332 enable on-us transfers (mojaloop#738)

* Added ENABLE_ON_US_TRANSFERS

* Bumped up the version

* Feature/otc 525 implement get transaction object by transfer (mojaloop#735)

* OTC-525 Implement GET transaction Object by transferId
Changes:

Updated swagger def to include new endpoints for:
- Get transaction by transfer id
- Post ledger entry

Added new method for:
- Get transaction by transfer id

Added unit tests for Get transaction by transfer id

* OTC-525 Implement GET transaction Object by transferId
Bumput up versions

* OTC-525 Implement GET transaction Object by transferId
Resolved dependency updates

* OTC-525 Implement GET transaction Object by transferId

* OTC-525 Implement GET transaction Object by transferId

Changes:

Updated swagger def to include new endpoints for:
- Get transaction by transfer id

Added new method for:
- Get transaction by transfer id

Added unit tests for Get transaction by transfer id

* changed docker dependency in circle CI image scan from python-dev to python3-dev (mojaloop#741)

* Updated python in some other places in circle CI (mojaloop#742)

* Fix the image scan step in circle CI

* Resolved audit checks

* Feature/#1335 aborted on put (mojaloop#740)

* added error log if action REJECT comes into fulfil handler

Co-authored-by: Valentin <valentin.genev@modusbox.com>

* Bugfix/deadlock on adjust limits (mojaloop#745)

* added unique index on participantLimit and logging

* added unique index on participantLimit and logging

* resolve audit issues

* fixed coverage tests

Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>

* Updated dependencies and product version for issue: mojaloop/project#1378 (mojaloop#747)

* Update error message  (mojaloop#749)

* Update error message when Payer FSP and Payee FSP are the same and on-us is not enabled.. (Added text "FSP" to specify)

* Updated unit test

* #1423: Bulk transfers error processing in Central Ledger (mojaloop#743)

* Updates for bulk error processing

* Bump version

* Updates for bulk transfer error processing

* Updates for bulk transfer error processing

* More updates for bulk error processing

* changes to cater for bulk_abort

* updated central-services-shared

* Updates for bulk error processing

* Add unit test for BULK_ABORT branch in transfer fulfil handler

* Add unit test for BULK_ABORT branch in transfer facade

* Small fix for position handler test for BULK_ABORT branch

Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>

* Bump version for release (mojaloop#750)

* Feature/#1334 patch request notif (mojaloop#751)

* added handling of request for notification by payee functionality
* improved coverage and added missing action letter

Co-authored-by: Valentin <valentin.genev@modusbox.com>

* Feature/1468 bulk quotes endpoints (mojaloop#761)

* version change

* Added  FSPIOP_CALLBACK_URL_BULK_QUOTES endpoint to seeds and updated population scripts and created one for local legacy simulator
updated dependencies

* updated dependencies to resolve audit issues

* Feature/#1375: GET bulk transfer implementation (mojaloop#760)

* Add bulk get topic and handler

* Implement GET bulk transfer logic

* Restore default config

* Add unit tests

* Bump version

* More bug fixes

* Fix unit test

* ensure error code is returned as string and not number for bulk get

* Add bulk get to handlers list for cli startup (mojaloop#765)

* Reset package-lock.json to fix bug with version update for AJV (mojaloop#766)

* SemVar fix (mojaloop#767)

* Fix error callback for bulk transfers REJECTED scenario (mojaloop#768)

* Correct FSPIOP API version for admin API (mojaloop#769)

* #1547: Ignore "RESERVED" transferState from v1.0 clients on fulfill callback (mojaloop#770)

* Ignore RESERVE transferState from v1.0 clients on fulfil callback

* Update package.json

Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>

Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>

* Bump version to v111.1.2 to fix broken release (mojaloop#771)

* #1547: Fail transfer fulfill with "RESERVED" state and v1.0 content-type (mojaloop#773)

* Update dependencies

* Bump version

* Fix integration tests

* #1547: Update dependencies (central-object-store etc.) (mojaloop#774)

* Update dependencies

* Bump version

* fix: package.json & package-lock.json to reduce vulnerabilities (mojaloop#775)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-LODASH-590103

* Fix bug in volumes of temp_curl service (mojaloop#778)

* Edited CI to build PISP docker image. (mojaloop#734)

* Edited CI to build PISP docker image.

* Addressed comments.

* Updated ci to python 3. (mojaloop#744)

* Update pisp/master (mojaloop#755)

* fix for python error in CI (mojaloop#733)

Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>

* Ensure 'timeout-reserved' notification action passes through and not converted to 'abort' action (mojaloop#736)

* Update CS shared (mojaloop#737)

* Feature/1332 enable on-us transfers (mojaloop#738)

* Added ENABLE_ON_US_TRANSFERS

* Bumped up the version

* Feature/otc 525 implement get transaction object by transfer (mojaloop#735)

* OTC-525 Implement GET transaction Object by transferId
Changes:

Updated swagger def to include new endpoints for:
- Get transaction by transfer id
- Post ledger entry

Added new method for:
- Get transaction by transfer id

Added unit tests for Get transaction by transfer id

* OTC-525 Implement GET transaction Object by transferId
Bumput up versions

* OTC-525 Implement GET transaction Object by transferId
Resolved dependency updates

* OTC-525 Implement GET transaction Object by transferId

* OTC-525 Implement GET transaction Object by transferId

Changes:

Updated swagger def to include new endpoints for:
- Get transaction by transfer id

Added new method for:
- Get transaction by transfer id

Added unit tests for Get transaction by transfer id

* changed docker dependency in circle CI image scan from python-dev to python3-dev (mojaloop#741)

* Updated python in some other places in circle CI (mojaloop#742)

* Fix the image scan step in circle CI

* Resolved audit checks

* Feature/#1335 aborted on put (mojaloop#740)

* added error log if action REJECT comes into fulfil handler

Co-authored-by: Valentin <valentin.genev@modusbox.com>

* Bugfix/deadlock on adjust limits (mojaloop#745)

* added unique index on participantLimit and logging

* added unique index on participantLimit and logging

* resolve audit issues

* fixed coverage tests

Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>

* Updated dependencies and product version for issue: mojaloop/project#1378 (mojaloop#747)

* Update error message  (mojaloop#749)

* Update error message when Payer FSP and Payee FSP are the same and on-us is not enabled.. (Added text "FSP" to specify)

* Updated unit test

* #1423: Bulk transfers error processing in Central Ledger (mojaloop#743)

* Updates for bulk error processing

* Bump version

* Updates for bulk transfer error processing

* Updates for bulk transfer error processing

* More updates for bulk error processing

* changes to cater for bulk_abort

* updated central-services-shared

* Updates for bulk error processing

* Add unit test for BULK_ABORT branch in transfer fulfil handler

* Add unit test for BULK_ABORT branch in transfer facade

* Small fix for position handler test for BULK_ABORT branch

Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>

* Bump version for release (mojaloop#750)

* Feature/#1334 patch request notif (mojaloop#751)

* added handling of request for notification by payee functionality
* improved coverage and added missing action letter

Co-authored-by: Valentin <valentin.genev@modusbox.com>

* chore(package): update contributors list & deps

* chore: audit & deps update

Co-authored-by: shashi165 <33355509+shashi165@users.noreply.github.com>
Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>
Co-authored-by: Steven Oderayi <oderayi@gmail.com>
Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com>
Co-authored-by: lazolalucas <lazolalucas@users.noreply.github.com>
Co-authored-by: Valentin Genev <vgenev@gmail.com>
Co-authored-by: Valentin <valentin.genev@modusbox.com>
Co-authored-by: Adrian Enns <ennsak@gmail.com>
Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>

* chore: add thirdparty endpoints to database seeds (mojaloop#779)

* chore: add thirdparty endpoints to database seeds

* chore: update dependencies for vulnerabilities

* refactor: change name length to accomodate new endpoints

* chore: sync package-lock

* chore: remove migrations and shorten endpoint names

* chore: fix find and replace error

* chore: fix spelling

* chore: update packages

* chore: sync package-lock

Co-authored-by: shashi165 <33355509+shashi165@users.noreply.github.com>
Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>
Co-authored-by: Steven Oderayi <oderayi@gmail.com>
Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com>
Co-authored-by: lazolalucas <lazolalucas@users.noreply.github.com>
Co-authored-by: Valentin Genev <vgenev@gmail.com>
Co-authored-by: Valentin <valentin.genev@modusbox.com>
Co-authored-by: Adrian Enns <ennsak@gmail.com>
Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>
Co-authored-by: Snyk bot <github+bot@snyk.io>
Co-authored-by: Ali Behnamfard <abehnamfard@users.noreply.github.com>
Co-authored-by: eoln <2881004+eoln@users.noreply.github.com>
@kleyow kleyow force-pushed the chore/sync-latest-11.3.3 branch from 29149c4 to a74f6b0 Compare December 21, 2020 01:53
@kleyow kleyow marked this pull request as ready for review December 21, 2020 02:21
@kleyow kleyow requested review from eoln and lewisdaly December 21, 2020 02:22
@kleyow
Copy link
Contributor Author

kleyow commented Dec 21, 2020

This has been rebased off of upstream/master instead since rebasing off of v11.3.3 was failing

@kleyow kleyow changed the title chore: sync to v11.3.3 chore: sync to #801 Dec 21, 2020
@kleyow kleyow changed the title chore: sync to #801 chore: sync to ab96ea19ca0ea6fc158acdf16a694f6eef181cf7 Dec 21, 2020
@kleyow
Copy link
Contributor Author

kleyow commented Dec 22, 2020

@eoln

@@ -1,10 +1,10 @@
# LICENSE

Copyright © 2017 Bill & Melinda Gates Foundation
Copyright © 2020 Mojaloop Foundation
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop this change if it isn't coming from the master

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. Lewis seems to updated the licenses accross many of the repos.

: (action === Enum.Events.Event.Action.BULK_TIMEOUT_RESERVED ? Enum.Events.ActionLetter.bulkTimeoutReserved
: (action === Enum.Events.Event.Action.BULK_ABORT ? Enum.Events.ActionLetter.bulkAbort
: Enum.Events.ActionLetter.unknown)))))))))
const actionLetter = action === Enum.Events.Event.Action.PREPARE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a masterpiece test - you pass if you exactly know what is going on :-D

@kleyow kleyow merged commit a89591f into mojaloop:pisp/master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.