Settlement-v2 merge into master #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added migrations and seeds * WIP * Remove unused code (#504) * Remove unused code * Update dependencies * Maintenance update (#505) - Upgraded Event-SDK - Version bump * Upgraded central-services-stream for #1114KafkaErrorLocalQueuefull fix (#511) * package.json and package-lock * Changes following peer review * Added settlementWindowContent.settlementId Co-authored-by: Steven Oderayi <oderayi@gmail.com> Co-authored-by: Miguel de Barros <miguel@debarros.me>
* Added additional window states * Change to currentStateId. Dependencies update
Disabled settlementModel seeds (#564)
* Changes: * 1179-Create SettlementModel API new code * Address PR comments: - Used central-services-shared for the enums - handled duplicate insert to not return internal server error and sql statement - Fixed validations on the routes.js - Changed settlementCurrency to currency on the request - Changed type to ledgerAccountType on the request * 1179-Create SettlementModel API Cleaned up the code * Triggering build * Applied standard.JS
* Added settlementModel.autoPositionReset. Dependencies update * Fix /settlementModel to plural /settlementModels * Fix npm vulnerabilities
#588) * Changes for story #1207: - Added PUT/GET routes with Joi validations - Included #1211 autoPositionReset property to GET requests - Created handler scripts - Implemented DAO scripts - Updated Unit tests * Fixed npm audit errors * 1207- Implement settlementModels management - GET and PUT operations * Moved enums to central-services-shared * Updated central-services-shared version
* Implemented settlement model definition validation. Node upgrade * 9.1.2-snapshot * Fix coverage * Change as per PR request
settlement model unique constraint (#606)
ggrg
requested review from
mdebarros,
lewisdaly,
elnyry-sam-k,
NicoDuvenage,
rmothilal,
MichaelJBRichards and
ndonnan
rmothilal
approved these changes
Feb 26, 2020
seeds/z1000_settlementModel.js-
Outdated
| @@ -0,0 +1,56 @@ | |||
| /***** | |||
There was a problem hiding this comment.
why does the filename have a dash at the end of it?
There was a problem hiding this comment.
It is currently not executed, but I just wanted to preserve it for a while until it's absolutely certain, there won't be any generic settlement models to be seeded. Please, let me know if it would be better to delete the script.
There was a problem hiding this comment.
I would make a note in the file if you wish to keep it
There was a problem hiding this comment.
I would suggest making a Note in the file stating why it is there and that it is not used. also consider appending or prepending the file name with ignore/deprecated or an appropriate term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably, it is good time to consider merging into master to avoid further maintenance