#1207- Implement settlementModels management - GET and PUT operations #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added PUT/GET routes with Joi validations - Included #1211 autoPositionReset property to GET requests - Created handler scripts - Implemented DAO scripts - Updated Unit tests
14 tasks
ggrg
requested changes
Feb 12, 2020
There was a problem hiding this comment.
@lazolalucas, please see my comment below. I know it looks insignificant, but we were having such local enums before moving all to central-services-shared. We don't want to stack up again. Other than that - PR looks great. Thanks
* Moved enums to central-services-shared * Updated central-services-shared version
…lsmanagement-GETandPUToperations
ggrg
added a commit
that referenced
this pull request
Feb 27, 2020
* feature/1093 Alter DB Schema for Settlements (#501) * Added migrations and seeds * WIP * Remove unused code (#504) * Remove unused code * Update dependencies * Maintenance update (#505) - Upgraded Event-SDK - Version bump * Upgraded central-services-stream for #1114KafkaErrorLocalQueuefull fix (#511) * package.json and package-lock * Changes following peer review * Added settlementWindowContent.settlementId Co-authored-by: Steven Oderayi <oderayi@gmail.com> Co-authored-by: Miguel de Barros <miguel@debarros.me> * feature/1095 Close Settlement Window Changes (#539) * Added additional window states * Change to currentStateId. Dependencies update * feature/1096 Create Settlement Changes #1 (#551) * Seed settlementModel samples. Deps * settlementModel.name unique index * Re-run failed integration tests. Added hapi-swagger to ncu ignore list * feature/1100 Settlement By Currency Wrap Up Disabled settlementModel seeds (#564) * Preparing 8.8.2-snapshot settlement-v2 release * Implement createSettlementModel admin API#1179 (#578) * Changes: * 1179-Create SettlementModel API new code * Address PR comments: - Used central-services-shared for the enums - handled duplicate insert to not return internal server error and sql statement - Fixed validations on the routes.js - Changed settlementCurrency to currency on the request - Changed type to ledgerAccountType on the request * 1179-Create SettlementModel API Cleaned up the code * Triggering build * Applied standard.JS * feature/1211 Settlement v2 Auto Position Reset (#586) * Added settlementModel.autoPositionReset. Dependencies update * Fix /settlementModel to plural /settlementModels * Fix npm vulnerabilities * Prepared new settlement-v2 snapshot release * Prepared new settlement-v2 snapshot release * Prepare 9.1.1-snapshot settlement-v2 release * #1207- Implement settlementModels management - GET and PUT operations (#588) * Changes for story #1207: - Added PUT/GET routes with Joi validations - Included #1211 autoPositionReset property to GET requests - Created handler scripts - Implemented DAO scripts - Updated Unit tests * Fixed npm audit errors * 1207- Implement settlementModels management - GET and PUT operations * Moved enums to central-services-shared * Updated central-services-shared version * feature/1210Validate Settlement Model Definition (#594) * Implemented settlement model definition validation. Node upgrade * 9.1.2-snapshot * Fix coverage * Change as per PR request * feature/1209 Restrict Create Settlement settlement model unique constraint (#606) * Trigger circle CI re-run * Changes as per PR review Co-authored-by: Steven Oderayi <oderayi@gmail.com> Co-authored-by: Miguel de Barros <miguel@debarros.me> Co-authored-by: lazolalucas <lazolalucas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
- Added PUT/GET routes with Joi validations
- Included #1211 autoPositionReset property to GET requests
- Created handler scripts
- Implemented DAO scripts
- Updated Unit tests