Bugfix/391 updating postman link in onboarding doc #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit '2322954e81f3b99b8e220c1f075800fa93f5ff8a': Incrementing version to 3.6.1-snapshot (#145)
… collection and also some additional steps, information
elnyry-sam-k
requested review from
rmothilal,
mdebarros,
ggrg and
NicoDuvenage
18 tasks
rmothilal
added a commit
that referenced
this pull request
Oct 2, 2018
* #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout
rmothilal
added a commit
that referenced
this pull request
Oct 3, 2018
* #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157)
rmothilal
added a commit
that referenced
this pull request
Oct 4, 2018
* Develop (#57) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * fixing unit tests, stubbing smtp server * settlement coverage * unit testing for settlements and csv * removed console.logs * code working except for test * fixes for some tests * updates for validation working * fixing reorder * reverting * fix file path * added updated config.yml script * testing * unit test fixes and changes. coverage failing * fixes for coverage tests only setup.js left now * fixes for docker version and updated onboarding doc * removing fs-extra * reverting default json for sidecar * Fix src/setup/setup.js tests * changes for POC DB #75 * updated code for functional tests and integration tests * files for integration and functional tests * fixes for testing * sodium build issues * issues with sodium * removed global install of sodium and argon which is breaking circleci build. build is currently cached so it may break again because of cache * version upgrade * added local install of tape and tap-xunit to config.yml and test.dockerfile * version change so that cache refreshes * dependency issue for tape and tap-xunit * added tape and tap-xunit for test.docker file back for testing to pass * Completed the migration scripts conversion from Postgress to mySql syntax. ran scripts and checked the tables in the database * Additional fixes needed to NPM start with the Mysql changes * Fix for default value issue in user credential account. Fixes for Foreign key constraints * Fix unit test that was failing * Fix prepare transfer issue when running Postman script * Fix issues with JSON stringify and date time stamp to conform to Mysql and fixed test cases * changes to remove eventric code from system rajiv to pick up * fixes for settlements and fulfillment, fees now get added correctly and is settle with transfers * fixed issues for rejected transfers * updated node version to use newer version as new frameworks used * Add email address validator to "accounts post" in Admin * updated code to implement mysql db poc as well as removed eventric code * #158 Update existing CI/CD for each repo to be compatible with K8s London (#58) * Re-aligned circleci2.0 config to k8s-london 1. added support for token authorization 2. added support for selecting a chart version 3. updated helm install/update to correctly check for existing helm installation 4. cleaned up config 5. fixed bug on helm update where one MUST include the original value file to correctly merge value changes 6. fixed typos in integration & functional tests in config * Fixed the following issues: 1. Integration Test Command now does not cat, thus returns proper result code (0 - success, >0 - failure) 2. Integration script re-worked to properly handle failure case 3. updated nvmrc to the version of node that we are using * fixed typoe in node version in nvmrc * Feature/#149re align db model migrations (#60) * migrations by Georgi * migrations by Nikolay * Migrations by Nikolay (fix fsp to participant) * Migrations by Nikolay (fix the migration timestamp) * valentin's migrations * Renaming files with latest timestamps * Cleaning out old migration scripts * Migrations by Deon * cleaning up * Merging migration scripts 1 * Merging migration scripts 2 * Merging migration scripts 3 * Fixing migration scripts * Rename migrations to singular * renaming topic to event * Temporary disable Ledger account creation * Finalize CDM changes * Feature/#151 node db intrface (#63) * migrations by Georgi * migrations by Nikolay * Migrations by Nikolay (fix fsp to participant) * Migrations by Nikolay (fix the migration timestamp) * valentin's migrations * Renaming files with latest timestamps * Cleaning out old migration scripts * Migrations by Deon * cleaning up * Merging migration scripts 1 * Merging migration scripts 2 * Merging migration scripts 3 * Fixing migration scripts * Rename migrations to singular * renaming topic to event * Temporary disable Ledger account creation * Finalize CDM changes * transfers renamed * users -> party * fews -> few * before accounts * changed the currency table accordingly and seeded the currency codes * currencies with names added to seed script * trying to make it work * fixed permissions * Feature/#207 auto populate currency table (#62) * changed the currency table accordingly and seeded the currency codes * currencies with names added to seed script * Develop pi2 (#65) * #210 - transfer settlement batch table updated V1.0.3 * #210 - transfer settlement batch table updated V1.0.4 * #210 - transfer settlement batch table updated V1.0.5 * Feature/154 implement prepare handler (#70) * changes for registering consumers * added for multiple handlers per functionality or a single handler * fixes for prepare stream processing * handler registration for kafka topics * handlers and routes added for kafka consumer handlers * file missing * neatening of code to standards for error handling * License agreement added * align naming conventions and coding standards * all documentation added and outstanding error handling * Updated documentation * Feature/#211 participants (#66) * WIP * admin/participants is working * seeds back to normal * following the new code standards into the participant module * some errors fixed and some tests also * Fixed migration scripts to work with UTF8MB4 * Fixed migration scripts to work with UTF8MB4 (#67) * updated transfer migration scripts * onboarding doc * updated transfer projection to correctly join the transfer and transferStateChange * updated transfer projection to correctly join the transfer and transferStateChange * updated migration scripts as per discussion for v6 of ERD * updated migration scripts as per discussion for v6 of ERD * updated migration scripts as per discussion for v6 of ERD * fixed seeds and migration conflicts * Feature/#211 implement data access layer required for prepare handler (#69) * Fixed migration scripts to work with UTF8MB4 * updated transfer migration scripts * updated transfer projection to correctly join the transfer and transferStateChange * updated transfer projection to correctly join the transfer and transferStateChange * updated migration scripts as per discussion for v6 of ERD * updated migration scripts as per discussion for v6 of ERD * updated migration scripts as per discussion for v6 of ERD * fixed seeds and migration conflicts * Several updates for transgers, ilp and transferstatechange 1. projection for transfers now correctly inserts transfer, ilp and transferStateChange into DB 2. updated states 3. moved ilp model to generic model folder * 1. projection for transfers to handled extensions, and also updated the translator to correctly mape the transferreadmodel to mojaloop schema * added missing completedTimestamp from transfer message in transferReadModel and saveTransferPrepare, added transfer translator support for saveTransferPrepare * updated changes for preparehandler from kafka * updated model for transferStates, and created an integration test * consumer not working * Schema validation function Added a function to validate payload against schema * fixed starting issue and added npm run for handlers * fixed issues with the consumers consuming null messages * changes for the prepare handler Fix all query files to database and fix for consumer passing null fix for consumer not committing messages and other things * changes for prepare handler, having negative cases and handling accordingly added code to retrieve all participants from database and get names and dynamically create topics commented and cleaning up code * code updated to include create producer template where it is called with the messageProtocol, topic config and kafka config which can now be gotten dynamically * neatening code * changes for notifications seems to have created more issues * changes * added changes for notification producer not working * hack to register notification topic * committing package version change * fix path of mojaloop-services-shared * fixed seed start on npm start issue * fixed seeds path * changes to test producer code * Tweaked some stuff. * WIP tests * participant unit test finished * Commit initial program changes for Transfer handler * integration and coverage of participants * changes for making producer creation more dynamic * positive unit tests done the proper way * Added Transfer object to default,json and transfer object to the handler * Added code comments * added testPI2 folder * Added event Dao code and changes to the event handler as reviewed by Rajiv * participant integration tests working fine * Added final code changes to handler.js as well as code to consume message and send notification as to Miguel's new design * unit tests for participants done * integration tests for ilp * Added code to test producer * added files for unit tests * Remove unused code (method : CreateTransferHnadler) * extensions unit done * Added unit test (Happy lines) for Projections.js * transferStateChange Unit test done * unit tests for ilp, unit tests for transferState, fixing some issues * unit tests for ilp, unit tests for transferState, fixing some issues * Added more test code (Unhappy Line) * Added more testing (Unhappy Lines) * added integration helper modules for inserting data into database * unit tests for the prepare * Added last Negative tests to saveTransferPrepared * Add happy line testing : saveTransferRejected * updated tests * validation tests passing * added more tests * added test for dao * Increased code coverage by removing un necessary exception handling statements * exclude testPI2 folder from test results * WIP integration helper * commenting unused methods about transfer table, fixing call methods for inserting transfer row * Added negative testing to saveTransferRejected * Add test file testP12/unit/domain/transfer/commands/index * transfer unit test WIP * utility tests created * added dummy test for notifications coverage neatening up of code to standards * fixing standards * Add test scripts for index * changes added register all handlers on start of API server * added setup test * added tests for the routes and plugins * Add more code for happy line testing * tests almost complete * completed tests * transfer unit tests WIP * Add 'save transfer prepared throws error' test and changed exception handling in the index.js file * Added reject happy line testing code * Finish commands.index unit tests * Started with transfer.index unit test * Added transfer.index prepare happy line test * Added unhappy line testing for transfer.index * Added unhappy line testing to transfer.index unit test * fixed object for transfer * Added position handler funtionality * integration tests for ilp, fixes on some models, services and other minor bugs * Added unit tests * Updated unit test * transfer unit finished * Added new tests cases * added working integration scripts for PI2 test * integration test for extension and some minor fixes * Fixed comments from review * added functionality to run through prepare, position and transfer * fixed issue that the docker build command was commented out in the integration-runner.sh * integration test not working * testing sinon callback issue * testing sinon callback issue * working integration tests using DB inspection * test * fixing standards issues * notification tests updated * added missing tests for coverage * integration for transferStateChange done * fixed some problems * integration test done as well * removal of unused code * refactor of fulfill British standard fulfil added position handler for fulfil path and added new tests for coverage * updated to suggested changes by miguel * default.json * Added a "network" to the Integration Test script runner to resolve connectivity to Kafka * Disabled functional tests until they are implemented * Disabled functional tests until they are implemented * will reset * changed to false * fixed issues with integration test due to miss-aligned config * updated config for removal of auto commit * fixed issues with integration test due to miss-aligned config * Feature/#272 Implement Fulfil Handler Consume (Success) (#72) * Fulfil handler commit implementation * Unit tests * Integration tests * testProducer upgraded to produce prepare&commit without restart * Repair FK transferStateChange to transfer Added missing foreign key constraint * Feature/#248 merge all the changes (#73) * Added Unhappy line test to improve code coverage * transfer model integration done, fixed bug in the model, fixed the unit test accordingly * extension coverage 100% * Fulfil handler commit implementation * TODO: FiveBellsCondition.fulfillmentToCondition comment changed * Added destroyByName method's happy and Unhappy line Unit tests, Code coverage is now 100% on participant/model.js * Unit tests for fulfil success * Merge vgenev feature/#248 * Starting to add unhappy lines on transferstatechange read-model-test.js to increase code coverage * Repair new Error and run /integration tests * Added more unhappy line integration tests * Restore sidecar-enabled and keychain-admin_secret * Ja and some more still * added final unhappy lines , code coverage 100% for read-model.test.js * improvement of the coverage for ilp * Integration tests for Fulfil Commit Success * improvement of the coverage for transferState * Added unhappy line integration test (get All method) on participant/index.test.js * Final chnages code coverage 100% on integration tests for participant/index.test.js * remove unnecessary ilp * ilp cleaned and tested * all test coverage 100% * added license info * removed some commented code and added license to the transfer-read-model also * removed some commented code and added license to the transfer-read-model again * removed commented out code and fixed some merge issues * merged * worked on Georgi remarks * It would seem that the build-dependencies no longer includes git. I have manually added it. (#74) * It would seem that the build-dependencies no longer includes git. I have manually added it. * Fixed issues with the docker files * Feature/pi2 fixes (#76) * added jsdocs config and updated documentation to create webpage * updated methods to functions * updated documentation files * ignore docs folder on commit * fixes for pi2 demo * fixes * optional dependency * fixes for tests and error messages * incorrect error message used * Aligned crypto-condition validation check based on Mojaloop specification * Moved Fulfil Condition validation to a function, and fixed logic issue with validateFulfilCondition * Added some comments for the validateFulfilCondition logic * Added branching logic for TransferPrepare.transfer handler * fixes for integration test failures * Made update to update condition to be used only in CryptoConditions Validate * Feature/version change pi2 (#81) * update version to 2.4.0-snapshot for completed PI2
rmothilal
added a commit
that referenced
this pull request
Oct 4, 2018
* Develop (#57) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * fixing unit tests, stubbing smtp server * settlement coverage * unit testing for settlements and csv * removed console.logs * code working except for test * fixes for some tests * updates for validation working * fixing reorder * reverting * fix file path * added updated config.yml script * testing * unit test fixes and changes. coverage failing * fixes for coverage tests only setup.js left now * fixes for docker version and updated onboarding doc * removing fs-extra * reverting default json for sidecar * Fix src/setup/setup.js tests * changes for POC DB #75 * updated code for functional tests and integration tests * files for integration and functional tests * fixes for testing * sodium build issues * issues with sodium * removed global install of sodium and argon which is breaking circleci build. build is currently cached so it may break again because of cache * version upgrade * added local install of tape and tap-xunit to config.yml and test.dockerfile * version change so that cache refreshes * dependency issue for tape and tap-xunit * added tape and tap-xunit for test.docker file back for testing to pass * Completed the migration scripts conversion from Postgress to mySql syntax. ran scripts and checked the tables in the database * Additional fixes needed to NPM start with the Mysql changes * Fix for default value issue in user credential account. Fixes for Foreign key constraints * Fix unit test that was failing * Fix prepare transfer issue when running Postman script * Fix issues with JSON stringify and date time stamp to conform to Mysql and fixed test cases * changes to remove eventric code from system rajiv to pick up * fixes for settlements and fulfillment, fees now get added correctly and is settle with transfers * fixed issues for rejected transfers * updated node version to use newer version as new frameworks used * Add email address validator to "accounts post" in Admin * updated code to implement mysql db poc as well as removed eventric code * #158 Update existing CI/CD for each repo to be compatible with K8s London (#58) * Re-aligned circleci2.0 config to k8s-london 1. added support for token authorization 2. added support for selecting a chart version 3. updated helm install/update to correctly check for existing helm installation 4. cleaned up config 5. fixed bug on helm update where one MUST include the original value file to correctly merge value changes 6. fixed typos in integration & functional tests in config * Fixed the following issues: 1. Integration Test Command now does not cat, thus returns proper result code (0 - success, >0 - failure) 2. Integration script re-worked to properly handle failure case 3. updated nvmrc to the version of node that we are using * fixed typoe in node version in nvmrc * Feature/#149re align db model migrations (#60) * migrations by Georgi * migrations by Nikolay * Migrations by Nikolay (fix fsp to participant) * Migrations by Nikolay (fix the migration timestamp) * valentin's migrations * Renaming files with latest timestamps * Cleaning out old migration scripts * Migrations by Deon * cleaning up * Merging migration scripts 1 * Merging migration scripts 2 * Merging migration scripts 3 * Fixing migration scripts * Rename migrations to singular * renaming topic to event * Temporary disable Ledger account creation * Finalize CDM changes * Feature/#151 node db intrface (#63) * migrations by Georgi * migrations by Nikolay * Migrations by Nikolay (fix fsp to participant) * Migrations by Nikolay (fix the migration timestamp) * valentin's migrations * Renaming files with latest timestamps * Cleaning out old migration scripts * Migrations by Deon * cleaning up * Merging migration scripts 1 * Merging migration scripts 2 * Merging migration scripts 3 * Fixing migration scripts * Rename migrations to singular * renaming topic to event * Temporary disable Ledger account creation * Finalize CDM changes * transfers renamed * users -> party * fews -> few * before accounts * changed the currency table accordingly and seeded the currency codes * currencies with names added to seed script * trying to make it work * fixed permissions * Feature/#207 auto populate currency table (#62) * changed the currency table accordingly and seeded the currency codes * currencies with names added to seed script * Develop pi2 (#65) * #210 - transfer settlement batch table updated V1.0.3 * #210 - transfer settlement batch table updated V1.0.4 * #210 - transfer settlement batch table updated V1.0.5 * Feature/154 implement prepare handler (#70) * changes for registering consumers * added for multiple handlers per functionality or a single handler * fixes for prepare stream processing * handler registration for kafka topics * handlers and routes added for kafka consumer handlers * file missing * neatening of code to standards for error handling * License agreement added * align naming conventions and coding standards * all documentation added and outstanding error handling * Updated documentation * Feature/#211 participants (#66) * WIP * admin/participants is working * seeds back to normal * following the new code standards into the participant module * some errors fixed and some tests also * Fixed migration scripts to work with UTF8MB4 * Fixed migration scripts to work with UTF8MB4 (#67) * updated transfer migration scripts * onboarding doc * updated transfer projection to correctly join the transfer and transferStateChange * updated transfer projection to correctly join the transfer and transferStateChange * updated migration scripts as per discussion for v6 of ERD * updated migration scripts as per discussion for v6 of ERD * updated migration scripts as per discussion for v6 of ERD * fixed seeds and migration conflicts * Feature/#211 implement data access layer required for prepare handler (#69) * Fixed migration scripts to work with UTF8MB4 * updated transfer migration scripts * updated transfer projection to correctly join the transfer and transferStateChange * updated transfer projection to correctly join the transfer and transferStateChange * updated migration scripts as per discussion for v6 of ERD * updated migration scripts as per discussion for v6 of ERD * updated migration scripts as per discussion for v6 of ERD * fixed seeds and migration conflicts * Several updates for transgers, ilp and transferstatechange 1. projection for transfers now correctly inserts transfer, ilp and transferStateChange into DB 2. updated states 3. moved ilp model to generic model folder * 1. projection for transfers to handled extensions, and also updated the translator to correctly mape the transferreadmodel to mojaloop schema * added missing completedTimestamp from transfer message in transferReadModel and saveTransferPrepare, added transfer translator support for saveTransferPrepare * updated changes for preparehandler from kafka * updated model for transferStates, and created an integration test * consumer not working * Schema validation function Added a function to validate payload against schema * fixed starting issue and added npm run for handlers * fixed issues with the consumers consuming null messages * changes for the prepare handler Fix all query files to database and fix for consumer passing null fix for consumer not committing messages and other things * changes for prepare handler, having negative cases and handling accordingly added code to retrieve all participants from database and get names and dynamically create topics commented and cleaning up code * code updated to include create producer template where it is called with the messageProtocol, topic config and kafka config which can now be gotten dynamically * neatening code * changes for notifications seems to have created more issues * changes * added changes for notification producer not working * hack to register notification topic * committing package version change * fix path of mojaloop-services-shared * fixed seed start on npm start issue * fixed seeds path * changes to test producer code * Tweaked some stuff. * WIP tests * participant unit test finished * Commit initial program changes for Transfer handler * integration and coverage of participants * changes for making producer creation more dynamic * positive unit tests done the proper way * Added Transfer object to default,json and transfer object to the handler * Added code comments * added testPI2 folder * Added event Dao code and changes to the event handler as reviewed by Rajiv * participant integration tests working fine * Added final code changes to handler.js as well as code to consume message and send notification as to Miguel's new design * unit tests for participants done * integration tests for ilp * Added code to test producer * added files for unit tests * Remove unused code (method : CreateTransferHnadler) * extensions unit done * Added unit test (Happy lines) for Projections.js * transferStateChange Unit test done * unit tests for ilp, unit tests for transferState, fixing some issues * unit tests for ilp, unit tests for transferState, fixing some issues * Added more test code (Unhappy Line) * Added more testing (Unhappy Lines) * added integration helper modules for inserting data into database * unit tests for the prepare * Added last Negative tests to saveTransferPrepared * Add happy line testing : saveTransferRejected * updated tests * validation tests passing * added more tests * added test for dao * Increased code coverage by removing un necessary exception handling statements * exclude testPI2 folder from test results * WIP integration helper * commenting unused methods about transfer table, fixing call methods for inserting transfer row * Added negative testing to saveTransferRejected * Add test file testP12/unit/domain/transfer/commands/index * transfer unit test WIP * utility tests created * added dummy test for notifications coverage neatening up of code to standards * fixing standards * Add test scripts for index * changes added register all handlers on start of API server * added setup test * added tests for the routes and plugins * Add more code for happy line testing * tests almost complete * completed tests * transfer unit tests WIP * Add 'save transfer prepared throws error' test and changed exception handling in the index.js file * Added reject happy line testing code * Finish commands.index unit tests * Started with transfer.index unit test * Added transfer.index prepare happy line test * Added unhappy line testing for transfer.index * Added unhappy line testing to transfer.index unit test * fixed object for transfer * Added position handler funtionality * integration tests for ilp, fixes on some models, services and other minor bugs * Added unit tests * Updated unit test * transfer unit finished * Added new tests cases * added working integration scripts for PI2 test * integration test for extension and some minor fixes * Fixed comments from review * added functionality to run through prepare, position and transfer * fixed issue that the docker build command was commented out in the integration-runner.sh * integration test not working * testing sinon callback issue * testing sinon callback issue * working integration tests using DB inspection * test * fixing standards issues * notification tests updated * added missing tests for coverage * integration for transferStateChange done * fixed some problems * integration test done as well * removal of unused code * refactor of fulfill British standard fulfil added position handler for fulfil path and added new tests for coverage * updated to suggested changes by miguel * default.json * Added a "network" to the Integration Test script runner to resolve connectivity to Kafka * Disabled functional tests until they are implemented * Disabled functional tests until they are implemented * will reset * changed to false * fixed issues with integration test due to miss-aligned config * updated config for removal of auto commit * fixed issues with integration test due to miss-aligned config * Feature/#272 Implement Fulfil Handler Consume (Success) (#72) * Fulfil handler commit implementation * Unit tests * Integration tests * testProducer upgraded to produce prepare&commit without restart * Repair FK transferStateChange to transfer Added missing foreign key constraint * Feature/#248 merge all the changes (#73) * Added Unhappy line test to improve code coverage * transfer model integration done, fixed bug in the model, fixed the unit test accordingly * extension coverage 100% * Fulfil handler commit implementation * TODO: FiveBellsCondition.fulfillmentToCondition comment changed * Added destroyByName method's happy and Unhappy line Unit tests, Code coverage is now 100% on participant/model.js * Unit tests for fulfil success * Merge vgenev feature/#248 * Starting to add unhappy lines on transferstatechange read-model-test.js to increase code coverage * Repair new Error and run /integration tests * Added more unhappy line integration tests * Restore sidecar-enabled and keychain-admin_secret * Ja and some more still * added final unhappy lines , code coverage 100% for read-model.test.js * improvement of the coverage for ilp * Integration tests for Fulfil Commit Success * improvement of the coverage for transferState * Added unhappy line integration test (get All method) on participant/index.test.js * Final chnages code coverage 100% on integration tests for participant/index.test.js * remove unnecessary ilp * ilp cleaned and tested * all test coverage 100% * added license info * removed some commented code and added license to the transfer-read-model also * removed some commented code and added license to the transfer-read-model again * removed commented out code and fixed some merge issues * merged * worked on Georgi remarks * It would seem that the build-dependencies no longer includes git. I have manually added it. (#74) * It would seem that the build-dependencies no longer includes git. I have manually added it. * Fixed issues with the docker files * Feature/pi2 fixes (#76) * added jsdocs config and updated documentation to create webpage * updated methods to functions * updated documentation files * ignore docs folder on commit * fixes for pi2 demo * fixes * optional dependency * fixes for tests and error messages * incorrect error message used * Aligned crypto-condition validation check based on Mojaloop specification * Moved Fulfil Condition validation to a function, and fixed logic issue with validateFulfilCondition * Added some comments for the validateFulfilCondition logic * Added branching logic for TransferPrepare.transfer handler * fixes for integration test failures * Made update to update condition to be used only in CryptoConditions Validate * version change * update version to release for master merge * Feature/version change pi2 (#80) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * Develop (#9) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * fixing unit tests, stubbing smtp server * settlement coverage * unit testing for settlements and csv * removed console.logs * Feature/continuous integration v3 (#10) (#42) * test ci build and package * Feature/continuou integration v3 (#11) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * added psql tools to machine path * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * CI test 2018-02-08-18:52:54 (#45) * Feature/#60 automate the cd pipeline for central ledger (#47) * Feature/continuou integration v3 (#10) test ci build and package * Feature/continuou integration v3 (#11) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * Feature/continuou integration v3 (#12) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * Feature/continuou integration v3 (#14) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * Feature/continuou integration v3 (#15) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * Feature/continuou integration v3 (#16) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * citest-20180119-11h52m21s * Feature/continuou integration v3 (#17) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * citest-20180119-11h52m21s * citest-20180119-12h00m04s * citest-20180119-12h00m19s * citest-20180119-12h04m40s * Feature/continuou integration v3 (#18) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * citest-20180119-11h52m21s * citest-20180119-12h00m04s * citest-20180119-12h00m19s * Feature/continuou integration v3 (#19) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * citest-20180119-11h52m21s * citest-20180119-12h00m04s * citest-20180119-12h00m19s * citest-20180119-12h08m50s * Feature/continuou integration v3 (#20) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * citest-20180119-11h52m21s * citest-20180119-12h00m04s * citest-20180119-12h00m19s * citest-20180119-12h08m50s * citest-20180119-12h14m24s * Feature/continuou integration v3 (#21) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * citest-20180119-11h52m21s * citest-20180119-12h00m04s * citest-20180119-12h00m19s * citest-20180119-12h08m50s * citest-20180119-12h14m24s * citest-20180119-12h20m37s * Feature/continuou integration v3 (#22) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * citest-20180119-11h52m21s * citest-20180119-12h00m04s * citest-20180119-12h00m19s * citest-20180119-12h08m50s * citest-20180119-12h14m24s * citest-20180119-12h20m37s * citest-20180119-12h24m05s * Feature/continuou integration v3 (#23) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * citest-20180119-11h52m21s * citest-20180119-12h00m04s * citest-20180119-12h00m19s * citest-20180119-12h08m50s * citest-20180119-12h14m24s * citest-20180119-12h20m37s * citest-20180119-12h24m05s * citest-20180122-10h12m33s * Feature/continuou integration v3 (#24) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * citest-20180119-11h52m21s * citest-20180119-12h00m04s * citest-20180119-12h00m19s * citest-20180119-12h08m50s * citest-20180119-12h14m24s * citest-20180119-12h20m37s * citest-20180119-12h24m05s * citest-20180122-10h12m33s * citest-20180122-10h18m34s * Feature/continuou integration v3 (#25) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-20180119-11h35m50s * citest-20180119-11h45m02s * citest-20180119-11h52m21s * citest-20180119-12h00m04s * citest-20180119-12h00m19s * citest-20180119-12h08m50s * citest-20180119-12h14m24s * citest-20180119-12h20m37s * citest-20180119-12h24m05s * citest-20180122-10h12m33s * citest-20180122-10h18m34s * citest-20180122-10h22m01s * citest-20180122-10h23m08s * Feature/continuou integration v3 (#26) * Feature/devops k8s (#3) * Updated @mojaloop NPM dependency versions * Added k8 deployment and helm files into deploy folder * Updated Deployment for Liveness Probe, and updated Ingress for rewrite-target rule * Added kubernetes.md * Updated circle.yaml for npm repo and docker image names * Updated package.json with working dependency version * final draft circleci v2 config 13:56:52 * final draft circleci v2 config 14:00:30 * final draft circleci v2 config 14:01:28 * final draft circleci v2 config 14:03:55 * final draft circleci v2 config 14:05:07 * final draft circleci v2 config 14:08:07 * final draft circleci v2 config 14:09:27 * final draft circleci v2 config 14:11:49 * final draft circleci v2 config 14:13:28 * final draft circleci v2 config 14:18:28 * final draft circleci v2 config 14:19:37 * final draft circleci v2 config 14:28:47 * final draft circleci v2 config 14:33:16 * final draft circleci v2 config 14:39:34 * final draft circleci v2 config 14:40:40 * Fixed some issues with the functional tests * trying to run functional and integration tests in a machine instead of a container * error using "source" on circleci * yes * added psql tools to machine path * investigating issue * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * yes T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * test-T * yes * updated config * test-T * test-T * test-T * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * Fixed invalid line in .circleci/config.yml * disabled test-spec * feature/continuous integration v2 (#4) * Migrated from CircleCI v1 to v2. v1 circleci.yml still in project for now. * Tests for functional, integration & spec will now execute entirely inside of docker images. Spec is has been commented out for the time being due to failure which is yet to be investigated. * disabled test-spec until issue can be resolved. * Develop (#6) * Incorporate all historical changes to align with mojaloop. * Tested locally with provided scripts - passed Tested with Postman - passed To be fixed: Credentials on tests for SMTP * Fixed Emailing test with a valid user * fixes for unit test issues * re-added sidecar enabled * fixes and updates to tests and package * fixes for functional tests * testing ci * citest-20180119-11h26m04s * disabling tests for speed * citest-201801…
rmothilal
added a commit
that referenced
this pull request
Oct 11, 2018
* #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code
rmothilal
added a commit
that referenced
this pull request
Oct 12, 2018
* fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code
rmothilal
added a commit
that referenced
this pull request
Oct 12, 2018
* fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test
rmothilal
added a commit
that referenced
this pull request
Oct 16, 2018
* #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * Feature/perf3.6 enhancements (#169) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/perf3.6 enhancements (#172) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/509 Participant Accounts Endpoint (#170) * Added initial position for settlement account, added accounts endpoint * Added unit tests for newly introduced code * Feature/425 Timeout Handler Tests (#171) * unit/coverage tests for timeout handler * Unit tests and coverage for timeoutHandler and transferTimeoutModel * Fixed integration tests teardown test (#173) * refactor code to commit message to kafka after all processing is completed, fulfil, prepare, positions and fixed tests
rmothilal
added a commit
that referenced
this pull request
Oct 16, 2018
* #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * Feature/perf3.6 enhancements (#169) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/perf3.6 enhancements (#172) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/509 Participant Accounts Endpoint (#170) * Added initial position for settlement account, added accounts endpoint * Added unit tests for newly introduced code * Feature/425 Timeout Handler Tests (#171) * unit/coverage tests for timeout handler * Unit tests and coverage for timeoutHandler and transferTimeoutModel * Fixed integration tests teardown test (#173) * refactor code to commit message to kafka after all processing is completed, fulfil, prepare, positions and fixed tests * Feature/#452 add get on/transfers/{id} (#176) * Added backend code for story #452 - get transfers by Id * Change default.json back to default * bug fix * Added unit test(Pos and neg) for register transfer handler * Added more unit tests to increase code coverage for Transfer handler * Add Unit tests and increase code coverage
rmothilal
added a commit
that referenced
this pull request
Oct 16, 2018
* #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * Feature/perf3.6 enhancements (#169) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/perf3.6 enhancements (#172) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/509 Participant Accounts Endpoint (#170) * Added initial position for settlement account, added accounts endpoint * Added unit tests for newly introduced code * Feature/425 Timeout Handler Tests (#171) * unit/coverage tests for timeout handler * Unit tests and coverage for timeoutHandler and transferTimeoutModel * Fixed integration tests teardown test (#173) * refactor code to commit message to kafka after all processing is completed, fulfil, prepare, positions and fixed tests * Feature/#452 add get on/transfers/{id} (#176) * Added backend code for story #452 - get transfers by Id * Change default.json back to default * bug fix * Added unit test(Pos and neg) for register transfer handler * Added more unit tests to increase code coverage for Transfer handler * Add Unit tests and increase code coverage * updated version number
rmothilal
added a commit
that referenced
this pull request
Oct 17, 2018
* #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * Feature/perf3.6 enhancements (#169) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/perf3.6 enhancements (#172) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/509 Participant Accounts Endpoint (#170) * Added initial position for settlement account, added accounts endpoint * Added unit tests for newly introduced code * Feature/425 Timeout Handler Tests (#171) * unit/coverage tests for timeout handler * Unit tests and coverage for timeoutHandler and transferTimeoutModel * Fixed integration tests teardown test (#173) * refactor code to commit message to kafka after all processing is completed, fulfil, prepare, positions and fixed tests * Feature/#452 add get on/transfers/{id} (#176) * Added backend code for story #452 - get transfers by Id * Change default.json back to default * bug fix * Added unit test(Pos and neg) for register transfer handler * Added more unit tests to increase code coverage for Transfer handler * Add Unit tests and increase code coverage * updated version number * added pool to kenex file to manage the number of connections available
rmothilal
added a commit
that referenced
this pull request
Oct 18, 2018
* #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * Feature/perf3.6 enhancements (#169) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/perf3.6 enhancements (#172) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/509 Participant Accounts Endpoint (#170) * Added initial position for settlement account, added accounts endpoint * Added unit tests for newly introduced code * Feature/425 Timeout Handler Tests (#171) * unit/coverage tests for timeout handler * Unit tests and coverage for timeoutHandler and transferTimeoutModel * Fixed integration tests teardown test (#173) * refactor code to commit message to kafka after all processing is completed, fulfil, prepare, positions and fixed tests * Feature/#452 add get on/transfers/{id} (#176) * Added backend code for story #452 - get transfers by Id * Change default.json back to default * bug fix * Added unit test(Pos and neg) for register transfer handler * Added more unit tests to increase code coverage for Transfer handler * Add Unit tests and increase code coverage * updated version number * Increment version (#179) * Incrementing version for MVP release to 3.7.4 * added pool to kenex file to manage the number of connections available * do not insert into participantPositionChange when transfer is aborted (#180) * revert changes for #487 (#182) * do not insert into participantPositionChange when transfer is aborted * revert changes for #487 * revert changes for #487 * Feature/run migrations config (#183) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * updated code to control if migrations run or not, included ddl for database * Feature/run migrations config (#184) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * updated code to control if migrations run or not, included ddl for database * fix for get handler not starting, fixed broken tests * Incrementing version to 3.8.0 (#185) * Updating version to 3.8.0 * update version
rmothilal
added a commit
that referenced
this pull request
Oct 19, 2018
* #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * Feature/perf3.6 enhancements (#169) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/perf3.6 enhancements (#172) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/509 Participant Accounts Endpoint (#170) * Added initial position for settlement account, added accounts endpoint * Added unit tests for newly introduced code * Feature/425 Timeout Handler Tests (#171) * unit/coverage tests for timeout handler * Unit tests and coverage for timeoutHandler and transferTimeoutModel * Fixed integration tests teardown test (#173) * refactor code to commit message to kafka after all processing is completed, fulfil, prepare, positions and fixed tests * Feature/#452 add get on/transfers/{id} (#176) * Added backend code for story #452 - get transfers by Id * Change default.json back to default * bug fix * Added unit test(Pos and neg) for register transfer handler * Added more unit tests to increase code coverage for Transfer handler * Add Unit tests and increase code coverage * updated version number * Increment version (#179) * Incrementing version for MVP release to 3.7.4 * added pool to kenex file to manage the number of connections available * do not insert into participantPositionChange when transfer is aborted (#180) * revert changes for #487 (#182) * do not insert into participantPositionChange when transfer is aborted * revert changes for #487 * revert changes for #487 * Feature/run migrations config (#183) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * updated code to control if migrations run or not, included ddl for database * Feature/run migrations config (#184) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * updated code to control if migrations run or not, included ddl for database * fix for get handler not starting, fixed broken tests * Incrementing version to 3.8.0 (#185) * Updating version to 3.8.0 * update version * updates for connection pool
rmothilal
added a commit
that referenced
this pull request
Oct 25, 2018
* #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * Feature/perf3.6 enhancements (#169) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/perf3.6 enhancements (#172) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * update code to remove transfer handler * fixes for the timeout * Feature/perf3.6 enhancements (#155) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * fixes for the timeout * updated code * Feature/perf3.6 enhancements (#159) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/perf3.6 enhancements (#168) * #395 Added the SEED for endpointType (#142) * Added the SEED for endpointType * Removed unused seed * Feature/461 Settlement Transfer (#150) * Added account type and seeds * Updated DDL and seeds for settlement transfers * Added SETTLEMENT_NET_ZERO ledgerEntryType enum * Changed seeds * Server cached enums (3.1) and create both accounts (6) * Fixed unit tests for the previous commit * Change cache from 5 secs to 5 mins * All references to participantCurrencyId point to the Position Account * Incrementing central ledger version (#152) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Incrementing central-ledger version * Bugfix/391 updating postman link in onboarding doc (#151) * Incrementing version to 3.6.1-snapshot * Updating versions for central-services-shared, central-services-database libraries * Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information * update code to remove transfer handler * Feature/461 settlement transfer (#154) Feature/461 Settlement Transfer - signed amounts * fixes for the timeout * Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149) * validation for different FSPs added and tests are extended (#156) * Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153) * Added validation for negative values of NET_DEBIT_CAP * fixed the unit tests, integration tests and updated the documentation * changed order of enums * added allow(0) * testPI2 -> test (#158) * testPI2 -> test * removed old comments * removed test from istanbul.yml * updated code * Fixed the listed occurrences of local timestamps (#157) * Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160) * Altered ParticipantFacade.adjustLimits to work with external trx * Make commit & rollback conditional * Story #397 cleanup of unused files (#161) * removed caret from pacckage.json * cleaned up unused files * removed unused packages * Bugfix/fix circleci build (#162) * updated dockerfile for failing * updated circle ci config * removal of RUN reserved word * Bugfix/api not starting 08 10 (#163) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * Feature/cleaning unsured code (#164) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * fixes for cleaning up central-ledger * unit test for crypto.js * removal of unused and legacy code * dependency for integration tests * removal of unused code * pre-commit added * added coverage tests (#165) Merging as requested by Shashi and since this is approved by Rajiv * Story #397 cleanup and coverage tests (#167) * added coverage tests * Added coverage tests, removed unused code * removed commented code * fix for integration test * Feature/509 Participant Accounts Endpoint (#170) * Added initial position for settlement account, added accounts endpoint * Added unit tests for newly introduced code * Feature/425 Timeout Handler Tests (#171) * unit/coverage tests for timeout handler * Unit tests and coverage for timeoutHandler and transferTimeoutModel * Fixed integration tests teardown test (#173) * refactor code to commit message to kafka after all processing is completed, fulfil, prepare, positions and fixed tests * Feature/#452 add get on/transfers/{id} (#176) * Added backend code for story #452 - get transfers by Id * Change default.json back to default * bug fix * Added unit test(Pos and neg) for register transfer handler * Added more unit tests to increase code coverage for Transfer handler * Add Unit tests and increase code coverage * updated version number * Increment version (#179) * Incrementing version for MVP release to 3.7.4 * added pool to kenex file to manage the number of connections available * do not insert into participantPositionChange when transfer is aborted (#180) * revert changes for #487 (#182) * do not insert into participantPositionChange when transfer is aborted * revert changes for #487 * revert changes for #487 * Feature/run migrations config (#183) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * updated code to control if migrations run or not, included ddl for database * Feature/run migrations config (#184) * fixes for bug 471, 472, 469 * rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests * logger.error and capitalise the word no * updated code to control if migrations run or not, included ddl for database * fix for get handler not starting, fixed broken tests * Incrementing version to 3.8.0 (#185) * Updating version to 3.8.0 * update version * updates for connection pool * added config and code change to allow for partitioning and test fix * version update * added updated config for prepare fulfil and get
rmothilal
pushed a commit
to rmothilal/central-ledger
that referenced
this pull request
Feb 5, 2019
* migrations by Georgi * migrations by Nikolay * Migrations by Nikolay (fix fsp to participant) * Migrations by Nikolay (fix the migration timestamp) * valentin's migrations * Renaming files with latest timestamps * Cleaning out old migration scripts * Migrations by Deon * cleaning up * Merging migration scripts 1 * Merging migration scripts 2 * Merging migration scripts 3 * Fixing migration scripts * Rename migrations to singular * renaming topic to event * Temporary disable Ledger account creation * Finalize CDM changes * transfers renamed * users -> party * fews -> few * before accounts * changed the currency table accordingly and seeded the currency codes * currencies with names added to seed script * trying to make it work * fixed permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and adding some additional info