Skip to content

Commit

Permalink
Feature/perf3.6 enhancements (#190)
Browse files Browse the repository at this point in the history
* #395 Added the SEED for endpointType (#142)

* Added the SEED for endpointType

* Removed unused seed

* Feature/461 Settlement Transfer (#150)

* Added account type and seeds
* Updated DDL and seeds for settlement transfers
* Added SETTLEMENT_NET_ZERO ledgerEntryType enum
* Changed seeds
* Server cached enums (3.1) and create both accounts (6)
* Fixed unit tests for the previous commit
* Change cache from 5 secs to 5 mins
* All references to participantCurrencyId point to the Position Account

* Incrementing central ledger version (#152)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Incrementing central-ledger version

* Bugfix/391 updating postman link in onboarding doc (#151)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information

* update code to remove transfer handler

* Feature/461 settlement transfer (#154)

Feature/461 Settlement Transfer - signed amounts

* fixes for the timeout

* Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149)

* validation for different FSPs added and tests are extended (#156)

* Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153)

* Added validation for negative values of NET_DEBIT_CAP

* fixed the unit tests, integration tests and updated the documentation

* changed order of enums

* added allow(0)

* testPI2 -> test (#158)

* testPI2 -> test

* removed old comments

* removed test from istanbul.yml

* updated code

* Fixed the listed occurrences of local timestamps (#157)

* Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160)

* Altered ParticipantFacade.adjustLimits to work with external trx
* Make commit & rollback conditional

* Story #397 cleanup of unused files (#161)

* removed caret from pacckage.json

* cleaned up unused files

* removed unused packages

* Bugfix/fix circleci build (#162)

* updated dockerfile for failing

* updated circle ci config

* removal of RUN reserved word

* Bugfix/api not starting 08 10 (#163)

* fixes for bug 471, 472, 469

* rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests

* logger.error
and capitalise the word no

* fixes for cleaning up central-ledger

* unit test for crypto.js

* Feature/cleaning unsured code (#164)

* fixes for bug 471, 472, 469

* rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests

* logger.error
and capitalise the word no

* fixes for cleaning up central-ledger

* unit test for crypto.js

* removal of unused and legacy code

* dependency for integration tests

* removal of unused code

* pre-commit added

* added coverage tests (#165)

Merging as requested by Shashi and since this is approved by Rajiv

* Story #397 cleanup and coverage tests (#167)

* added coverage tests

* Added coverage tests, removed unused code

* removed commented code

* Feature/perf3.6 enhancements (#169)

* fixes for bug 471, 472, 469

* rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests

* logger.error
and capitalise the word no

* update code to remove transfer handler

* fixes for the timeout

* Feature/perf3.6 enhancements (#155)

* #395 Added the SEED for endpointType (#142)

* Added the SEED for endpointType

* Removed unused seed

* Feature/461 Settlement Transfer (#150)

* Added account type and seeds
* Updated DDL and seeds for settlement transfers
* Added SETTLEMENT_NET_ZERO ledgerEntryType enum
* Changed seeds
* Server cached enums (3.1) and create both accounts (6)
* Fixed unit tests for the previous commit
* Change cache from 5 secs to 5 mins
* All references to participantCurrencyId point to the Position Account

* Incrementing central ledger version (#152)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Incrementing central-ledger version

* Bugfix/391 updating postman link in onboarding doc (#151)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information

* update code to remove transfer handler

* fixes for the timeout

* updated code

* Feature/perf3.6 enhancements (#159)

* #395 Added the SEED for endpointType (#142)

* Added the SEED for endpointType

* Removed unused seed

* Feature/461 Settlement Transfer (#150)

* Added account type and seeds
* Updated DDL and seeds for settlement transfers
* Added SETTLEMENT_NET_ZERO ledgerEntryType enum
* Changed seeds
* Server cached enums (3.1) and create both accounts (6)
* Fixed unit tests for the previous commit
* Change cache from 5 secs to 5 mins
* All references to participantCurrencyId point to the Position Account

* Incrementing central ledger version (#152)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Incrementing central-ledger version

* Bugfix/391 updating postman link in onboarding doc (#151)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information

* update code to remove transfer handler

* Feature/461 settlement transfer (#154)

Feature/461 Settlement Transfer - signed amounts

* fixes for the timeout

* Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149)

* validation for different FSPs added and tests are extended (#156)

* Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153)

* Added validation for negative values of NET_DEBIT_CAP

* fixed the unit tests, integration tests and updated the documentation

* changed order of enums

* added allow(0)

* testPI2 -> test (#158)

* testPI2 -> test

* removed old comments

* removed test from istanbul.yml

* updated code

* Fixed the listed occurrences of local timestamps (#157)

* Feature/perf3.6 enhancements (#168)

* #395 Added the SEED for endpointType (#142)

* Added the SEED for endpointType

* Removed unused seed

* Feature/461 Settlement Transfer (#150)

* Added account type and seeds
* Updated DDL and seeds for settlement transfers
* Added SETTLEMENT_NET_ZERO ledgerEntryType enum
* Changed seeds
* Server cached enums (3.1) and create both accounts (6)
* Fixed unit tests for the previous commit
* Change cache from 5 secs to 5 mins
* All references to participantCurrencyId point to the Position Account

* Incrementing central ledger version (#152)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Incrementing central-ledger version

* Bugfix/391 updating postman link in onboarding doc (#151)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information

* update code to remove transfer handler

* Feature/461 settlement transfer (#154)

Feature/461 Settlement Transfer - signed amounts

* fixes for the timeout

* Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149)

* validation for different FSPs added and tests are extended (#156)

* Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153)

* Added validation for negative values of NET_DEBIT_CAP

* fixed the unit tests, integration tests and updated the documentation

* changed order of enums

* added allow(0)

* testPI2 -> test (#158)

* testPI2 -> test

* removed old comments

* removed test from istanbul.yml

* updated code

* Fixed the listed occurrences of local timestamps (#157)

* Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160)

* Altered ParticipantFacade.adjustLimits to work with external trx
* Make commit & rollback conditional

* Story #397 cleanup of unused files (#161)

* removed caret from pacckage.json

* cleaned up unused files

* removed unused packages

* Bugfix/fix circleci build (#162)

* updated dockerfile for failing

* updated circle ci config

* removal of RUN reserved word

* Bugfix/api not starting 08 10 (#163)

* fixes for bug 471, 472, 469

* rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests

* logger.error
and capitalise the word no

* fixes for cleaning up central-ledger

* unit test for crypto.js

* Feature/cleaning unsured code (#164)

* fixes for bug 471, 472, 469

* rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests

* logger.error
and capitalise the word no

* fixes for cleaning up central-ledger

* unit test for crypto.js

* removal of unused and legacy code

* dependency for integration tests

* removal of unused code

* pre-commit added

* added coverage tests (#165)

Merging as requested by Shashi and since this is approved by Rajiv

* Story #397 cleanup and coverage tests (#167)

* added coverage tests

* Added coverage tests, removed unused code

* removed commented code

* fix for integration test

* Feature/perf3.6 enhancements (#172)

* fixes for bug 471, 472, 469

* rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests

* logger.error
and capitalise the word no

* update code to remove transfer handler

* fixes for the timeout

* Feature/perf3.6 enhancements (#155)

* #395 Added the SEED for endpointType (#142)

* Added the SEED for endpointType

* Removed unused seed

* Feature/461 Settlement Transfer (#150)

* Added account type and seeds
* Updated DDL and seeds for settlement transfers
* Added SETTLEMENT_NET_ZERO ledgerEntryType enum
* Changed seeds
* Server cached enums (3.1) and create both accounts (6)
* Fixed unit tests for the previous commit
* Change cache from 5 secs to 5 mins
* All references to participantCurrencyId point to the Position Account

* Incrementing central ledger version (#152)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Incrementing central-ledger version

* Bugfix/391 updating postman link in onboarding doc (#151)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information

* update code to remove transfer handler

* fixes for the timeout

* updated code

* Feature/perf3.6 enhancements (#159)

* #395 Added the SEED for endpointType (#142)

* Added the SEED for endpointType

* Removed unused seed

* Feature/461 Settlement Transfer (#150)

* Added account type and seeds
* Updated DDL and seeds for settlement transfers
* Added SETTLEMENT_NET_ZERO ledgerEntryType enum
* Changed seeds
* Server cached enums (3.1) and create both accounts (6)
* Fixed unit tests for the previous commit
* Change cache from 5 secs to 5 mins
* All references to participantCurrencyId point to the Position Account

* Incrementing central ledger version (#152)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Incrementing central-ledger version

* Bugfix/391 updating postman link in onboarding doc (#151)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information

* update code to remove transfer handler

* Feature/461 settlement transfer (#154)

Feature/461 Settlement Transfer - signed amounts

* fixes for the timeout

* Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149)

* validation for different FSPs added and tests are extended (#156)

* Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153)

* Added validation for negative values of NET_DEBIT_CAP

* fixed the unit tests, integration tests and updated the documentation

* changed order of enums

* added allow(0)

* testPI2 -> test (#158)

* testPI2 -> test

* removed old comments

* removed test from istanbul.yml

* updated code

* Fixed the listed occurrences of local timestamps (#157)

* Feature/perf3.6 enhancements (#168)

* #395 Added the SEED for endpointType (#142)

* Added the SEED for endpointType

* Removed unused seed

* Feature/461 Settlement Transfer (#150)

* Added account type and seeds
* Updated DDL and seeds for settlement transfers
* Added SETTLEMENT_NET_ZERO ledgerEntryType enum
* Changed seeds
* Server cached enums (3.1) and create both accounts (6)
* Fixed unit tests for the previous commit
* Change cache from 5 secs to 5 mins
* All references to participantCurrencyId point to the Position Account

* Incrementing central ledger version (#152)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Incrementing central-ledger version

* Bugfix/391 updating postman link in onboarding doc (#151)

* Incrementing version to 3.6.1-snapshot

* Updating versions for central-services-shared, central-services-database libraries

* Updating the steps in On-boarding document to use the correct postman collection and also some additional steps, information

* update code to remove transfer handler

* Feature/461 settlement transfer (#154)

Feature/461 Settlement Transfer - signed amounts

* fixes for the timeout

* Updated populateTestData script to set endPoint Callback URLs for each Participant, and removed instructions from the restartMockServer.sh to configure the EndPoints in the ML-API-Adapter config which is no longer necessary. (#149)

* validation for different FSPs added and tests are extended (#156)

* Story #484 - Added validation for negative values of NET_DEBIT_CAP (#153)

* Added validation for negative values of NET_DEBIT_CAP

* fixed the unit tests, integration tests and updated the documentation

* changed order of enums

* added allow(0)

* testPI2 -> test (#158)

* testPI2 -> test

* removed old comments

* removed test from istanbul.yml

* updated code

* Fixed the listed occurrences of local timestamps (#157)

* Feature/461 Settlement Transfer - ParticipantFacade.adjustLimits (#160)

* Altered ParticipantFacade.adjustLimits to work with external trx
* Make commit & rollback conditional

* Story #397 cleanup of unused files (#161)

* removed caret from pacckage.json

* cleaned up unused files

* removed unused packages

* Bugfix/fix circleci build (#162)

* updated dockerfile for failing

* updated circle ci config

* removal of RUN reserved word

* Bugfix/api not starting 08 10 (#163)

* fixes for bug 471, 472, 469

* rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests

* logger.error
and capitalise the word no

* fixes for cleaning up central-ledger

* unit test for crypto.js

* Feature/cleaning unsured code (#164)

* fixes for bug 471, 472, 469

* rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests

* logger.error
and capitalise the word no

* fixes for cleaning up central-ledger

* unit test for crypto.js

* removal of unused and legacy code

* dependency for integration tests

* removal of unused code

* pre-commit added

* added coverage tests (#165)

Merging as requested by Shashi and since this is approved by Rajiv

* Story #397 cleanup and coverage tests (#167)

* added coverage tests

* Added coverage tests, removed unused code

* removed commented code

* fix for integration test

* Feature/509 Participant Accounts Endpoint (#170)

* Added initial position for settlement account, added accounts endpoint
* Added unit tests for newly introduced code

* Feature/425 Timeout Handler Tests (#171)

* unit/coverage tests for timeout handler
* Unit tests and coverage for timeoutHandler and transferTimeoutModel

* Fixed integration tests teardown test (#173)

* refactor code to commit message to kafka after all processing is completed, fulfil, prepare, positions and fixed tests

* Feature/#452 add get on/transfers/{id} (#176)

* Added backend code for story #452 - get transfers by Id

* Change default.json back to default

* bug fix

* Added unit test(Pos and neg) for register transfer handler

* Added more unit tests to increase code coverage for Transfer handler

* Add Unit tests and increase code coverage

* updated version number

* Increment version (#179)

* Incrementing version for MVP release to 3.7.4

* added pool to kenex file to manage the number of connections available

* do not insert into participantPositionChange when transfer is aborted (#180)

* revert changes for #487 (#182)

* do not insert into participantPositionChange when transfer is aborted

* revert changes for #487

* revert changes for #487

* Feature/run migrations config (#183)

* fixes for bug 471, 472, 469

* rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests

* logger.error
and capitalise the word no

* updated code to control if migrations run or not, included ddl for database

* Feature/run migrations config (#184)

* fixes for bug 471, 472, 469

* rework to still throw error for missing topic and handle appropriately as well as getting topic from incoming message and not creating it from the fsp. reverted state to invalid for validation errors on prepare. fixed corresponding tests

* logger.error
and capitalise the word no

* updated code to control if migrations run or not, included ddl for database

* fix for get handler not starting, fixed broken tests

* Incrementing version to 3.8.0 (#185)

* Updating version to 3.8.0

* update version

* updates for connection pool

* added config and code change to allow for partitioning and test fix

* version update

* added updated config for prepare fulfil and get
  • Loading branch information
rmothilal authored Oct 25, 2018
1 parent 707ef06 commit d57194a
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
12 changes: 8 additions & 4 deletions config/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
"broker.version.fallback": "0.10.1.0",
"api.version.request": true,
"enable.auto.commit": false,
"auto.commit.interval.ms": 200
"auto.commit.interval.ms": 200,
"partition.assignment.strategy": "range"
},
"topicConf": {
"auto.offset.reset": "earliest"
Expand Down Expand Up @@ -101,7 +102,8 @@
"broker.version.fallback": "0.10.1.0",
"api.version.request": true,
"enable.auto.commit": false,
"auto.commit.interval.ms": 200
"auto.commit.interval.ms": 200,
"partition.assignment.strategy": "range"
},
"topicConf": {
"auto.offset.reset": "earliest"
Expand Down Expand Up @@ -132,7 +134,8 @@
"broker.version.fallback": "0.10.1.0",
"api.version.request": true,
"enable.auto.commit": false,
"auto.commit.interval.ms": 200
"auto.commit.interval.ms": 200,
"partition.assignment.strategy": "range"
},
"topicConf": {
"auto.offset.reset": "earliest"
Expand Down Expand Up @@ -437,7 +440,8 @@
"socket.blocking.max.ms": 1,
"queue.buffering.max.ms": 1,
"broker.version.fallback": "0.10.1.0",
"api.version.request": true
"api.version.request": true,
"partitioner": "random"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mojaloop/central-ledger",
"version": "3.7.5-snapshot",
"version": "3.7.6-snapshot",
"description": "Central ledger hosted by a scheme to record and settle transfers.",
"license": "Apache-2.0",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/lib/utility.js
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ const createParticipantTopicConf = (participantName, functionality, action, part
*
* @returns {object} - Returns newly created general topicConfig
*/
const createGeneralTopicConf = (functionality, action, partition = 0, opaqueKey = 0) => {
const createGeneralTopicConf = (functionality, action, partition = null, opaqueKey = 0) => {
return {
topicName: transformGeneralTopicName(functionality, action),
key: Uuid(),
Expand Down
2 changes: 1 addition & 1 deletion test/unit/handlers/lib/utility.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ Test('Utility Test', utilityTest => {
createGeneralTopicConfTest.test('return a general topic conf object', test => {
const response = Utility.createGeneralTopicConf(TRANSFER, FULFIL)
test.equal(response.topicName, generalTopic)
test.equal(response.partition, 0)
test.equal(response.partition, null)
test.equal(response.opaqueKey, 0)
test.end()
})
Expand Down

0 comments on commit d57194a

Please sign in to comment.