Skip to content

Commit

Permalink
refactor: Clean up golden-layout css (deephaven#1322)
Browse files Browse the repository at this point in the history
We maintain our golden-layout package, bake our theme customizations
directly into the dark theme. Eliminates some css. Used e2e testing to
prevent visual regressions, the two changes showing are intentional.

Had to exclude the ThemeExport from the karma tests, it didn't like the
scss import.

---------

Co-authored-by: Mike Bender <mikebender@deephaven.io>
  • Loading branch information
dsmmcken and mofojed authored May 29, 2023
1 parent 99818a8 commit d1838d7
Show file tree
Hide file tree
Showing 23 changed files with 320 additions and 483 deletions.
2 changes: 2 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion packages/dashboard/src/PanelPlaceholder.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@
display: flex;
flex-direction: column;
justify-content: center;
padding: $spacer-3;
min-height: 100%;
max-height: 100%;
text-align: center;
overflow: hidden;

// add padding on an inner wrapper so it is included in max height of parent
div {
padding: $spacer-3;
}
}
2 changes: 1 addition & 1 deletion packages/dashboard/src/PanelPlaceholder.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const PanelPlaceholder = React.forwardRef(
const component = LayoutUtils.getComponentNameFromPanel({ props });
return (
<div ref={ref} className="panel-placeholder">
Component &quot;{component}&quot; is not registered.
<div>Component &quot;{component}&quot; is not registered.</div>
</div>
);
}
Expand Down
9 changes: 0 additions & 9 deletions packages/dashboard/src/layout/GoldenLayout.module.scss

This file was deleted.

Loading

0 comments on commit d1838d7

Please sign in to comment.