Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clean up golden-layout css #1322

Merged
merged 12 commits into from
May 29, 2023
Merged

refactor: Clean up golden-layout css #1322

merged 12 commits into from
May 29, 2023

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented May 25, 2023

We maintain our golden-layout package, bake our theme customizations directly into the dark theme. Eliminates some css. Used e2e testing to prevent visual regressions, the two changes showing are intentional.

Had to exclude the ThemeExport from the karma tests, it didn't like the scss import.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1322 (7bc888a) into main (485c7cc) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
- Coverage   45.95%   45.94%   -0.01%     
==========================================
  Files         493      493              
  Lines       34404    34410       +6     
  Branches     8580     8581       +1     
==========================================
  Hits        15811    15811              
- Misses      18542    18548       +6     
  Partials       51       51              
Flag Coverage Δ
unit 45.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/dashboard/src/PanelPlaceholder.tsx 40.00% <ø> (ø)
packages/dashboard/src/layout/LayoutUtils.ts 13.94% <0.00%> (ø)

... and 1 file with indirect coverage changes

@dsmmcken dsmmcken requested a review from mofojed May 25, 2023 17:52
packages/dashboard/src/PanelPlaceholder.scss Outdated Show resolved Hide resolved
packages/golden-layout/karma.conf.cjs Show resolved Hide resolved
packages/golden-layout/package.json Show resolved Hide resolved
Co-authored-by: Mike Bender <mikebender@deephaven.io>
@dsmmcken dsmmcken requested a review from mofojed May 29, 2023 13:55
@dsmmcken dsmmcken merged commit d1838d7 into main May 29, 2023
@dsmmcken dsmmcken deleted the dmckenzie_refactor_gl_css branch May 29, 2023 19:22
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants