-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(enhanced): ProvideSharedPlugin loader layer support #3334
Conversation
|
76d840b
to
8c0fb76
Compare
8c0fb76
to
03cc046
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
The core changes in this pull request focus on enhancing the shared module consumption and provisioning functionality in the packages/enhanced
library. The key improvements include:
- Adding support for a new
layer
property in theProvideSharedDependency
,ProvideSharedModule
, andProvideSharedPlugin
classes. This allows for better organization and management of shared modules by providing an additional context layer. - Updating the handling of configuration options, such as incorporating the
layer
property into module identifiers and serialization. This ensures that the additional context is properly captured and utilized. - Modifying the schema validation for
ProvideOptions
to include the newlayer
andrequest
properties, enforcing the enhanced functionality.
These changes aim to improve the overall flexibility and control over the provisioning and consumption of shared dependencies within the packages/enhanced
library. The updates to the various sharing-related classes and the schema validation help to provide a more robust and extensible shared module management system.
File Summaries
File | Summary |
---|---|
packages/enhanced/src/declarations/plugins/sharing/ProvideSharedPlugin.d.ts | The code changes in this pull request focus on enhancing the shared module consumption and provisioning functionality in the packages/enhanced library. The primary changes include: |
-
Adding support for a new
layer
property in theProvideSharedDependency
,ProvideSharedModule
, andProvideSharedPlugin
classes, allowing for better organization and management of shared modules. -
Improving the handling of configuration options, such as incorporating the
layer
property into module identifiers and serialization, to ensure that the additional context is properly captured and utilized. -
Updating the schema validation for
ProvideOptions
to include the newlayer
andrequest
properties, ensuring that the enhanced functionality is properly validated and enforced. |
| packages/enhanced/src/lib/sharing/ConsumeSharedModule.ts | The code changes introduce several enhancements to the shared module consumption and provisioning in thepackages/enhanced
library. The primary changes include adding support for a newlayer
property and improving the handling of configuration options across various classes, such asProvideSharedDependency
,ProvideSharedModule
, andProvideSharedPlugin
. These changes ensure that thelayer
information is properly incorporated into module identifiers, serialization, and the overall plugin logic, enabling more granular control and management of shared module dependencies. |
| packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts | The code changes in this pull request focus on enhancing the shared module consumption and provisioning functionality in thepackages/enhanced
library. The primary changes include: -
Adding support for a new
layer
property in theProvideSharedDependency
,ProvideSharedModule
, andProvideSharedPlugin
classes, ensuring that thelayer
information is included in identifiers and serialization. -
Updating the
ConsumeSharedPlugin
class to handle the newlayer
property in thecontextInfo
object when creating lookup keys. -
Modifying the schema validation for
ProvideOptions
to include the newlayer
andrequest
properties.
These changes aim to improve the handling of shared module configurations and provide more flexibility in managing the provisioning and consumption of shared dependencies. |
| packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts | The code changes in this pull request focus on enhancing the shared module consumption and provisioning in the packages/enhanced
library. The key modifications include:
- Adding support for a new
layer
property in theProvideSharedDependency
andProvideSharedModule
classes, ensuring that layer information is included in module identifiers and serialization. - Updating the
ProvideSharedPlugin
class to handle thelayer
property inProvideOptions
and incorporating it into the plugin's logic for creating lookup keys and resolving module configurations. - Modifying the schema validation in
ProviderSharedPlugin.check.ts
to include the newlayer
andrequest
properties forProvideOptions
.
These changes aim to improve the handling of shared module configurations and provide more flexibility in managing module dependencies across different layers or contexts within the application. |
| packages/enhanced/src/lib/sharing/ProvideSharedModule.ts | The code changes in this pull request focus on enhancing the shared module consumption and provisioning functionality in the packages/enhanced
library. The key modifications include:
- Adding support for a new
layer
property in theProvideSharedDependency
andProvideSharedModule
classes, which allows for better handling of module identifiers and serialization when dealing with shared dependencies. - Updating the
ProvideSharedPlugin
class to incorporate thelayer
property in theProvideOptions
and modifying the plugin logic to handle thelayer
information when creating lookup keys and resolving module configurations. - Modifying the schema validation in
ProviderSharedPlugin.check.ts
to include the newlayer
andrequest
properties forProvideOptions
.
These changes aim to improve the overall functionality and flexibility of the shared module management system in the packages/enhanced
library. |
| packages/enhanced/src/lib/sharing/ProvideSharedPlugin.ts | The code changes in this pull request introduce several enhancements to the shared module consumption and provisioning in the packages/enhanced
library. The primary changes include adding support for a new layer
property and improving the handling of configuration options in the ProvideSharedPlugin
class.
The key modifications are:
-
Updating the
createLookupKey
function to handle the newlayer
property incontextInfo
. -
Adding the
layer
property to theProvideSharedDependency
class and updating its methods to includelayer
information in identifiers and serialization. -
Incorporating the
layer
property into theProvideSharedModule
class and its methods, ensuring thatlayer
information is included in module identifiers and serialization. -
Enhancing the
ProvideSharedPlugin
class to support thelayer
property inProvideOptions
and updating the plugin logic to handle thelayer
information when creating lookup keys and resolving module configurations. -
Modifying the schema validation to include the new
layer
andrequest
properties forProvideOptions
. |
| packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.check.ts | The code changes in this pull request focus on enhancing the shared module consumption and provisioning in thepackages/enhanced
library. The key modifications include: -
Adding support for a new
layer
property in theProvideSharedDependency
,ProvideSharedModule
, andProvideSharedPlugin
classes, ensuring that layer information is included in identifiers and serialization. -
Updating the
ProvideSharedPlugin
class to handle thelayer
property inProvideOptions
and incorporate it into the plugin's logic for creating lookup keys and resolving module configurations. -
Modifying the schema validation in
ProviderSharedPlugin.check.ts
to include the newlayer
andrequest
properties forProvideOptions
.
These changes aim to enhance the shared module consumption and provisioning functionality in the packages/enhanced
library, providing more flexibility and control over the handling of shared dependencies. |
| packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts | The code changes in this pull request focus on enhancing the shared module consumption and provisioning functionality in the packages/enhanced
library. The key modifications include:
- Adding support for a new
layer
property in theProvideSharedDependency
,ProvideSharedModule
, andProvideSharedPlugin
classes, ensuring that module identifiers and serialization include the layer information. - Updating the
ProvideSharedPlugin
class to handle thelayer
property inProvideOptions
and incorporate it into the plugin's logic for creating lookup keys and resolving module configurations. - Modifying the schema validation in
ProviderSharedPlugin.check.ts
to include the newlayer
andrequest
properties forProvideOptions
.
These changes aim to enhance the flexibility and functionality of the shared module provisioning system, allowing for more granular control and organization of shared dependencies within the packages/enhanced
library. |
| packages/enhanced/test/configCases/sharing/layers-provides-loader/src/index.js | This pull request introduces several enhancements to the shared module consumption and provisioning in the packages/enhanced
library. The primary changes include adding support for a new layer
property and improving the handling of configuration options across various classes and modules related to shared module management. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incremental Review
Comments posted: 16
Configuration
Squadron Mode: essential
Commits Reviewed
6f8f45e1449d45512085f9cf1a89fd6ee3662c27...dd18cb225ad4e432e308981e13ce7f7f2f288e00
Files Reviewed
- packages/enhanced/src/declarations/plugins/sharing/ProvideSharedPlugin.d.ts
- packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts
- packages/enhanced/src/lib/sharing/ProvideSharedModule.ts
- packages/enhanced/src/lib/sharing/ProvideSharedPlugin.ts
- packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.check.ts
- packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts
- packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/shy-snails-battle.md
- packages/enhanced/test/configCases/sharing/layers-provides-loader/.gitignore
- packages/enhanced/test/configCases/sharing/layers-provides-loader/loaders/different-layer-loader.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/loaders/explicit-layer-loader.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/loaders/multi-pkg-layer-loader.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/loaders/react-layer-loader.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/node_modules/lib2/index.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/node_modules/multi-pkg/thing1.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/node_modules/multi-pkg/thing2.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/node_modules/react/index.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/node_modules/react/index2.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/package.json
- packages/enhanced/test/configCases/sharing/layers-provides-loader/shared/react-boundary.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/test.config.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/tests/different-layers.test.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/tests/lib-two.test.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/tests/prefixed-share.test.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/tests/unlayered-share.test.js
- packages/enhanced/test/configCases/sharing/layers-provides-loader/webpack.config.js
Description
This pull request introduces several enhancements to the shared module consumption and provisioning in the
packages/enhanced
library. The primary changes include adding support for a newlayer
property and improving the handling of configuration options.Enhancements to shared module consumption and provisioning:
packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts
: Updated thecreateLookupKey
function to handle the newlayer
property incontextInfo
.packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts
: Added thelayer
property to theProvideSharedDependency
class and updated its methods to includelayer
information in identifiers and serialization. [1] [2] [3] [4] [5] [6] [7]packages/enhanced/src/lib/sharing/ProvideSharedModule.ts
: Incorporated thelayer
property into theProvideSharedModule
class and its methods, ensuring thatlayer
information is included in module identifiers and serialization. [1] [2] [3] [4] [5] [6] [7] [8] [9]packages/enhanced/src/lib/sharing/ProvideSharedPlugin.ts
: Enhanced theProvideSharedPlugin
class to support thelayer
property inProvideOptions
and updated the plugin logic to handle thelayer
information when creating lookup keys and resolving module configurations. [1] [2] [3] [4] [5] [6] [7] [8]packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.check.ts
: Modified the schema validation to include the newlayer
andrequest
properties forProvideOptions
. [1] [2]Related Issue
Types of changes
Checklist