chore: address lint warnings

module-federation · Dec 10, 2024 · dd18cb2 · dd18cb2
1 parent fee2946
commit dd18cb2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts b/packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts
@@ -317,7 +317,6 @@ class ConsumeSharedPlugin {
           async (resolveData: ResolveData): Promise<Module | undefined> => {
             const { context, request, dependencies, contextInfo } = resolveData;
             // wait for resolving to be complete
-            //@ts-ignore
             return promise.then(() => {
               if (
                 dependencies[0] instanceof ConsumeSharedFallbackDependency ||
@@ -345,6 +344,7 @@ class ConsumeSharedPlugin {
                   });
                 }
               }
+              return;
             });
           },
         );

diff --git a/packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts b/packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts
@@ -110,7 +110,7 @@ class ProvideSharedDependency extends Dependency {
       read(),
       read(),
     );
-    //@ts-ignore
+    // @ts-expect-error - webpack serializer pattern requires static property
     this.shareScope = context.read();
     obj.deserialize(context);
     return obj;

diff --git a/packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts b/packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts
@@ -1,4 +1,3 @@
-//@ts-nocheck
 export default {
   definitions: {
     Provides: {