Upgrade some packages to deal with security issue seen from npm audit #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
outsideris
reviewed
Aug 20, 2018
There was a problem hiding this comment.
Thank you for your contributions.
However, upgrading packages are better just before new release because security issues in master branch are not critical.
Also, assetgraph-builder has a performance issue, see #3412 .
|
@papandreou, believe 26 of these are related to AG-B. |
|
@plroebuck, I'll take a look. There are still some vulnerabilities left with the latest ag-b. Some of them appear to be buried many levels deep, so it could take some time to get it all sorted out. I've installed depfu in those of the intermediate repos that are within my control, let's see :) |
|
Tracking the progress here: assetgraph/assetgraph-builder#628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
No.
Description of the Change
'npm audit' found critical security issues. Package upgrade resolves some of these issues.
Alternate Designs
Refer to npm audit to fix security issues.
Why should this be in core?
Critical security issue maybe resolved.
Benefits
Critical security issue maybe resolved.
Possible Drawbacks
Tested on Debian 10, so far it's ok. Not tested on windows or other platform yet.
Applicable issues
There are still 25 vulnerabilities to be reviewed.
found 25 vulnerabilities (1 low, 24 moderate) in 32373 scanned packages
25 vulnerabilities require manual review. See the full report for details.