upgrade assetgraph-builder with fixes

[boneskull]

from @papandreou

[jsf-clabot]

All committers have signed the CLA.

[papandreou]

@boneskull, I tried to update the lockfile, but it produces a huge number of changes: papandreou@17ebed1

I used npm@5.6.0 to update it -- do you remember which version the lockfile was generated with? Maybe it'll help if I use that.

[outsideris]

I didn't know assetgraph well.

docs/_site/index.html is fine, but there is a broken link indocs/_dist/index.html.

undefined-1.d41d8cd98f can be found in build result like:

       Html 74   1.7 MB
        Ico  2  29.5 KB
.d41d8cd98f  2     0 bytes
        Png  8 225.0 KB
        Svg  2   7.3 KB
        Css  5  50.9 KB
 JavaScript  4  24.0 KB
     Total: 97   2.0 MB

[outsideris]

Additioanally, buildProduction took much longer than before this PR in my local.

before:

 ✔ 0.006 secs: reviewSubResourceIntegrity
 ✔ 47.618 secs: buildProduction
 ✔ 1.595 secs: writeAssetsToDisc

after:

 ✔ 2.965 secs: reviewSubResourceIntegrity
 ✔ 307.252 secs: buildProduction
 ✔ 2.071 secs: writeAssetsToDisc

[outsideris]

I didn't test it with @papandreou 's commit.

[papandreou]

@outsideris, thanks, will look into the undefined thing.

I'm aware that it's still slower than ag-b 5. I will get around to trace down the remaining performance regressions.

[papandreou]

I've fixed the problem with the bogus undefined-1.d41d8cd98f file now.

Will get back to the performance regressions at some point. If you find it too slow, you're welcome to just keep this open and wait.

[outsideris]

I confirmed undefined-1.d41d8cd98f is fixed.

However, it doesn't make static directory at all. So, every references under static/ are broken.

[papandreou]

@outsideris, you're right, I can reproduce that. It's a problem with the --canonicalroot switch. Looking into it.

[papandreou]

@outsideris, fixed now. Thanks for letting me know.

[outsideris]

CI is failed.

npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
npm ERR! 
npm ERR! Invalid: lock file's assetgraph-builder@5.9.1 does not satisfy assetgraph-builder@^6.3.4
npm ERR! Invalid: lock file's svgo@0.7.2 does not satisfy svgo@^1.0.5

[papandreou]

@outsideris, I also ran into that and commented: #3412 (comment)

[outsideris]

@papandreou I missed that comment.
The precache job ran under node v10, so npm version is 6.1.0.

You can see it in the job logs.

$ npm --version
6.1.0

In my local, npm ci --ignore-scripts is works with npm@6.1.0.

[papandreou]

@outsideris, ah, thanks. I've updated package-lock.json now by running a fresh npm install with npm 6.1.0.

Still seems like an awful lot of changes, though.

[coveralls]

Coverage increased (+0.3%) to 90.289% when pulling 811f9bc on papandreou:fix/ag-b into eeccd05 on mochajs:master.

[papandreou]

Improved the performance further in assetgraph-builder 6.4.1, here's the current build time on my laptop:

 ✔ 117.447 secs: buildProduction

Edit: And when connected to power and no world cup matches streaming in the background:

 ✔ 82.750 secs: buildProduction

[outsideris]

In my local, it still slow:

 ✔ 3.298 secs: reviewSubResourceIntegrity
 ✔ 301.102 secs: buildProduction
 ✔ 2.478 secs: writeAssetsToDisc

But netify build is ok.

[papandreou]

@outsideris, weird that it didn't improve more on your machine. I can't explain that.

[outsideris]

@papandreou I tried it multiple time that delete node_modules and reinstall it. I will try to find the solution if I have time.

[papandreou]

@outsideris, thanks for trying. I guess that just means I'm not done yet ;)

[plroebuck]

@Munter, self-assign this one.

[plroebuck]

@papandreou, any status update on where this stands?

[papandreou]

I haven't really been able to allocate time to do more profiling specifically targeting this particular build, sorry. Please consider using another build tool.

[plroebuck]

Assuming actual time is closer to what you see (than Outsider), my question was to see if there were any other related bugs to shake out?

[papandreou]

I'm not aware of any other issues, no.

[boneskull]

I'm going to close this and retry with the latest version.