util: add binfmt_misc binary detection #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborvass
reviewed
Feb 27, 2019
tiborvass
reviewed
Feb 27, 2019
|
Looks good overall, but didn't test |
tonistiigi
force-pushed
the
qemu-detection
branch
2 times, most recently
from
e239db7 to
fec983c
Compare
tiborvass
reviewed
Feb 27, 2019
tonistiigi
force-pushed
the
qemu-detection
branch
3 times, most recently
from
7d41a90 to
28b5d4a
Compare
AkihiroSuda
reviewed
Feb 28, 2019
| defer f.Close() | ||
| buf := &bytes.Buffer{} | ||
|
|
||
| gz, err := gzip.NewWriterLevel(newHexStringWriter(buf), gzip.BestCompression) |
There was a problem hiding this comment.
It saves a little bit in binary size. They seem to compress quite well.
AkihiroSuda
reviewed
Feb 28, 2019
tonistiigi
force-pushed
the
qemu-detection
branch
from
28b5d4a to
611f78c
Compare
ijc
reviewed
Feb 28, 2019
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
qemu-detection
branch
from
611f78c to
fb73a92
Compare
AkihiroSuda
approved these changes
Mar 1, 2019
ijc
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AkihiroSuda @tiborvass
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com