Add platform flag to build #217
Conversation
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 14 14
Lines 777 782 +5
=====================================
- Misses 777 782 +5
Continue to review full report at Codecov.
|
|
@tonistiigi PTAL? |
|
Using any platform from request as a supported one in the controller seems to counter buildkit design of preventing user from doing wrong things. If the use case for that part is to use qemu(and there is no good other place to put it) then we could do quite a lot with autodetection. Might want to change the flag to stringslice as well (or support both). |
|
The intended use case is for qemu and binfmt yes. How would such autodetection be done? I wanted to ask that in the pr message but forgot. Checking all registered formats for binfmt at |
|
Thanks. Will integrate once merged and released. |
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
|
@AkihiroSuda @tonistiigi PTAL |
|
looks good, but needs |
|
now it's vendored |
|
thanks!!! |
with the introduction of the `platform` flag to `img`, we're now able to set what's the base platform that the images that we `FROM` should use. (see genuinetools/img#217) this allows one that has `FROM ubuntu:bionic` to use an armv7-based base image when running with `--platform=arm`, and an arm64 when using `--platform=arm64`. Signed-off-by: Ciro S. Costa <cscosta@pivotal.io>
Adds the platform flag to build which allows building multiarch images by passing a comma separated list of platforms to it.