Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Streamline ICA reporting #899

Merged
merged 10 commits into from
Apr 16, 2024
Merged

ENH: Streamline ICA reporting #899

merged 10 commits into from
Apr 16, 2024

Conversation

larsoner
Copy link
Member

Before merging …

  • Changelog has been updated (docs/source/changes.md)
  1. Moved all ICA reports to the main report:

    image

  2. Added docs suggesting manual intervention is required (maybe it should be suggested instead?) when using ICA to take care of the doc part of BUG: ICA unsafely overwrites components tsv file #881

  3. Add just one subject's data for ERP_CORE (plus the average) to the website to cut size down.

  4. Add script to remove examples from old versions so we don't have to remove their docs anymore (they go down to like 6MB or something!).

Closes #880

@larsoner
Copy link
Member Author

@SophieHerbst
Copy link
Collaborator

@larsoner the report looks good to me!
Do I understand correctly that there is only one single report now?

@larsoner
Copy link
Member Author

Yep!

@hoechenberger
Copy link
Member

Is this good to go? are you waiting for my review?

@larsoner
Copy link
Member Author

Yeah this one is ready to go!

@hoechenberger
Copy link
Member

If it's not super urgent, please allow me to review first before merging

I won't have time before later tonight or maybe even tomorrow, though

@larsoner
Copy link
Member Author

larsoner commented Apr 1, 2024

@hoechenberger just a friendly reminder about this one when you get a chance!

@hoechenberger
Copy link
Member

I won't have time to review it before the end of this week. If this is rather urgent, go ahead and merge and we'll do a follow-up PR if need be

@larsoner
Copy link
Member Author

I'll fix the conflict here and merge, happy to do a follow-up PR if needed though @hoechenberger !

@hoechenberger
Copy link
Member

ok with me, sorry for the delay here

* upstream/main:
  change default for info to use for inverse mne-tools#905 (mne-tools#919)
  Improve documentation and config validation of `loose` and `depth` parameters; drop support for `loose=None` (mne-tools#915)
  enhance documentation of caching, continuation of mne-tools#914 (mne-tools#918)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#917)
  Restructure configuration options documentation sections (mne-tools#914)
  Try to fix documentation deployment (mne-tools#913)
  Do not show `Annotated` types in configuration options documentation (mne-tools#911)
  Add number of subjects to grand-average report (cont'd) (mne-tools#910)
  MAINT: Ensure input changes cause output changes (mne-tools#904)
  Render type annotations in the documentation again (mne-tools#909)
@larsoner larsoner enabled auto-merge (squash) April 16, 2024 19:23
@larsoner
Copy link
Member Author

Added a workaround for joblib/joblib#1572

@larsoner larsoner merged commit 856dfe2 into mne-tools:main Apr 16, 2024
51 of 52 checks passed
@larsoner larsoner deleted the ica branch April 16, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align report sections with pipeline steps
3 participants