-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Streamline ICA reporting #899
Conversation
@SophieHerbst can you look to see if the unified report titles and contents seem reasonable to you? Here is an example |
@larsoner the report looks good to me! |
Yep! |
Is this good to go? are you waiting for my review? |
Yeah this one is ready to go! |
If it's not super urgent, please allow me to review first before merging I won't have time before later tonight or maybe even tomorrow, though |
@hoechenberger just a friendly reminder about this one when you get a chance! |
I won't have time to review it before the end of this week. If this is rather urgent, go ahead and merge and we'll do a follow-up PR if need be |
I'll fix the conflict here and merge, happy to do a follow-up PR if needed though @hoechenberger ! |
ok with me, sorry for the delay here |
* upstream/main: change default for info to use for inverse mne-tools#905 (mne-tools#919) Improve documentation and config validation of `loose` and `depth` parameters; drop support for `loose=None` (mne-tools#915) enhance documentation of caching, continuation of mne-tools#914 (mne-tools#918) [pre-commit.ci] pre-commit autoupdate (mne-tools#917) Restructure configuration options documentation sections (mne-tools#914) Try to fix documentation deployment (mne-tools#913) Do not show `Annotated` types in configuration options documentation (mne-tools#911) Add number of subjects to grand-average report (cont'd) (mne-tools#910) MAINT: Ensure input changes cause output changes (mne-tools#904) Render type annotations in the documentation again (mne-tools#909)
Added a workaround for joblib/joblib#1572 |
Before merging …
docs/source/changes.md
)Moved all ICA reports to the main report:
Added docs suggesting manual intervention is required (maybe it should be suggested instead?) when using ICA to take care of the doc part of BUG: ICA unsafely overwrites components tsv file #881
Add just one subject's data for
ERP_CORE
(plus the average) to the website to cut size down.Add script to remove examples from old versions so we don't have to remove their docs anymore (they go down to like 6MB or something!).
Closes #880