change default for info to use for inverse #905 #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
larsoner
reviewed
Apr 2, 2024
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
larsoner
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Marking for merge-when-green, thanks in advance @SophieHerbst !
larsoner
added a commit
to larsoner/mne-bids-pipeline
that referenced
this pull request
Apr 16, 2024
* upstream/main: change default for info to use for inverse mne-tools#905 (mne-tools#919) Improve documentation and config validation of `loose` and `depth` parameters; drop support for `loose=None` (mne-tools#915) enhance documentation of caching, continuation of mne-tools#914 (mne-tools#918) [pre-commit.ci] pre-commit autoupdate (mne-tools#917) Restructure configuration options documentation sections (mne-tools#914) Try to fix documentation deployment (mne-tools#913) Do not show `Annotated` types in configuration options documentation (mne-tools#911) Add number of subjects to grand-average report (cont'd) (mne-tools#910) MAINT: Ensure input changes cause output changes (mne-tools#904) Render type annotations in the documentation again (mne-tools#909)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default for info given to 05_make_inverse.py (and for consistency 04_make_forward.py):
If set to
None(default), the info will be retrieved either from the rawfile specified in
noise_cov, or the cleaned epochs (ifnoise_covis None orad-hoc).Closes #905