Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unity simulator and interactive graph for Rocket Injector notebook. #171

Merged
merged 7 commits into from
Aug 6, 2021
Merged

Add Unity simulator and interactive graph for Rocket Injector notebook. #171

merged 7 commits into from
Aug 6, 2021

Conversation

jonpsy
Copy link
Member

@jonpsy jonpsy commented Jul 23, 2021 •
edited
Loading

Continuing #165

Simulator repository: https://github.com/FieryBlade-313/BusterinGaaz

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

zoq
zoq reviewed Jul 23, 2021
View reviewed changes
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited for this.

@jonpsy jonpsy changed the title Render 3D Interactive Pareto Front in Rocket Injector Design Add Unity simulator and interactive graph for Rocket Injector notebook. Jul 27, 2021
@jonpsy
Copy link
Member Author

jonpsy commented Jul 27, 2021

Thanks again @FieryBlade-313!

@jonpsy
Copy link
Member Author

jonpsy commented Jul 27, 2021

My writing's a little off, if guys could suggest some changes (or other suggestions) @zoq @say4n @coatless

@zoq
Copy link
Member

zoq commented Jul 27, 2021

My writing's a little off, if guys could suggest some changes (or other suggestions) @zoq @say4n @coatless

Ryan left some comments on your blog post, I guess some things we should incoperate here as well. Other than that I think this is good.

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

say4n commented on 2021-07-28T17:20:44Z
----------------------------------------------------------------

Looks good to me!

I was wondering if we could have a mesh plot in addition to the scatter plot for the Pareto front (maybe in the same plot as above).

Not necessary at all, just a suggestion. :)

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

say4n commented on 2021-07-28T17:20:45Z
----------------------------------------------------------------

Super cool! 🚀

@jonpsy
Copy link
Member Author

jonpsy commented Aug 3, 2021 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

say4n commented on 2021-07-28T17:20:44Z

Looks good to me!

I was wondering if we could have a mesh plot in addition to the scatter plot for the Pareto front (maybe in the same plot as above).

Not necessary at all, just a suggestion. :)

Easy peasy. Removed Scatter3d.

image

@jonpsy
+ Apply Ryan's writing suggestions
7451715 
+ Meshplot
-  Scatter3d
@jonpsy
Copy link
Member Author

jonpsy commented Aug 3, 2021

My writing's a little off, if guys could suggest some changes (or other suggestions) @zoq @say4n @coatless

Ryan left some comments on your blog post, I guess some things we should incoperate here as well. Other than that I think this is good.

Addressed.

@jonpsy
Copy link
Member Author

jonpsy commented Aug 3, 2021

@zoq Lemme know if you have any further comments. I think this is good to go.

coatless
coatless approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@coatless coatless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🌔

say4n
say4n approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@say4n say4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

zoq
zoq approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zoq zoq merged commit e6aaf18 into mlpack:master Aug 6, 2021
@zoq
Copy link
Member

zoq commented Aug 6, 2021

Looking at the comments, pretty clear that everyone likes the notebook, great job!

@jonpsy jonpsy deleted the SoS branch August 6, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@say4n say4n say4n approved these changes

@zoq zoq zoq approved these changes

@coatless coatless coatless approved these changes

Assignees
No one assigned
Labels
notebook s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonpsy @zoq @coatless @say4n