Rocket injector design optimization #165
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
zoq
added
c: examples
t: added feature
notebook
and removed
s: unanswered
s: unlabeled
c: examples
labels
|
Ah no, currently working on documenting. There were some talks of interactive images right? |
|
👍 🟢 Hi, it looks good to me, perhaps you could commit with the cell outputs for the notebook? |
| "source": [ | ||
| " **The Achilles heel**\n", | ||
| " \n", | ||
| "A good injector design makes all the difference between your system performing excellently and it exploding. Unfortunately, the latter was the case for the ambitious project. \n", |
I think that is a good idea, especially if you just like to read the notebook having the output would be great. |
Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>
Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>
Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>
|
My line of reasoning is that if we put all the outputs up front for them it'll kill the suspence. I want them to read the notebook and subsequently execute the cell one by one, allowing it to "slowly reveal' itself. Atleast, that's what I think. |
|
I totally agree with that school of thought! However, do consider that since this is the examples repository, not everyone will clone the repository and run the notebook on their systems to check out what it does. I think it may be a good option to have the output ready to view on the repository itself. Maybe the visual results might entice someone enough to take the library for a spin! :) |
|
I think @say4n is advocating for only showing the output/graph of the last code cell. The rest are pretty hard to show unless you take the head of the pareto front (e.g first 5.) |
|
Agreed, I would also just show the output of each cell since it allows someone to follow the notebook without actually running it. That said, in this particular case even if we run the notebook and save the output, we will not see the plot from the last cell, since images displayed with auto im = xw::image_from_file("scatter.png").finalize();
imare not embedded in the notebook output itself. |
|
If everyone's with the motion, then it's fine by me. Do note that the final notebook will have an interactive widget, so there won't be any "visible output". We could, however, display the HEAD of the |
|
Looks good to me, kudos Sai! 🚀 |
No description provided.