Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support mll-lab/php-utils 2 #17

Merged
merged 3 commits into from
May 23, 2024
Merged

feat: Support mll-lab/php-utils 2 #17

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1a2dd0
feat: Support `mll-lab/php-utils` 2
May 22, 2024
9065f21
Drop support for `mll-lab/php-utils` ^1.3
May 22, 2024
56b3729
Revert drop support for `mll-lab/php-utils` ^1.3
May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@ See [GitHub releases](https://github.com/mll-lab/laravel-utils/releases).

## Unreleased

## v6.0.0

### Added

- Support `mll-lab/php-utils` 2

### Changed

- Drop support for `mll-lab/php-utils` ^1.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Seems like an unnecessary breaking change that causes churn.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kilya11 requested this change to keep the dependencies simple.
I am actualy ok with both versions because both have pros and cons

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the simplicity has its cost. Let the #1 contributor approve.


## v5.2.1

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"require": {
"php": "^8.1",
"illuminate/support": "^9.51 || ^10 || ^11",
"mll-lab/php-utils": "^1.13",
"mll-lab/php-utils": "^2",
"mll-lab/str_putcsv": "^1",
"ramsey/uuid": "^4.7",
"thecodingmachine/safe": "^1 || ^2"
Expand Down
Loading