feat: Support mll-lab/php-utils 2
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilya11
reviewed
May 22, 2024
spawnia
reviewed
May 22, 2024
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Drop support for `mll-lab/php-utils` ^1.3 |
There was a problem hiding this comment.
Why? Seems like an unnecessary breaking change that causes churn.
There was a problem hiding this comment.
@kilya11 requested this change to keep the dependencies simple.
I am actualy ok with both versions because both have pros and cons
There was a problem hiding this comment.
Sure, the simplicity has its cost. Let the #1 contributor approve.
kilya11
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Added automated tests[ ] Documented for all relevant versionsChanges
mll-lab/php-utils2