Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint standard rules #462

Merged
merged 2 commits into from
May 9, 2024
Merged

Eslint standard rules #462

merged 2 commits into from
May 9, 2024

Conversation

erinesullivan
Copy link
Contributor

Overview

When setting up the new eslint, a lot of rules went away. This pull request reinstalls these two plugins and applies all of the original rules from eslint-config-standard:

  • eslint-plugin-import
  • eslint-plugin-n

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Run npm run lint and npm run lint:fix to see if it works.

@erinesullivan erinesullivan added the dependencies Pull requests that update a dependency file label May 9, 2024
@erinesullivan erinesullivan self-assigned this May 9, 2024
@erinesullivan erinesullivan merged commit a2c9700 into master May 9, 2024
6 checks passed
@erinesullivan erinesullivan deleted the eslint-standard-rules branch May 9, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erinesullivan erinesullivan

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erinesullivan