Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Browse redirect has brief 404 #417

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Bug: Browse redirect has brief 404 #417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c434c0c
Wrapping history change in conditional instead of by browsing.
erinesullivan Feb 7, 2024
66b0bd8
Wrapping URL changes in if/else statement. Location based on current …
erinesullivan Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/modules/search/components/SearchBox/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,22 @@ function SearchBox ({ history, match, location }) {
format: 'RFC1738'
});

const urlLocation = `/${match.params.datastoreSlug}${browseOption ? `/browse/${dropdownOption.replace('browse_by_', '')}` : ''}?${newURL}`;

// Redirect users if browse option has been submitted
if (browseOption) {
window.location.href = urlLocation;
let href = 'https://browse.workshop.search.lib.umich.edu';
if (window.location.hostname === 'search.lib.umich.edu') {
href = `/${match.params.datastoreSlug}/browse`;
}
if (window.location.hostname === 'localhost') {
href = 'http://localhost:4567';
}
window.location.href = `${href}/${dropdownOption.replace('browse_by_', '')}?${newURL}`;
} else {
// Do not submit if query remains unchanged
if (query === newQuery) return;
// Submit new search
history.push(`/${match.params.datastoreSlug}?${newURL}`);
}

// Do not submit if query remains unchanged
if (query === newQuery) return;

// Submit new search
history.push(urlLocation);
}

return (
Expand Down
Loading