Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Browse redirect has brief 404 #417

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

erinesullivan
Copy link
Contributor

@erinesullivan erinesullivan commented Feb 7, 2024

Overview

When going from Search to Catalog Browse, viewers briefly face a 404 page before being redirected. This pull request wraps the logic in an if/else statement, and also updates the location based on the current hostname.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • In the list of search options, select one under Browse by, and submit a search.
    • Do you encounter a 404 page?
    • Are you taken to the correct Catalog Browse page?
    • Does Search work fine everywhere else?

@erinesullivan erinesullivan merged commit d097724 into master Feb 8, 2024
6 checks passed
@erinesullivan erinesullivan deleted the bug-browse-redirect-404 branch February 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant