Add compatibility for Ember canary

[mitchlloyd]

This could probably be merged in, but there is one very minor change from using didDestroyElement to using willDestroyElement. Opened an issue in Ember to fix this.

[rwjblue]

Awesome job here @mitchlloyd!

[rwjblue]

Upstream issue in Ember has been fixed (in emberjs/ember.js#14227).

[mitchlloyd]

@rwjblue On current canary (emberjs/ember.js@945d81a), I'm getting a new error in tests during teardown when calling appendTo.

Uncaught TypeError: Cannot read property 'length' of null

Which is coming from here:

https://github.com/tildeio/glimmer/blob/0f73a9f8c7c2d697821d8912d5f3d9d6c57768fd/packages/glimmer-runtime/lib/environment.ts#L222

I believe this is related to this commit in Glimmer:

glimmerjs/glimmer-vm@7f7ae4d

I'll dig in and see if I can figure out what's going on.

[rwjblue]

Right, but that basically means that we are trying to "do things" without being inside of a env.begin() / env.commit() transaction. What is the app doing when this error happens?

[rwjblue]

The current issue should be fixed by emberjs/ember.js#14241, would love another set of eyes though.

Test suite passes with that change though:

[rwjblue]

FWIW, this now fixes current beta (2.9+).

@mitchlloyd - Any blockers on landing this?

[mitchlloyd]

No blockers, just wanted to make sure all the "multiple root components" stuff settled in Ember.

Released as 1.1.0.