Implement correctly ordered destruction hooks. #14227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2016 10:03
These additional assertions/tests were added in 2.8 beta channel against HTMLBars rendering engine. This ports them forward to master/canary.
rwjblue
force-pushed
the
lifecycle-hook-teardown
branch
from
d6eb671 to
3dcde0f
Compare
|
Discussed with @krisselden and while there is still work to be done in Glimmer to remove the need to override some of these things this is still a step forward and we can iterate on it... |
| @@ -69,6 +69,9 @@ export default class Environment extends GlimmerEnvironment { | |||
| super(...arguments); | |||
| this.owner = owner; | |||
|
|
|||
| // can be removed once https://github.com/tildeio/glimmer/pull/305 lands | |||
| this.destroyedComponents = undefined; | |||
There was a problem hiding this comment.
I thought you indented to just use this.destructors since you merged that PR?
There was a problem hiding this comment.
ah we haven't merged yet. ignore me
There was a problem hiding this comment.
Right, I'd rather have a small kludge here in Ember for beta.1 and fix upstream in that other PR for beta.2.
This was referenced Sep 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @krisselden