Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add es2017 build target #8931

Merged
merged 3 commits into from
Jul 13, 2022
Merged

fix: add es2017 build target #8931

merged 3 commits into from
Jul 13, 2022

Conversation

Johann150
Copy link
Contributor

What

  • Add the es2017 build target to be compatible with more browsers.
  • Refactor modal component to ref sugar and setup sugar.

Why

fix #8603

Additional info

packages/client/src/init.ts has only two lines changed which wrap the whole file body in a async function that is immediately called, like this:

(async () => {
  // ...
})();

All other changes to the file are indentation changes, you can see this if you use git show 527652766e563a882d89a7d336376912a1f37e38 --ignore-all-space -- packages/client/src/init.ts.

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 4, 2022
@tamaina
Copy link
Contributor

tamaina commented Jul 5, 2022

Top level await使えないのは厳しいんじゃ?と思ったけど割となんとかなっている

@syuilo に判断任せる

@tamaina tamaina requested a review from syuilo July 5, 2022 07:30
@syuilo
Copy link
Member

syuilo commented Jul 5, 2022

うーむ
es2017までしか動かないブラウザを使っているユーザーがどれくらいいるかによる
そしてそのブラウザがいつes2017以降に対応する予定なのかにもよる

@rinsuki
Copy link
Contributor

rinsuki commented Jul 5, 2022

外からやってきて投稿見れないのはかなり微妙なのでとりあえず見れるくらいの対応はしておいてもいいんじゃないって気はするけど

@syuilo syuilo merged commit ee9bb82 into misskey-dev:develop Jul 13, 2022
@syuilo
Copy link
Member

syuilo commented Jul 13, 2022

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite causes incompatibility with older browsers
4 participants