-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 新カスタム絵文字管理画面(β)の追加 #13473
Merged
mi-gh-maintainer
merged 200 commits into
misskey-dev:develop
from
samunohito:feature/emoji-grid
Jan 20, 2025
Merged
feat: 新カスタム絵文字管理画面(β)の追加 #13473
mi-gh-maintainer
merged 200 commits into
misskey-dev:develop
from
samunohito:feature/emoji-grid
Jan 20, 2025
+8,274
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/misskey-js/src/api.types.ts # packages/misskey-js/src/autogen/apiClientJSDoc.ts # packages/misskey-js/src/autogen/endpoint.ts # packages/misskey-js/src/autogen/entities.ts # packages/misskey-js/src/autogen/models.ts # packages/misskey-js/src/autogen/types.ts
# Conflicts: # packages/frontend/package.json # packages/misskey-js/src/autogen/apiClientJSDoc.ts # packages/misskey-js/src/autogen/endpoint.ts # packages/misskey-js/src/autogen/entities.ts # packages/misskey-js/src/autogen/models.ts # packages/misskey-js/src/autogen/types.ts # pnpm-lock.yaml
# Conflicts: # packages/misskey-js/src/autogen/apiClientJSDoc.ts # packages/misskey-js/src/autogen/endpoint.ts # packages/misskey-js/src/autogen/entities.ts # packages/misskey-js/src/autogen/models.ts # packages/misskey-js/src/autogen/types.ts
reopen |
syuilo
reviewed
Jan 14, 2025
@@ -56,6 +56,7 @@ const toggle = () => { | |||
display: flex; | |||
transition: all 0.2s ease; | |||
user-select: none; | |||
align-items: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
中央寄せするとラベルとY座標が合わなくなってしまうわね
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
78ea255
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 16, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 16, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 16, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 17, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 17, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 17, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 17, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 17, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 17, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 18, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 18, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 18, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 18, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 18, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 20, 2025
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 20, 2025
f9ad127
into
misskey-dev:develop
35 of 36 checks passed
Thank you 🙏 |
5 tasks
nanasina8
pushed a commit
to nanasina8/misskey
that referenced
this pull request
Jan 21, 2025
* wip * wip * wip * wip * wip * wip * wip * wip * fix * fix * fix * fix size * fix register logs * fix img autosize * fix row selection * support delete * fix border rendering * fix display:none * tweak comments * support choose pc file and drive file * support directory drag-drop * fix * fix comment * support context menu on data area * fix autogen * wip イベント整理 * イベントの整理 * refactor grid * fix cell re-render bugs * fix row remove * fix comment * fix validation * fix utils * list maximum * add mimetype check * fix * fix number cell focus * fix over 100 file drop * remove log * fix patchData * fix performance * fix * support update and delete * support remote import * fix layout * heightやめる * fix performance * add list v2 endpoint * support pagination * fix api call * fix no clickable input text * fix limit * fix paging * fix * fix * support search * tweak logs * tweak cell selection * fix range select * block delete * add comment * fix * support import log * fix dialog * refactor * add confirm dialog * fix name * fix autogen * wip * support image change and highlight row * add columns * wip * support sort * add role name * add index to emoji * refine context menu setting * support role select * remove unused buttons * fix url * fix MkRoleSelectDialog.vue * add route * refine remote page * enter key search * fix paste bugs * fix copy/paste * fix keyEvent * fix copy/paste and delete * fix comment * fix MkRoleSelectDialog.vue and storybook scenario * fix MkRoleSelectDialog.vue and storybook scenario * add MkGrid.stories.impl.ts * fix * [wip] add custom-emojis-manager2.stories.impl.ts * [wip] add custom-emojis-manager2.stories.impl.ts * wip * 課題はまだ残っているが、ひとまず完了 * fix validation and register roles * fix upload * optimize import * patch from dev * i18n * revert excess fixes * separate sort order component * add SPDX * revert excess fixes * fix pre test * fix bugs * add type column * fix types * fix CHANGELOG.md * fix lit * lint * tweak style * refactor * fix ci * autogen * Update types.ts * CSS Module化 * fix log * 縦スクロールを無効化 * MkStickyContainer化 * regenerate locales index.d.ts * fix * fix * テスト * ランダム値によるUI変更の抑制 * テスト * tableタグやめる * fix last-child css * fix overflow css * fix endpoint.ts * tweak css * 最新への追従とレイアウト微調整 * ソートキーの指定方法を他と合わせた * fix focus * fix layout * v2エンドポイントのルールに対応 * 表示条件などを微調整 * fix MkDataCell.vue * fix error code * fix error * add comment to MkModal.vue * Update index.d.ts * fix CHANGELOG.md * fix color theme * fix CHANGELOG.md * fix CHANGELOG.md * fix center * fix: テーブルにフォーカスがあり、通常状態であるときはキーイベントの伝搬を止める * fix: ロール選択用のダイアログにてコンディショナルロールを×ボタンで除外できなかったのを修正 * fix remote list folder * sticky footers * chore: fix ci error(just single line-break diff) * fix loading * fix like * comma to space * fix ci * fix ci * removed align-center --------- Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com> Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
packages/backend:test
packages/backend
Server side specific issue/PR
packages/frontend
Client side specific issue/PR
packages/misskey-js
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
カスタム絵文字の登録画面をリニューアルし、複数の絵文字に対して同時に登録・更新作業を行えるようにしました。
Why
resolve #10996
Additional info (optional)
既存のカスタム絵文字管理画面はそのままのこし、新画面はβ版の位置づけで追加しています(安定したら完全に置き換える考え)。
Checklist