Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added preproduction account for mojfin #8712

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Dec 9, 2024

A reference to the issue / Description of it

#8677

How does this PR fix the problem?

Covers first part of new account process.

How has this been tested?

Test through CI pipeline tests

Deployment Plan / Instructions

Deploy through CI

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@dms1981 dms1981 requested a review from a team as a code owner December 9, 2024 12:48
@github-actions github-actions bot added the onboarding Tasks to onboard teams label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@Khatraf Khatraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dms1981 dms1981 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit b937e7f Dec 9, 2024
16 checks passed
@dms1981 dms1981 deleted the feature/9677-mojfin-preprod branch December 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Tasks to onboard teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants