Update baselines module to v7.2.0 #7315

richgreen-moj · 2024-06-24T12:45:14Z

A reference to the issue / Description of it

Update baselines module to v7.2.0

How does this PR fix the problem?

For this issue #6490 some unit testing has been added to the baselines module.

This PR updates references to the module to the latest version.

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check `x` in `[ ]` of list items)

I have performed a self-review of my own code
All checks have passed
I have made corresponding changes to the documentation
Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

github-actions · 2024-06-24T12:47:17Z

`Trivy Scan` Success

Show Output

```hcl

Trivy will check the following folders:
terraform/environments/bootstrap/secure-baselines

Running Trivy in terraform/environments/bootstrap/secure-baselines
2024-06-24T12:47:05Z INFO Need to update DB
2024-06-24T12:47:05Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-24T12:47:07Z INFO Vulnerability scanning is enabled
2024-06-24T12:47:07Z INFO Misconfiguration scanning is enabled
2024-06-24T12:47:07Z INFO Need to update the built-in policies
2024-06-24T12:47:07Z INFO Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-24T12:47:08Z INFO Secret scanning is enabled
2024-06-24T12:47:08Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-24T12:47:08Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-24T12:47:10Z INFO Number of language-specific files num=0
2024-06-24T12:47:10Z INFO Detected config files num=8

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/config.tf (terraform)

Tests: 1 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

Tests: 7 (SUCCESSES: 5, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/modules/cloudtrail/main.tf (terraform)

Tests: 5 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/bootstrap/secure-baselines

*****************************

Running Checkov in terraform/environments/bootstrap/secure-baselines
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-06-24 12:47:13,145 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 10, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/bootstrap/secure-baselines

*****************************

Running tflint in terraform/environments/bootstrap/secure-baselines
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

`Trivy Scan` Success

Show Output

*****************************

Trivy will check the following folders:
terraform/environments/bootstrap/secure-baselines

*****************************

Running Trivy in terraform/environments/bootstrap/secure-baselines
2024-06-24T12:47:05Z	INFO	Need to update DB
2024-06-24T12:47:05Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-24T12:47:07Z	INFO	Vulnerability scanning is enabled
2024-06-24T12:47:07Z	INFO	Misconfiguration scanning is enabled
2024-06-24T12:47:07Z	INFO	Need to update the built-in policies
2024-06-24T12:47:07Z	INFO	Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-24T12:47:08Z	INFO	Secret scanning is enabled
2024-06-24T12:47:08Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-24T12:47:08Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-24T12:47:10Z	INFO	Number of language-specific files	num=0
2024-06-24T12:47:10Z	INFO	Detected config files	num=8

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/config.tf (terraform)
==========================================================================================================================================
Tests: 1 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)
=============================================================================================================================================================================================================================================================
Tests: 7 (SUCCESSES: 5, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/modules/cloudtrail/main.tf (terraform)
===========================================================================================================================================================
Tests: 5 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

github-actions · 2024-06-24T13:44:47Z

`Trivy Scan` Success

Show Output

```hcl

Trivy will check the following folders:
terraform/environments/bootstrap/secure-baselines terraform/modernisation-platform-account

Running Trivy in terraform/environments/bootstrap/secure-baselines
2024-06-24T13:44:24Z INFO Need to update DB
2024-06-24T13:44:24Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-24T13:44:25Z INFO Vulnerability scanning is enabled
2024-06-24T13:44:25Z INFO Misconfiguration scanning is enabled
2024-06-24T13:44:25Z INFO Need to update the built-in policies
2024-06-24T13:44:25Z INFO Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-24T13:44:26Z INFO Secret scanning is enabled
2024-06-24T13:44:26Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-24T13:44:26Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-24T13:44:27Z INFO Number of language-specific files num=0
2024-06-24T13:44:27Z INFO Detected config files num=8

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/config.tf (terraform)

Tests: 1 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

Tests: 7 (SUCCESSES: 5, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/modules/cloudtrail/main.tf (terraform)

Tests: 5 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

Running Trivy in terraform/modernisation-platform-account
2024-06-24T13:44:28Z INFO Vulnerability scanning is enabled
2024-06-24T13:44:28Z INFO Misconfiguration scanning is enabled
2024-06-24T13:44:28Z INFO Secret scanning is enabled
2024-06-24T13:44:28Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-24T13:44:28Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-24T13:44:40Z INFO Number of language-specific files num=0
2024-06-24T13:44:40Z INFO Detected config files num=22

../modules/collaborators/main.tf (terraform)

Tests: 24 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 24)
Failures: 0 (HIGH: 0, CRITICAL: 0)

git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-group-with-policies/policies.tf (terraform)

Tests: 49 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 49)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/config.tf (terraform)

Tests: 1 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

Tests: 7 (SUCCESSES: 6, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/modules/cloudtrail/main.tf (terraform)

Tests: 5 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-iam-superadmins?ref=ed65a526a2bcd687b47e18988a6c0edead771636/github.com/terraform-aws-modules/terraform-aws-iam.git/modules/iam-group-with-policies?ref=25e2bf9f9f4757a7014b55db981be9d2beeab445/policies.tf (terraform)

Tests: 44 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 44)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-iam-superadmins?ref=ed65a526a2bcd687b47e18988a6c0edead771636/main.tf (terraform)

Tests: 39 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 39)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/main.tf (terraform)

Tests: 7 (SUCCESSES: 6, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/replication.tf (terraform)

Tests: 8 (SUCCESSES: 6, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

iam.tf (terraform)

Tests: 5 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 5)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/bootstrap/secure-baselines terraform/modernisation-platform-account

*****************************

Running Checkov in terraform/environments/bootstrap/secure-baselines
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-06-24 13:44:42,767 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 10, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

*****************************

Running Checkov in terraform/modernisation-platform-account
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-06-24 13:44:45,582 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab:None (for external modules, the --download-external-modules flag is required)
2024-06-24 13:44:45,582 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-iam-superadmins?ref=ed65a526a2bcd687b47e18988a6c0edead771636:None (for external modules, the --download-external-modules flag is required)
2024-06-24 13:44:45,582 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-group-with-policies:~> 5.0 (for external modules, the --download-external-modules flag is required)
2024-06-24 13:44:45,583 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=82f546bd5f002674138a2ccdade7d7618c6758b3:None (for external modules, the --download-external-modules flag is required)
2024-06-24 13:44:45,583 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 211, Failed checks: 0, Skipped checks: 24


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/bootstrap/secure-baselines terraform/modernisation-platform-account

*****************************

Running tflint in terraform/environments/bootstrap/secure-baselines
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

*****************************

Running tflint in terraform/modernisation-platform-account
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

`Trivy Scan` Success

Show Output

*****************************

Trivy will check the following folders:
terraform/environments/bootstrap/secure-baselines terraform/modernisation-platform-account

*****************************

Running Trivy in terraform/environments/bootstrap/secure-baselines
2024-06-24T13:44:24Z	INFO	Need to update DB
2024-06-24T13:44:24Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-24T13:44:25Z	INFO	Vulnerability scanning is enabled
2024-06-24T13:44:25Z	INFO	Misconfiguration scanning is enabled
2024-06-24T13:44:25Z	INFO	Need to update the built-in policies
2024-06-24T13:44:25Z	INFO	Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-24T13:44:26Z	INFO	Secret scanning is enabled
2024-06-24T13:44:26Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-24T13:44:26Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-24T13:44:27Z	INFO	Number of language-specific files	num=0
2024-06-24T13:44:27Z	INFO	Detected config files	num=8

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/config.tf (terraform)
==========================================================================================================================================
Tests: 1 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)
=============================================================================================================================================================================================================================================================
Tests: 7 (SUCCESSES: 5, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/modules/cloudtrail/main.tf (terraform)
===========================================================================================================================================================
Tests: 5 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

*****************************

Running Trivy in terraform/modernisation-platform-account
2024-06-24T13:44:28Z	INFO	Vulnerability scanning is enabled
2024-06-24T13:44:28Z	INFO	Misconfiguration scanning is enabled
2024-06-24T13:44:28Z	INFO	Secret scanning is enabled
2024-06-24T13:44:28Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-24T13:44:28Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-24T13:44:40Z	INFO	Number of language-specific files	num=0
2024-06-24T13:44:40Z	INFO	Detected config files	num=22

../modules/collaborators/main.tf (terraform)
============================================
Tests: 24 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 24)
Failures: 0 (HIGH: 0, CRITICAL: 0)


git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-group-with-policies/policies.tf (terraform)
===================================================================================================================================================================
Tests: 49 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 49)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/config.tf (terraform)
==========================================================================================================================================
Tests: 1 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)
=============================================================================================================================================================================================================================================================
Tests: 7 (SUCCESSES: 6, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/modules/cloudtrail/main.tf (terraform)
===========================================================================================================================================================
Tests: 5 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-iam-superadmins?ref=ed65a526a2bcd687b47e18988a6c0edead771636/github.com/terraform-aws-modules/terraform-aws-iam.git/modules/iam-group-with-policies?ref=25e2bf9f9f4757a7014b55db981be9d2beeab445/policies.tf (terraform)
======================================================================================================================================================================================================================================================================================
Tests: 44 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 44)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-iam-superadmins?ref=ed65a526a2bcd687b47e18988a6c0edead771636/main.tf (terraform)
==============================================================================================================================================
Tests: 39 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 39)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/main.tf (terraform)
========================================================================================================================================
Tests: 7 (SUCCESSES: 6, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/replication.tf (terraform)
===============================================================================================================================================
Tests: 8 (SUCCESSES: 6, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)


iam.tf (terraform)
==================
Tests: 5 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 5)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

mikereiddigital

lg2m

point baselines to unit-test branch on baselines module

59d03f6

richgreen-moj had a problem deploying to production June 24, 2024 12:45 — with GitHub Actions Failure

richgreen-moj mentioned this pull request Jun 24, 2024

Feature/add-unit-tests ministryofjustice/modernisation-platform-terraform-baselines#492

Merged

point to v7.2.0 for baseline module

04bbb7e

richgreen-moj had a problem deploying to production June 24, 2024 13:42 — with GitHub Actions Failure

richgreen-moj changed the title ~~Point baselines to add-unit-tests branch~~ Update baselines module to v7.2.0 Jun 24, 2024

richgreen-moj marked this pull request as ready for review June 24, 2024 13:46

richgreen-moj requested a review from a team as a code owner June 24, 2024 13:46

richgreen-moj temporarily deployed to production June 24, 2024 14:36 — with GitHub Actions Inactive

richgreen-moj temporarily deployed to production June 24, 2024 14:43 — with GitHub Actions Inactive

richgreen-moj temporarily deployed to production June 24, 2024 14:47 — with GitHub Actions Inactive

mikereiddigital approved these changes Jun 24, 2024

View reviewed changes

ASTRobinson approved these changes Jun 24, 2024

View reviewed changes

richgreen-moj added this pull request to the merge queue Jun 24, 2024

Merged via the queue into main with commit 5d40b06 Jun 24, 2024
13 of 15 checks passed

richgreen-moj deleted the update-baselines-tag branch June 24, 2024 15:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update baselines module to v7.2.0 #7315

Update baselines module to v7.2.0 #7315

richgreen-moj commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 24, 2024

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/config.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/modules/cloudtrail/main.tf (terraform)

github-actions bot commented Jun 24, 2024

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/config.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/modules/cloudtrail/main.tf (terraform)

../modules/collaborators/main.tf (terraform)

git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-group-with-policies/policies.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/config.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/modules/cloudtrail/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-iam-superadmins?ref=ed65a526a2bcd687b47e18988a6c0edead771636/github.com/terraform-aws-modules/terraform-aws-iam.git/modules/iam-group-with-policies?ref=25e2bf9f9f4757a7014b55db981be9d2beeab445/policies.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-iam-superadmins?ref=ed65a526a2bcd687b47e18988a6c0edead771636/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/replication.tf (terraform)

iam.tf (terraform)

mikereiddigital left a comment

Update baselines module to v7.2.0 #7315

Update baselines module to v7.2.0 #7315

Conversation

richgreen-moj commented Jun 24, 2024 • edited Loading

A reference to the issue / Description of it

How does this PR fix the problem?

How has this been tested?

Deployment Plan / Instructions

Checklist (check x in [ ] of list items)

Additional comments (if any)

github-actions bot commented Jun 24, 2024

Trivy Scan Success

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/config.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=f737104c63122ec92d82ddc376ed458801d14d2a/modules/cloudtrail/main.tf (terraform)

CTFLint Scan Success

Trivy Scan Success

github-actions bot commented Jun 24, 2024

Trivy Scan Success

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/config.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/modules/cloudtrail/main.tf (terraform)

../modules/collaborators/main.tf (terraform)

git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-group-with-policies/policies.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/config.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=957a6ca5f5a4e81fa6fa7799a8e060b630bc14ab/modules/cloudtrail/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-iam-superadmins?ref=ed65a526a2bcd687b47e18988a6c0edead771636/github.com/terraform-aws-modules/terraform-aws-iam.git/modules/iam-group-with-policies?ref=25e2bf9f9f4757a7014b55db981be9d2beeab445/policies.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-iam-superadmins?ref=ed65a526a2bcd687b47e18988a6c0edead771636/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/main.tf (terraform)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/replication.tf (terraform)

iam.tf (terraform)

CTFLint Scan Success

Trivy Scan Success

mikereiddigital left a comment

Choose a reason for hiding this comment

richgreen-moj commented Jun 24, 2024 •

edited

Loading

Checklist (check `x` in `[ ]` of list items)

`Trivy Scan` Success

`CTFLint Scan` Success

`Trivy Scan` Success

`Trivy Scan` Success

`CTFLint Scan` Success

`Trivy Scan` Success