Feature/add-unit-tests #492
Conversation
|
|
{{ message }}
Merged
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
ASTRobinson
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ministryofjustice/modernisation-platform#6490 Add unit tests where missing
What's changed
I've added unit tests for the backup module within the baselines module and a GH actions workflow file to run them.
As the baselines module is made up of a series of other modules, some of which have constraints that mean they won't be possible to unit test easily (e.g. IAM access analyser can only be built once per region) I decided to specifically target the backup child module with it's own dedicated
backup-testdirectory but have kept a singlebaselines_test.gofile that we can add to if there are any more child modules that can be tested.Testing
I tested it locally and now via GH Actions as shown in the status checks below.
I've also added a draft PR ministryofjustice/modernisation-platform#7315 to update the baselines module to use this revision and it reports no changes on a terraform plan: https://github.com/ministryofjustice/modernisation-platform/actions/runs/9645571244/job/26600097925?pr=7315#step:7:318
This is to be expected as I've created variables and set the default values to the original names used for the various resources. The only change will be on apply where some extra outputs will be generated.
Future action
This just tests the backup module, in future we can add more tests for the others where possible. I will write some stories for ones which should be possible.