Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added macie2 to MemberInfrastructureAccess so macie is available everywhere #7002

Merged
merged 1 commit into from
May 15, 2024

Conversation

SteveLinden
Copy link
Contributor

A reference to the issue / Description of it

To set up macie access for everyone, everywhere

@SteveLinden SteveLinden requested a review from a team as a code owner May 14, 2024 15:36
Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the terraform/environments/bootstrap/member-bootstrap/iam.tf file will alter the IAM permissions for all members on the MP platform. In particular the member-access policy which defines the permissions members have for building IaC in their environments or the github OIDC role that defines the permissions for their application CI/CD pipelines. Please ensure that any permissions changes have been agreed with the wider team.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/bootstrap/member-bootstrap


Running Trivy in terraform/environments/bootstrap/member-bootstrap
2024-05-14T15:38:36Z INFO Need to update DB
2024-05-14T15:38:36Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-05-14T15:38:38Z INFO Vulnerability scanning is enabled
2024-05-14T15:38:38Z INFO Misconfiguration scanning is enabled
2024-05-14T15:38:38Z INFO Need to update the built-in policies
2024-05-14T15:38:38Z INFO Downloading the built-in policies...
50.41 KiB / 50.41 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-14T15:38:38Z INFO Secret scanning is enabled
2024-05-14T15:38:38Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-14T15:38:38Z INFO Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-14T15:38:44Z INFO Number of language-specific files num=0
2024-05-14T15:38:44Z INFO Detected config files num=5

github.com/ministryofjustice/modernisation-platform-github-oidc-role?ref=c3bde7c787038ff5536bfb1b73781072edbb74da/main.tf (terraform)

Tests: 3 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 3)
Failures: 0 (HIGH: 0, CRITICAL: 0)

iam.tf (terraform)

Tests: 162 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 162)
Failures: 0 (HIGH: 0, CRITICAL: 0)

instance-scheduler.tf (terraform)

Tests: 13 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 13)
Failures: 0 (HIGH: 0, CRITICAL: 0)

ssm.tf (terraform)

Tests: 8 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 8)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/bootstrap/member-bootstrap

*****************************

Running Checkov in terraform/environments/bootstrap/member-bootstrap
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-05-14 15:38:46,821 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-cross-account-access?ref=6819b090bce6d3068d55c7c7b9b3fd18c9dca648:None (for external modules, the --download-external-modules flag is required)
2024-05-14 15:38:46,822 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-role?ref=c3bde7c787038ff5536bfb1b73781072edbb74da:None (for external modules, the --download-external-modules flag is required)
2024-05-14 15:38:46,822 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=82f546bd5f002674138a2ccdade7d7618c6758b3:None (for external modules, the --download-external-modules flag is required)
2024-05-14 15:38:46,822 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:~> 5 (for external modules, the --download-external-modules flag is required)
2024-05-14 15:38:46,822 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=0179859e6fafc567843cd55c0b05d325d5012dc4:None (for external modules, the --download-external-modules flag is required)
2024-05-14 15:38:46,822 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-roles:~> 5 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 129, Failed checks: 0, Skipped checks: 51


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/bootstrap/member-bootstrap

*****************************

Running tflint in terraform/environments/bootstrap/member-bootstrap
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/environments/bootstrap/member-bootstrap

*****************************

Running Trivy in terraform/environments/bootstrap/member-bootstrap
2024-05-14T15:38:36Z	INFO	Need to update DB
2024-05-14T15:38:36Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-05-14T15:38:38Z	INFO	Vulnerability scanning is enabled
2024-05-14T15:38:38Z	INFO	Misconfiguration scanning is enabled
2024-05-14T15:38:38Z	INFO	Need to update the built-in policies
2024-05-14T15:38:38Z	INFO	Downloading the built-in policies...
50.41 KiB / 50.41 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-14T15:38:38Z	INFO	Secret scanning is enabled
2024-05-14T15:38:38Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-14T15:38:38Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-14T15:38:44Z	INFO	Number of language-specific files	num=0
2024-05-14T15:38:44Z	INFO	Detected config files	num=5

github.com/ministryofjustice/modernisation-platform-github-oidc-role?ref=c3bde7c787038ff5536bfb1b73781072edbb74da/main.tf (terraform)
=====================================================================================================================================
Tests: 3 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 3)
Failures: 0 (HIGH: 0, CRITICAL: 0)


iam.tf (terraform)
==================
Tests: 162 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 162)
Failures: 0 (HIGH: 0, CRITICAL: 0)


instance-scheduler.tf (terraform)
=================================
Tests: 13 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 13)
Failures: 0 (HIGH: 0, CRITICAL: 0)


ssm.tf (terraform)
==================
Tests: 8 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 8)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

@SteveLinden
Copy link
Contributor Author

Ran successfully on sprinkler

@SteveLinden SteveLinden added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit efd2449 May 15, 2024
13 checks passed
@SteveLinden SteveLinden deleted the access/add-macie2 branch May 15, 2024 05:38
@dms1981 dms1981 changed the title Added macie2 to MemberInfrastructureAccess do macie is available everywhere Added macie2 to MemberInfrastructureAccess so macie is available everywhere May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants