Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firehose Data Transfers - Adds an additional module call but for the firewall vpc flow logs. #6545

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

mikereiddigital
Copy link
Contributor

@mikereiddigital mikereiddigital commented Mar 20, 2024

A reference to the issue / Description of it

As per title. This change adds an additional module call to generate firehose data streams for the firewall VPC flow logs.

How does this PR fix the problem?

This covers one of the requirements to share vpc flow log data with SecOps.

How has this been tested?

Has been tested via local plan.

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@Khatraf Khatraf merged commit c22770f into main Mar 20, 2024
7 checks passed
@Khatraf Khatraf deleted the firehose-vpc-logs branch March 20, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants